| Message ID | 20250526052553.42766-1-akhilrajeev@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties | expand |
On 02/06/2025 13:10, Akhil R wrote: >> >>> + Module reset. This property is optional for controllers in Tegra194 and later >> >> Your binding says Tegra210 requires it, but 210 feels like something >> later than 194. Maybe that's obvious for people knowing that device? > > Tegra210 is in fact an older device than T194. I will probably mention the chip names > instead of “later” in the next version. > >> >> Anyway, please wrap at 80 (see kernel coding style). > > Okay. Will update. > checkpatch.pl don’t warn now till 100 characters. I thought it was updated. Checkpatch is a tool, not coding style. Coding style document describes the coding style. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml index b57ae6963e62..c1d38e6ff7d7 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml @@ -97,7 +97,9 @@ properties: resets: items: - - description: module reset + - description: | + Module reset. This property is optional for controllers in Tegra194 and later + chips where an internal software reset is available as an alternative. reset-names: items: @@ -116,6 +118,13 @@ properties: - const: rx - const: tx +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + allOf: - $ref: /schemas/i2c/i2c-controller.yaml - if: @@ -169,6 +178,18 @@ allOf: properties: power-domains: false + - if: + not: + properties: + compatible: + contains: + enum: + - nvidia,tegra194-i2c + then: + required: + - resets + - reset-names + unevaluatedProperties: false examples:
Specify the properties which are essential for the Tegra I2C driver to function correctly. Though all the existing DT nodes have these properties already, it was not mandated by the DT bindings. Signed-off-by: Akhil R <akhilrajeev@nvidia.com> --- v2->v3: * Updated commit description on the details and fixed indentation issue. v1->v2: * Added all required properties .../bindings/i2c/nvidia,tegra20-i2c.yaml | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)