| Message ID | 20250609020223.269407-1-superm1@kernel.org |
|---|---|
| Headers | show |
| Series | Don't make noise about disconnected USB4 devices | expand |
Hi, General remarks: - broken threading on 1/2 and 2/2 - some Cc missing on individual patch emails On Sun, 8 Jun 2025 20:58:00 -0500, Mario Limonciello wrote: > When a USB4 or TBT3 dock is disconnected a lot of warnings and errors > are emitted related to the PCIe tunnels and XHCI controllers in th > dock. These patches will probably also trigger on any loss of PCIe link for any reason: badly seated card, worn connector, EMI, etc. Will there be any remaining message about dead PCIe links, or just a silent disappearence? Like dev_info("USB disconnect ...") in USB. > The messages are loud, but it's mostly because the functions that > emit the messages don't check whether the device is actually alive. > The PCIe hotplug services mark the device as perm dead, so that > can be used to hide some of the messsages. > > In the XHCI driver the device is marked as dying already, so that > can also be used to hide messages. Are PCI drivers expected to stay silent on sudden removal mid operation? Is there no "safe ejection" procedure for those Thunderbolt devices? > Mario Limonciello (4): > PCI: Don't show errors on inaccessible PCI devices > PCI: Fix runtime PM usage count underflow > usb: xhci: Avoid showing errors during surprise removal > usb: xhci: Avoid showing warnings for dying controller Regards, Michal
On 6/9/2025 7:42 AM, Mathias Nyman wrote: > On 9.6.2025 4.58, Mario Limonciello wrote: >> From: Mario Limonciello <mario.limonciello@amd.com> >> >> When a USB4 dock is unplugged from a system it won't respond to ring >> events. The PCI core handles the surprise removal event and notifies >> all PCI drivers. The XHCI PCI driver sets a flag that the device is >> being removed as well. >> >> When that flag is set don't show messages in the cleanup path for >> marking the controller dead. >> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > > Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com> > Thanks for the acks Mathias! All 4 patches were sent together because of the relation but they really don't have a dependency to need to be committed together. Would you mind picking up the patches for 3 and 4 to USB tree and I'll keep discussing 1 and 2 with linux-pci M/L.
On Sun, Jun 08, 2025 at 08:58:00PM -0500, Mario Limonciello wrote: > Mario Limonciello (4): > PCI: Don't show errors on inaccessible PCI devices > PCI: Fix runtime PM usage count underflow > usb: xhci: Avoid showing errors during surprise removal > usb: xhci: Avoid showing warnings for dying controller Patches [3/4] and [4/4] (which touch xhci) were only cc'ed to Bjorn. You may want to resend these two to Mathias and Greg. You might also want to split the series in two separate ones for PCI and xhci if/when respinning. Thanks, Lukas
From: Mario Limonciello <mario.limonciello@amd.com> When a USB4 or TBT3 dock is disconnected a lot of warnings and errors are emitted related to the PCIe tunnels and XHCI controllers in th dock. The messages are loud, but it's mostly because the functions that emit the messages don't check whether the device is actually alive. The PCIe hotplug services mark the device as perm dead, so that can be used to hide some of the messsages. In the XHCI driver the device is marked as dying already, so that can also be used to hide messages. Mario Limonciello (4): PCI: Don't show errors on inaccessible PCI devices PCI: Fix runtime PM usage count underflow usb: xhci: Avoid showing errors during surprise removal usb: xhci: Avoid showing warnings for dying controller drivers/pci/pci-driver.c | 3 ++- drivers/pci/pci.c | 5 +++-- drivers/usb/host/xhci-ring.c | 7 +++++-- drivers/usb/host/xhci.c | 6 ++++-- 4 files changed, 14 insertions(+), 7 deletions(-)