| Message ID | 20250526153821.7918-1-quic_nitirawa@quicinc.com |
|---|---|
| Headers | show |
| Series | Refactor ufs phy powerup sequence | expand |
Nitin, > Patch 1 is a fix for existing issues, which doesn't have any > dependencies on any other changes. Applied patch 1 to 6.16/scsi-staging, thanks!
On 5/28/2025 7:45 AM, Martin K. Petersen wrote: > > Nitin, > >> Patch 1 is a fix for existing issues, which doesn't have any >> dependencies on any other changes. Hi Martin and Vinod, For the remaining patches (Patch 2 - Patch 10), since Patch 2 (SCSI Patch) depends on PHY patches, can these patches be merged through the PHY tree? Regards, Nitin > > Applied patch 1 to 6.16/scsi-staging, thanks! >
Nitin, > For the remaining patches (Patch 2 - Patch 10), since Patch 2 (SCSI > Patch) depends on PHY patches, can these patches be merged through the > PHY tree? Fine with me. Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
On Mon, 26 May 2025 21:08:11 +0530, Nitin Rawat wrote: > In Current code regulators enable, clks enable, calibrating UFS PHY, > start_serdes and polling PCS_ready_status are part of phy_power_on. > > UFS PHY registers are retained after power collapse, meaning calibrating > UFS PHY, start_serdes and polling PCS_ready_status can be done only when > hba is powered_on, and not needed every time when phy_power_on is called > during resume. Hence keep the code which enables PHY's regulators & clks > in phy_power_on and move the rest steps into phy_calibrate function. > > [...] Applied, thanks! [02/10] scsi: ufs: qcom: add a new phy calibrate API call commit: 399c75b6a9ed2fd609f9ad4c22cdd6364bc9d441 [03/10] phy: qcom-qmp-ufs: Rename qmp_ufs_enable and qmp_ufs_power_on commit: dbd20821946a74e803208a25dddfafe1ae2e34e6 [04/10] phy: qcom-qmp-ufs: Refactor phy_power_on and phy_calibrate callbacks commit: cbfd6c124f27ad2b4c0f617dc40ad8a08a063463 [05/10] phy: qcom-qmp-ufs: Refactor UFS PHY reset commit: d58b9ff47775042acc501d0a892af8bd08128a65 [06/10] phy: qcom-qmp-ufs: Remove qmp_ufs_com_init() commit: 7bcf4936aac6ec8d6fafbfd6f4f62302e5296a0d [07/10] phy: qcom-qmp-ufs: Rename qmp_ufs_power_off commit: acc6b0d73d902d3296d8c77878a9b508c2c6a5bf [08/10] phy: qcom-qmp-ufs: Remove qmp_ufs_exit() and Inline qmp_ufs_com_exit() commit: 7f600f0e193a6638135026c3718ac296ed3f5044 [09/10] phy: qcom-qmp-ufs: refactor qmp_ufs_power_off commit: a079b2d715340482e425ff136b55810ab8279800 [10/10] scsi: ufs: qcom : Refactor phy_power_on/off calls commit: 77d2fa54a94574f767d5fb296b6b8e011eba0c8e Best regards,
In Current code regulators enable, clks enable, calibrating UFS PHY, start_serdes and polling PCS_ready_status are part of phy_power_on. UFS PHY registers are retained after power collapse, meaning calibrating UFS PHY, start_serdes and polling PCS_ready_status can be done only when hba is powered_on, and not needed every time when phy_power_on is called during resume. Hence keep the code which enables PHY's regulators & clks in phy_power_on and move the rest steps into phy_calibrate function. Since phy_power_on is separated out from phy calibrate, make separate calls to phy_power_on and phy_calibrate calls from ufs qcom driver. Also for better power saving, remove the phy_power_on/off calls from resume/suspend path and put them to ufs_qcom_setup_clocks, so that PHY's regulators & clks can be turned on/off along with UFS's clocks. This patch series is tested on SM8550 QRD, SM8650 MTP , SM8750 MTP. Note: Patch 2 of this series is a requirement for the rest of the PHY patches(patch 3 - patch 9) for the functional dependency and Patch 1 is a fix for existing issues, which doesn't have any dependencies on any other changes. Changes in v6: 1. Addressed Konrad's and Manivannan's comments to move patch11 of v5 to start of the series so that it can be applied separately if needed. 2. Addessed manivannan's comment to improve commit text for few patch. and remove few trivial comments and minor code improvement. 3. Removed patch 10 (Introduce phy_power_on/off wrapper function) of last patchset as it is not needed. Changes in v5: 1. Addressed Dmitry's comment to inline qmp_ufs_exit into qmp_ufs_power_off 2. Addrsssed Konrad's comment to improve code identation and updating kernel doc to update the info regarding controller and phy clocks being managed together. 3. Addrsssed Konrad's comment to update commit text for patch #10 to improve explanation to maintain separate ref_count in ufs controller driver. Changes in v4: 1. Addressed Dmitry's comment to update cover letter to mention patch1 as a requirement for the rest of the PHY patches. 2. Addressed Dmitry's comment to move parsing UFS PHY reset handle logic to init from probe to avoid probe failure. 3. Addressed Dmitry's comment to update commit text to reflect reason to remove qmp_ufs_com_init() (Patch 7 of current series) 4. Addrssed Konrad's comment to return failure from power up sequence when phy_calibrate return failure and modify the debug print. Changes in v3: 1. Addresed neil and bjorn comment to align the order of the patch to maintain the bisectability compliance within the patch. 2. Addressed neil comment to move qmp_ufs_get_phy_reset() in a separate patch, inline qmp_ufs_com_init() inline. Changes in v2: 1. Addressed vinod koul and manivannan comment to split the phy patch into multiple patches. 2. Addressed vinod's comment to reuse SW_PWRDN instead of creating new macros SW_PWRUP in phy-qcom-qmp-ufs.c. 3. Addressed Konrad's comment to optimize mutex lock in ufs-qcom.c 4. Addressed konrad and Manivannan comment to clean debug print in ufs-qcom.c Nitin Rawat (10): scsi: ufs: qcom: Prevent calling phy_exit before phy_init scsi: ufs: qcom: add a new phy calibrate API call phy: qcom-qmp-ufs: Rename qmp_ufs_enable and qmp_ufs_power_on phy: qcom-qmp-ufs: Refactor phy_power_on and phy_calibrate callbacks phy: qcom-qmp-ufs: Refactor UFS PHY reset phy: qcom-qmp-ufs: Remove qmp_ufs_com_init() phy: qcom-qmp-ufs: Rename qmp_ufs_power_off phy: qcom-qmp-ufs: Remove qmp_ufs_exit() and Inline qmp_ufs_com_exit() phy: qcom-qmp-ufs: refactor qmp_ufs_power_off scsi: ufs: qcom : Refactor phy_power_on/off calls drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 141 +++++++----------------- drivers/ufs/host/ufs-qcom.c | 69 ++++++------ 2 files changed, 77 insertions(+), 133 deletions(-) -- 2.48.1