| Message ID | 20250606-s2mpg1x-regulators-v2-2-b03feffd2621@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Samsung S2MPG10 regulator and S2MPG11 PMIC drivers | expand |
On Fri, Jun 06, 2025 at 04:02:58PM GMT, André Draszik wrote: > The S2MPG10 PMIC is a Power Management IC for mobile applications with > buck converters, various LDOs, power meters, RTC, clock outputs, and > additional GPIO interfaces. > > It has 10 buck and 31 LDO rails. Several of these can either be > controlled via software or via external signals, e.g. input pins > connected to a main processor's GPIO pins. > > Add documentation related to the regulator (buck & ldo) parts like > devicetree definitions, regulator naming patterns, and additional > properties. > > S2MPG10 is typically used as the main-PMIC together with an S2MPG11 > PMIC in a main/sub configuration, hence the datasheet and the binding > both suffix the rails with an 'm'. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > v2: > - drop | (literal style mark) from samsung,ext-control-gpios > description > --- > .../regulator/samsung,s2mpg10-regulator.yaml | 147 +++++++++++++++++++++ > MAINTAINERS | 1 + > .../regulator/samsung,s2mpg10-regulator.h | 48 +++++++ > 3 files changed, 196 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..82f2b06205e9bdb15cf90b1e896fe52c335c52c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml > @@ -0,0 +1,147 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/samsung,s2mpg10-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S2MPG10 Power Management IC regulators > + > +maintainers: > + - André Draszik <andre.draszik@linaro.org> > + > +description: | > + This is part of the device tree bindings for the S2MG10 Power Management IC > + (PMIC). > + > + The S2MPG10 PMIC provides 10 buck and 31 LDO regulators. > + > + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for > + additional information and example. > + > +definitions: > + s2mpg10-ext-control: > + properties: > + samsung,ext-control: > + description: | > + These rails can be controlled via one of several possible external > + (hardware) signals. If so, this property configures the signal the PMIC > + should monitor. For S2MPG10 rails where external control is possible other > + than ldo20m, the following values generally corresponding to the > + respective on-chip pin are valid: > + - 0 # S2MPG10_PCTRLSEL_ON - always on > + - 1 # S2MPG10_PCTRLSEL_PWREN - PWREN pin > + - 2 # S2MPG10_PCTRLSEL_PWREN_TRG - PWREN_TRG bit in MIMICKING_CTRL > + - 3 # S2MPG10_PCTRLSEL_PWREN_MIF - PWREN_MIF pin > + - 4 # S2MPG10_PCTRLSEL_PWREN_MIF_TRG - PWREN_MIF_TRG bit in MIMICKING_CTRL > + - 5 # S2MPG10_PCTRLSEL_AP_ACTIVE_N - ~AP_ACTIVE_N pin > + - 6 # S2MPG10_PCTRLSEL_AP_ACTIVE_N_TRG - ~AP_ACTIVE_N_TRG bit in MIMICKING_CTRL > + - 7 # S2MPG10_PCTRLSEL_CPUCL1_EN - CPUCL1_EN pin > + - 8 # S2MPG10_PCTRLSEL_CPUCL1_EN2 - CPUCL1_EN & PWREN pins > + - 9 # S2MPG10_PCTRLSEL_CPUCL2_EN - CPUCL2_EN pin > + - 10 # S2MPG10_PCTRLSEL_CPUCL2_EN2 - CPUCL2_E2 & PWREN pins > + - 11 # S2MPG10_PCTRLSEL_TPU_EN - TPU_EN pin > + - 12 # S2MPG10_PCTRLSEL_TPU_EN2 - TPU_EN & ~AP_ACTIVE_N pins > + - 13 # S2MPG10_PCTRLSEL_TCXO_ON - TCXO_ON pin > + - 14 # S2MPG10_PCTRLSEL_TCXO_ON2 - TCXO_ON & ~AP_ACTIVE_N pins > + > + For S2MPG10 ldo20m, the following values are valid > + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on No, use standard regulator properties - regulator-always-on > + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR > + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin > + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register > + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable I don't think we allowed such property in the past. I don't get what is here the actual signal - you described registers in multiple places, not signals. Few of these duplicate standard properties, so this looks like exact copy of downstream which was doing exactly that way and that was exactly never upstreamed. > + > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 14 > + > + samsung,ext-control-gpios: enable-gpios > + description: > + For rails where external control is done via a GPIO, this optional > + property describes the GPIO line used. > + > + maxItems: 1 And this can be dropped. Best regards, Krzysztof
Hi Krzysztof, Thanks for your review! On Wed, 2025-06-11 at 10:55 +0200, Krzysztof Kozlowski wrote: > On Fri, Jun 06, 2025 at 04:02:58PM GMT, André Draszik wrote: > > The S2MPG10 PMIC is a Power Management IC for mobile applications with > > buck converters, various LDOs, power meters, RTC, clock outputs, and > > additional GPIO interfaces. > > > > It has 10 buck and 31 LDO rails. Several of these can either be > > controlled via software or via external signals, e.g. input pins > > connected to a main processor's GPIO pins. > > > > Add documentation related to the regulator (buck & ldo) parts like > > devicetree definitions, regulator naming patterns, and additional > > properties. > > > > S2MPG10 is typically used as the main-PMIC together with an S2MPG11 > > PMIC in a main/sub configuration, hence the datasheet and the binding > > both suffix the rails with an 'm'. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > --- > > v2: > > - drop | (literal style mark) from samsung,ext-control-gpios > > description > > --- > > .../regulator/samsung,s2mpg10-regulator.yaml | 147 +++++++++++++++++++++ > > MAINTAINERS | 1 + > > .../regulator/samsung,s2mpg10-regulator.h | 48 +++++++ > > 3 files changed, 196 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml > > b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml > > new file mode 100644 > > index 0000000000000000000000000000000000000000..82f2b06205e9bdb15cf90b1e896fe52c335c52c4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml > > @@ -0,0 +1,147 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/samsung,s2mpg10-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S2MPG10 Power Management IC regulators > > + > > +maintainers: > > + - André Draszik <andre.draszik@linaro.org> > > + > > +description: | > > + This is part of the device tree bindings for the S2MG10 Power Management IC > > + (PMIC). > > + > > + The S2MPG10 PMIC provides 10 buck and 31 LDO regulators. > > + > > + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for > > + additional information and example. > > + > > +definitions: > > + s2mpg10-ext-control: > > + properties: > > + samsung,ext-control: > > + description: | > > + These rails can be controlled via one of several possible external > > + (hardware) signals. If so, this property configures the signal the PMIC > > + should monitor. For S2MPG10 rails where external control is possible other > > + than ldo20m, the following values generally corresponding to the > > + respective on-chip pin are valid: > > + - 0 # S2MPG10_PCTRLSEL_ON - always on > > + - 1 # S2MPG10_PCTRLSEL_PWREN - PWREN pin > > + - 2 # S2MPG10_PCTRLSEL_PWREN_TRG - PWREN_TRG bit in MIMICKING_CTRL > > + - 3 # S2MPG10_PCTRLSEL_PWREN_MIF - PWREN_MIF pin > > + - 4 # S2MPG10_PCTRLSEL_PWREN_MIF_TRG - PWREN_MIF_TRG bit in MIMICKING_CTRL > > + - 5 # S2MPG10_PCTRLSEL_AP_ACTIVE_N - ~AP_ACTIVE_N pin > > + - 6 # S2MPG10_PCTRLSEL_AP_ACTIVE_N_TRG - ~AP_ACTIVE_N_TRG bit in MIMICKING_CTRL > > + - 7 # S2MPG10_PCTRLSEL_CPUCL1_EN - CPUCL1_EN pin > > + - 8 # S2MPG10_PCTRLSEL_CPUCL1_EN2 - CPUCL1_EN & PWREN pins > > + - 9 # S2MPG10_PCTRLSEL_CPUCL2_EN - CPUCL2_EN pin > > + - 10 # S2MPG10_PCTRLSEL_CPUCL2_EN2 - CPUCL2_E2 & PWREN pins > > + - 11 # S2MPG10_PCTRLSEL_TPU_EN - TPU_EN pin > > + - 12 # S2MPG10_PCTRLSEL_TPU_EN2 - TPU_EN & ~AP_ACTIVE_N pins > > + - 13 # S2MPG10_PCTRLSEL_TCXO_ON - TCXO_ON pin > > + - 14 # S2MPG10_PCTRLSEL_TCXO_ON2 - TCXO_ON & ~AP_ACTIVE_N pins > > + > > + For S2MPG10 ldo20m, the following values are valid > > + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on > > No, use standard regulator properties - regulator-always-on Same reason as in patch 3. I'll update this one. > > > + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR > > + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin > > + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register > > + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable > > I don't think we allowed such property in the past. I don't get what is > here the actual signal - you described registers in multiple places, not > signals. Few of these duplicate standard properties, so this looks like > exact copy of downstream which was doing exactly that way and that was > exactly never upstreamed. For lack of a better word, I used the generic term 'signal' in the descriptions to refer to either a pin (VLDO20M_EN in this case), or a PMIC-internal register bit (LDO20M_SFR in this case), or a combination, they're all signals to the internal PMIC logic. That's what the property description above is trying to convey. The 'samsung,ext-control' property itself is required to configure the PMIC so that it knows which of the signals (e.g. which input pin) should affect a certain rail. In effect, this allows controlling more than one rail atomically, while being flexible in the board design wrt. which rail is affected by which pin. This is not a copy of downstream, and the ones that in effect duplicate standard properties like 'always on' I simply added for completeness, to fully describe the hardware. I'll leave them out in the next revision to avoid possible abuse. > > > + > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 14 > > + > > + samsung,ext-control-gpios: > > enable-gpios OK. > > > > + description: > > + For rails where external control is done via a GPIO, this optional > > + property describes the GPIO line used. > > + > > + maxItems: 1 > > And this can be dropped. OK. Cheers, Andre'
On Wed, Jun 11, 2025 at 10:55:44AM +0200, Krzysztof Kozlowski wrote: > On Fri, Jun 06, 2025 at 04:02:58PM GMT, André Draszik wrote: > > + For S2MPG10 ldo20m, the following values are valid > > + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on > No, use standard regulator properties - regulator-always-on > > + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR > > + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin > > + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register > > + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable > I don't think we allowed such property in the past. I don't get what is > here the actual signal - you described registers in multiple places, not > signals. Few of these duplicate standard properties, so this looks like > exact copy of downstream which was doing exactly that way and that was > exactly never upstreamed. It looks like we can infer the configuration needed here from the existing properties, if a GPIO is provided then use value 2 otherwise use value 3.
Hi Mark, On Wed, 2025-06-11 at 14:53 +0100, Mark Brown wrote: > On Wed, Jun 11, 2025 at 10:55:44AM +0200, Krzysztof Kozlowski wrote: > > On Fri, Jun 06, 2025 at 04:02:58PM GMT, André Draszik wrote: > > > > + For S2MPG10 ldo20m, the following values are valid > > > + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on > > > No, use standard regulator properties - regulator-always-on > > > > + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR > > > + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin > > > + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register > > > + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable > > > I don't think we allowed such property in the past. I don't get what is > > here the actual signal - you described registers in multiple places, not > > signals. Few of these duplicate standard properties, so this looks like > > exact copy of downstream which was doing exactly that way and that was > > exactly never upstreamed. > > It looks like we can infer the configuration needed here from the > existing properties, For this ldo20, yes, and I'll update binding+driver to do so. > if a GPIO is provided then use value 2 otherwise > use value 3. Close :-) There is another register to say if this pctrlsel should be respected in the first place. Therefore if a GPIO is provided, then use value 2 for pctrlsel, otherwise the value doesn't matter, as pctrlsel will be ignored anyway. But doesn't really matter in the context of this discussion here, just for future reference :-) Thanks for your review! Thanks! Andre'
diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml new file mode 100644 index 0000000000000000000000000000000000000000..82f2b06205e9bdb15cf90b1e896fe52c335c52c4 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpg10-regulator.yaml @@ -0,0 +1,147 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/samsung,s2mpg10-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S2MPG10 Power Management IC regulators + +maintainers: + - André Draszik <andre.draszik@linaro.org> + +description: | + This is part of the device tree bindings for the S2MG10 Power Management IC + (PMIC). + + The S2MPG10 PMIC provides 10 buck and 31 LDO regulators. + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +definitions: + s2mpg10-ext-control: + properties: + samsung,ext-control: + description: | + These rails can be controlled via one of several possible external + (hardware) signals. If so, this property configures the signal the PMIC + should monitor. For S2MPG10 rails where external control is possible other + than ldo20m, the following values generally corresponding to the + respective on-chip pin are valid: + - 0 # S2MPG10_PCTRLSEL_ON - always on + - 1 # S2MPG10_PCTRLSEL_PWREN - PWREN pin + - 2 # S2MPG10_PCTRLSEL_PWREN_TRG - PWREN_TRG bit in MIMICKING_CTRL + - 3 # S2MPG10_PCTRLSEL_PWREN_MIF - PWREN_MIF pin + - 4 # S2MPG10_PCTRLSEL_PWREN_MIF_TRG - PWREN_MIF_TRG bit in MIMICKING_CTRL + - 5 # S2MPG10_PCTRLSEL_AP_ACTIVE_N - ~AP_ACTIVE_N pin + - 6 # S2MPG10_PCTRLSEL_AP_ACTIVE_N_TRG - ~AP_ACTIVE_N_TRG bit in MIMICKING_CTRL + - 7 # S2MPG10_PCTRLSEL_CPUCL1_EN - CPUCL1_EN pin + - 8 # S2MPG10_PCTRLSEL_CPUCL1_EN2 - CPUCL1_EN & PWREN pins + - 9 # S2MPG10_PCTRLSEL_CPUCL2_EN - CPUCL2_EN pin + - 10 # S2MPG10_PCTRLSEL_CPUCL2_EN2 - CPUCL2_E2 & PWREN pins + - 11 # S2MPG10_PCTRLSEL_TPU_EN - TPU_EN pin + - 12 # S2MPG10_PCTRLSEL_TPU_EN2 - TPU_EN & ~AP_ACTIVE_N pins + - 13 # S2MPG10_PCTRLSEL_TCXO_ON - TCXO_ON pin + - 14 # S2MPG10_PCTRLSEL_TCXO_ON2 - TCXO_ON & ~AP_ACTIVE_N pins + + For S2MPG10 ldo20m, the following values are valid + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable + + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 14 + + samsung,ext-control-gpios: + description: + For rails where external control is done via a GPIO, this optional + property describes the GPIO line used. + + maxItems: 1 + + dependentRequired: + samsung,ext-control-gpios: [ "samsung,ext-control" ] + +patternProperties: + # 10 bucks + "^buck([1-9]|10)m$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for a single buck regulator. + + properties: + regulator-ramp-delay: + enum: [6250, 12500, 25000] + default: 6250 + + allOf: + - $ref: "#/definitions/s2mpg10-ext-control" + + # 13 standard LDOs + "^ldo([12]|2[1-9]|3[0-1])m$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for single LDO regulator. + + properties: + regulator-ramp-delay: false + + # 14 LDOs with possible external control + "^ldo([3-9]|1[046-9]|20)m$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for a single LDO regulator. + + properties: + regulator-ramp-delay: false + + allOf: + - $ref: "#/definitions/s2mpg10-ext-control" + + # 4 LDOs with ramp support and possible external control + "^ldo1[1235]m$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for a single LDO regulator. + + properties: + regulator-ramp-delay: + enum: [6250, 12500] + default: 6250 + + allOf: + - $ref: "#/definitions/s2mpg10-ext-control" + +additionalProperties: false + +allOf: + - if: + anyOf: + - required: [buck8m] + - required: [buck9m] + then: + patternProperties: + "^buck[8-9]m$": + properties: + samsung,ext-control: false + + - if: + required: + - ldo20m + then: + properties: + ldo20m: + properties: + samsung,ext-control: + maximum: 4 diff --git a/MAINTAINERS b/MAINTAINERS index 1615a93528bdfffa421eb8cad259fecd1488fc51..3fc6bd0dd15a504c498e56d425731b5234dce63a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22006,6 +22006,7 @@ F: drivers/mfd/sec*.[ch] F: drivers/regulator/s2m*.c F: drivers/regulator/s5m*.c F: drivers/rtc/rtc-s5m.c +F: include/dt-bindings/regulator/samsung,s2m*.h F: include/linux/mfd/samsung/ SAMSUNG S3C24XX/S3C64XX SOC SERIES CAMIF DRIVER diff --git a/include/dt-bindings/regulator/samsung,s2mpg10-regulator.h b/include/dt-bindings/regulator/samsung,s2mpg10-regulator.h new file mode 100644 index 0000000000000000000000000000000000000000..1d4e34a756efa46afeb9f018c3e8644ebc373b07 --- /dev/null +++ b/include/dt-bindings/regulator/samsung,s2mpg10-regulator.h @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright 2021 Google LLC + * Copyright 2025 Linaro Ltd. + * + * Device Tree binding constants for the Samsung S2MPG1x PMIC regulators + */ + +#ifndef _DT_BINDINGS_REGULATOR_SAMSUNG_S2MPG10_H +#define _DT_BINDINGS_REGULATOR_SAMSUNG_S2MPG10_H + +/* + * Several regulators may be controlled via external signals instead of via + * software. These constants describe the possible signals for such regulators + * and generally correspond to the respecitve on-chip pins. The constants + * suffixed with _TRG enable control using the respective bits in the + * MIMICKING_CTRL register instead. + * + * S2MPG10 regulators supporting these are: + * - buck1m .. buck7m buck10m + * - ldo3m .. ldo19m + * + * ldo20m supports external control, but using a different set of control + * signals. + */ +#define S2MPG10_PCTRLSEL_ON 0x0 /* always on */ +#define S2MPG10_PCTRLSEL_PWREN 0x1 /* PWREN pin */ +#define S2MPG10_PCTRLSEL_PWREN_TRG 0x2 /* PWREN_TRG bit in MIMICKING_CTRL */ +#define S2MPG10_PCTRLSEL_PWREN_MIF 0x3 /* PWREN_MIF pin */ +#define S2MPG10_PCTRLSEL_PWREN_MIF_TRG 0x4 /* PWREN_MIF_TRG bit in MIMICKING_CTRL */ +#define S2MPG10_PCTRLSEL_AP_ACTIVE_N 0x5 /* ~AP_ACTIVE_N pin */ +#define S2MPG10_PCTRLSEL_AP_ACTIVE_N_TRG 0x6 /* ~AP_ACTIVE_N_TRG bit in MIMICKING_CTRL */ +#define S2MPG10_PCTRLSEL_CPUCL1_EN 0x7 /* CPUCL1_EN pin */ +#define S2MPG10_PCTRLSEL_CPUCL1_EN2 0x8 /* CPUCL1_EN & PWREN pins */ +#define S2MPG10_PCTRLSEL_CPUCL2_EN 0x9 /* CPUCL2_EN pin */ +#define S2MPG10_PCTRLSEL_CPUCL2_EN2 0xa /* CPUCL2_E2 & PWREN pins */ +#define S2MPG10_PCTRLSEL_TPU_EN 0xb /* TPU_EN pin */ +#define S2MPG10_PCTRLSEL_TPU_EN2 0xc /* TPU_EN & ~AP_ACTIVE_N pins */ +#define S2MPG10_PCTRLSEL_TCXO_ON 0xd /* TCXO_ON pin */ +#define S2MPG10_PCTRLSEL_TCXO_ON2 0xe /* TCXO_ON & ~AP_ACTIVE_N pins */ + +#define S2MPG10_PCTRLSEL_LDO20M_ON 0x0 /* always on */ +#define S2MPG10_PCTRLSEL_LDO20M_EN_SFR 0x1 /* LDO20M_EN & LDO20M_SFR */ +#define S2MPG10_PCTRLSEL_LDO20M_EN 0x2 /* VLDO20M_EN pin */ +#define S2MPG10_PCTRLSEL_LDO20M_SFR 0x3 /* LDO20M_SFR bit in LDO_CTRL1 register */ +#define S2MPG10_PCTRLSEL_LDO20M_OFF 0x4 /* disable */ + +#endif /* _DT_BINDINGS_REGULATOR_SAMSUNG_S2MPG10_H */
The S2MPG10 PMIC is a Power Management IC for mobile applications with buck converters, various LDOs, power meters, RTC, clock outputs, and additional GPIO interfaces. It has 10 buck and 31 LDO rails. Several of these can either be controlled via software or via external signals, e.g. input pins connected to a main processor's GPIO pins. Add documentation related to the regulator (buck & ldo) parts like devicetree definitions, regulator naming patterns, and additional properties. S2MPG10 is typically used as the main-PMIC together with an S2MPG11 PMIC in a main/sub configuration, hence the datasheet and the binding both suffix the rails with an 'm'. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v2: - drop | (literal style mark) from samsung,ext-control-gpios description --- .../regulator/samsung,s2mpg10-regulator.yaml | 147 +++++++++++++++++++++ MAINTAINERS | 1 + .../regulator/samsung,s2mpg10-regulator.h | 48 +++++++ 3 files changed, 196 insertions(+)