| Message ID | 20250613100255.2131800-1-joy.zou@nxp.com |
|---|---|
| Headers | show |
| Series | Add i.MX91 platform support | expand |
On Fri, Jun 13, 2025 at 06:02:47PM +0800, Joy Zou wrote: > From: Pengfei Li <pengfei.li_1@nxp.com> > > Add the board imx91-11x11-evk in the binding docuemnt. nit: document > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > Signed-off-by: Joy Zou <joy.zou@nxp.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> ...
> -----Original Message----- > From: Simon Horman <horms@kernel.org> > Sent: 2025年6月15日 1:17 > To: Joy Zou <joy.zou@nxp.com> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; catalin.marinas@arm.com; > will@kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; > ulf.hansson@linaro.org; richardcochran@gmail.com; kernel@pengutronix.de; > festevam@gmail.com; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; > linux-stm32@st-md-mailman.stormreply.com; linux-pm@vger.kernel.org; > Frank Li <frank.li@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai > <ping.bai@nxp.com>; Peng Fan <peng.fan@nxp.com>; Aisheng Dong > <aisheng.dong@nxp.com>; Clark Wang <xiaoning.wang@nxp.com> > Subject: Re: [PATCH v5 1/9] dt-bindings: arm: fsl: add i.MX91 11x11 evk > board > > On Fri, Jun 13, 2025 at 06:02:47PM +0800, Joy Zou wrote: > > From: Pengfei Li <pengfei.li_1@nxp.com> > > > > Add the board imx91-11x11-evk in the binding docuemnt. > > nit: document Thanks for your comments! Will correct it! Will use codespell check the patchset. BR Joy Zou > > > > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > ...
On Mon, Jun 16, 2025 at 07:42:39AM +0000, Joy Zou wrote: > > > -----Original Message----- > > From: Simon Horman <horms@kernel.org> > > Sent: 2025年6月15日 1:17 > > To: Joy Zou <joy.zou@nxp.com> > > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > > shawnguo@kernel.org; s.hauer@pengutronix.de; catalin.marinas@arm.com; > > will@kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net; > > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > > mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; > > ulf.hansson@linaro.org; richardcochran@gmail.com; kernel@pengutronix.de; > > festevam@gmail.com; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; imx@lists.linux.dev; > > linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; > > linux-stm32@st-md-mailman.stormreply.com; linux-pm@vger.kernel.org; > > Frank Li <frank.li@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai > > <ping.bai@nxp.com>; Peng Fan <peng.fan@nxp.com>; Aisheng Dong > > <aisheng.dong@nxp.com>; Clark Wang <xiaoning.wang@nxp.com> > > Subject: Re: [PATCH v5 1/9] dt-bindings: arm: fsl: add i.MX91 11x11 evk > > board > > > > On Fri, Jun 13, 2025 at 06:02:47PM +0800, Joy Zou wrote: > > > From: Pengfei Li <pengfei.li_1@nxp.com> > > > > > > Add the board imx91-11x11-evk in the binding docuemnt. > > > > nit: document > Thanks for your comments! > Will correct it! > Will use codespell check the patchset. Good plan. The --codespell option to checkpatch should work well here. ...
On Fri, 13 Jun 2025 18:02:46 +0800, Joy Zou wrote: > The design of i.MX91 platform is very similar to i.MX93. > Extracts the common parts in order to reuse code. > > The mainly difference between i.MX91 and i.MX93 is as follows: > - i.MX91 removed some clocks and modified the names of some clocks. > - i.MX91 only has one A core. > - i.MX91 has different pinmux. > - i.MX91 has updated to new temperature sensor same with i.MX95. > > --- > Changes for v5: > - rename imx93.dtsi to imx91_93_common.dtsi. > - move imx93 specific part from imx91_93_common.dtsi to imx93.dtsi. > - modify the imx91.dtsi to use imx91_93_common.dtsi. > - add new the imx93-blk-ctrl binding and driver patch for imx91 support. > - add new net patch for imx91 support. > - change node name codec and lsm6dsm into common name audio-codec and > inertial-meter, and add BT compatible string for imx91 board dts. > > Changes for v4: > - Add one imx93 patch that add labels in imx93.dtsi > - modify the references in imx91.dtsi > - modify the code alignment > - remove unused newline > - delete the status property > - align pad hex values > > Changes for v3: > - Add Conor's ack on patch #1 > - format imx91-11x11-evk.dts with the dt-format tool > - add lpi2c1 node > > Changes for v2: > - change ddr node pmu comaptible > - remove mu1 and mu2 > - change iomux node compatible and enable 91 pinctrl > - refine commit message for patch #2 > - change hex to lowercase in pinfunc.h > - ordering nodes with the dt-format tool > > Joy Zou (8): > dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible > arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi > arm64: dts: imx93: move i.MX93 specific part from imx91_93_common.dtsi > to imx93.dtsi > arm64: dts: imx91: add i.MX91 dtsi support > arm64: dts: freescale: add i.MX91 11x11 EVK basic support > arm64: defconfig: enable i.MX91 pinctrl > pmdomain: imx93-blk-ctrl: mask DSI and PXP PD domain register on > i.MX91 > net: stmmac: imx: add i.MX91 support > > Pengfei Li (1): > dt-bindings: arm: fsl: add i.MX91 11x11 evk board > > .../devicetree/bindings/arm/fsl.yaml | 6 + > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../boot/dts/freescale/imx91-11x11-evk.dts | 878 ++++++++++ > arch/arm64/boot/dts/freescale/imx91-pinfunc.h | 770 +++++++++ > arch/arm64/boot/dts/freescale/imx91.dtsi | 124 ++ > .../boot/dts/freescale/imx91_93_common.dtsi | 1215 ++++++++++++++ > arch/arm64/boot/dts/freescale/imx93.dtsi | 1412 ++--------------- > arch/arm64/configs/defconfig | 1 + > .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 + > drivers/pmdomain/imx/imx93-blk-ctrl.c | 15 + > 11 files changed, 3166 insertions(+), 1313 deletions(-) > create mode 100644 arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx91-pinfunc.h > create mode 100644 arch/arm64/boot/dts/freescale/imx91.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > > -- > 2.37.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: attempting to guess base-commit... Base: tags/v6.16-rc1-6-g8a22d9e79cf0 (best guess, 6/7 blobs matched) If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20250613100255.2131800-1-joy.zou@nxp.com: arch/arm64/boot/dts/freescale/imx91-11x11-evk.dtb: /soc@0/bus@44000000/thermal-sensor@44482000: failed to match any schema with compatible: ['fsl,imx91-tmu']
> -----Original Message----- > > On Fri, 13 Jun 2025 18:02:46 +0800, Joy Zou wrote: > > The design of i.MX91 platform is very similar to i.MX93. > > Extracts the common parts in order to reuse code. > > > > The mainly difference between i.MX91 and i.MX93 is as follows: > > - i.MX91 removed some clocks and modified the names of some clocks. > > - i.MX91 only has one A core. > > - i.MX91 has different pinmux. > > - i.MX91 has updated to new temperature sensor same with i.MX95. > > > > Joy Zou (8): > > dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible > > arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi > > arm64: dts: imx93: move i.MX93 specific part from > imx91_93_common.dtsi > > to imx93.dtsi > > arm64: dts: imx91: add i.MX91 dtsi support > > arm64: dts: freescale: add i.MX91 11x11 EVK basic support > > arm64: defconfig: enable i.MX91 pinctrl > > pmdomain: imx93-blk-ctrl: mask DSI and PXP PD domain register on > > i.MX91 > > net: stmmac: imx: add i.MX91 support > > > > Pengfei Li (1): > > dt-bindings: arm: fsl: add i.MX91 11x11 evk board > > > > .../devicetree/bindings/arm/fsl.yaml | 6 + > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../boot/dts/freescale/imx91-11x11-evk.dts | 878 ++++++++++ > > arch/arm64/boot/dts/freescale/imx91-pinfunc.h | 770 +++++++++ > > arch/arm64/boot/dts/freescale/imx91.dtsi | 124 ++ > > .../boot/dts/freescale/imx91_93_common.dtsi | 1215 ++++++++++++++ > > arch/arm64/boot/dts/freescale/imx93.dtsi | 1412 ++--------------- > > arch/arm64/configs/defconfig | 1 + > > .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 + > > drivers/pmdomain/imx/imx93-blk-ctrl.c | 15 + > > 11 files changed, 3166 insertions(+), 1313 deletions(-) create mode > > 100644 arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx91-pinfunc.h > > create mode 100644 arch/arm64/boot/dts/freescale/imx91.dtsi > > create mode 100644 > arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > > > > -- > > 2.37.1 > > > My bot found new DTB warnings on the .dts files added or changed in this > series. Thanks for your reminder! Have run DT checks and found this warning. The temperature bindings and driver patch v6 is reviewing. So add note to the " [PATCH v5 5/9] arm64: dts: imx91: add i.MX91 dtsi support" patch. Refer to the link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250407-imx91tmu-v6-0-e48c2aa3ae44@nxp.com/ BR Joy Zou > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are > fixed by another series. Ultimately, it is up to the platform maintainer whether > these warnings are acceptable or not. No need to reply unless the platform > maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then make sure > dt-schema is up to date: > > pip3 install dtschema --upgrade > > > This patch series was applied (using b4) to base: > Base: attempting to guess base-commit... > Base: tags/v6.16-rc1-6-g8a22d9e79cf0 (best guess, 6/7 blobs matched) > > If this is not the correct base, please add 'base-commit' tag (or use b4 which > does this automatically) > > New warnings running 'make CHECK_DTBS=y for > arch/arm64/boot/dts/freescale/' for > 20250613100255.2131800-1-joy.zou@nxp.com: > > arch/arm64/boot/dts/freescale/imx91-11x11-evk.dtb: > /soc@0/bus@44000000/thermal-sensor@44482000: failed to match any > schema with compatible: ['fsl,imx91-tmu'] > > > >
On Tue, Jun 17, 2025 at 08:09:10AM +0000, Joy Zou wrote: > > > -----Original Message----- > > > > On Fri, 13 Jun 2025 18:02:46 +0800, Joy Zou wrote: > > > The design of i.MX91 platform is very similar to i.MX93. > > > Extracts the common parts in order to reuse code. > > > > > > The mainly difference between i.MX91 and i.MX93 is as follows: > > > - i.MX91 removed some clocks and modified the names of some clocks. > > > - i.MX91 only has one A core. > > > - i.MX91 has different pinmux. > > > - i.MX91 has updated to new temperature sensor same with i.MX95. > > > > > > Joy Zou (8): > > > dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible > > > arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi > > > arm64: dts: imx93: move i.MX93 specific part from > > imx91_93_common.dtsi > > > to imx93.dtsi > > > arm64: dts: imx91: add i.MX91 dtsi support > > > arm64: dts: freescale: add i.MX91 11x11 EVK basic support > > > arm64: defconfig: enable i.MX91 pinctrl > > > pmdomain: imx93-blk-ctrl: mask DSI and PXP PD domain register on > > > i.MX91 > > > net: stmmac: imx: add i.MX91 support > > > > > > Pengfei Li (1): > > > dt-bindings: arm: fsl: add i.MX91 11x11 evk board > > > > > > .../devicetree/bindings/arm/fsl.yaml | 6 + > > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +- > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../boot/dts/freescale/imx91-11x11-evk.dts | 878 ++++++++++ > > > arch/arm64/boot/dts/freescale/imx91-pinfunc.h | 770 +++++++++ > > > arch/arm64/boot/dts/freescale/imx91.dtsi | 124 ++ > > > .../boot/dts/freescale/imx91_93_common.dtsi | 1215 ++++++++++++++ > > > arch/arm64/boot/dts/freescale/imx93.dtsi | 1412 ++--------------- > > > arch/arm64/configs/defconfig | 1 + > > > .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 + > > > drivers/pmdomain/imx/imx93-blk-ctrl.c | 15 + > > > 11 files changed, 3166 insertions(+), 1313 deletions(-) create mode > > > 100644 arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts > > > create mode 100644 arch/arm64/boot/dts/freescale/imx91-pinfunc.h > > > create mode 100644 arch/arm64/boot/dts/freescale/imx91.dtsi > > > create mode 100644 > > arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > > > > > > -- > > > 2.37.1 > > > > > My bot found new DTB warnings on the .dts files added or changed in this > > series. > Thanks for your reminder! > Have run DT checks and found this warning. The temperature bindings and driver patch v6 is reviewing. > So add note to the " [PATCH v5 5/9] arm64: dts: imx91: add i.MX91 dtsi support" patch. > Refer to the link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250407-imx91tmu-v6-0-e48c2aa3ae44@nxp.com/ > BR tmu is not critial part, we can add after 91tmu binding merged. Frank > Joy Zou > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are > > fixed by another series. Ultimately, it is up to the platform maintainer whether > > these warnings are acceptable or not. No need to reply unless the platform > > maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then make sure > > dt-schema is up to date: > > > > pip3 install dtschema --upgrade > > > > > > This patch series was applied (using b4) to base: > > Base: attempting to guess base-commit... > > Base: tags/v6.16-rc1-6-g8a22d9e79cf0 (best guess, 6/7 blobs matched) > > > > If this is not the correct base, please add 'base-commit' tag (or use b4 which > > does this automatically) > > > > New warnings running 'make CHECK_DTBS=y for > > arch/arm64/boot/dts/freescale/' for > > 20250613100255.2131800-1-joy.zou@nxp.com: > > > > arch/arm64/boot/dts/freescale/imx91-11x11-evk.dtb: > > /soc@0/bus@44000000/thermal-sensor@44482000: failed to match any > > schema with compatible: ['fsl,imx91-tmu'] > > > > > > > > >
The design of i.MX91 platform is very similar to i.MX93. Extracts the common parts in order to reuse code. The mainly difference between i.MX91 and i.MX93 is as follows: - i.MX91 removed some clocks and modified the names of some clocks. - i.MX91 only has one A core. - i.MX91 has different pinmux. - i.MX91 has updated to new temperature sensor same with i.MX95. --- Changes for v5: - rename imx93.dtsi to imx91_93_common.dtsi. - move imx93 specific part from imx91_93_common.dtsi to imx93.dtsi. - modify the imx91.dtsi to use imx91_93_common.dtsi. - add new the imx93-blk-ctrl binding and driver patch for imx91 support. - add new net patch for imx91 support. - change node name codec and lsm6dsm into common name audio-codec and inertial-meter, and add BT compatible string for imx91 board dts. Changes for v4: - Add one imx93 patch that add labels in imx93.dtsi - modify the references in imx91.dtsi - modify the code alignment - remove unused newline - delete the status property - align pad hex values Changes for v3: - Add Conor's ack on patch #1 - format imx91-11x11-evk.dts with the dt-format tool - add lpi2c1 node Changes for v2: - change ddr node pmu comaptible - remove mu1 and mu2 - change iomux node compatible and enable 91 pinctrl - refine commit message for patch #2 - change hex to lowercase in pinfunc.h - ordering nodes with the dt-format tool Joy Zou (8): dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi arm64: dts: imx93: move i.MX93 specific part from imx91_93_common.dtsi to imx93.dtsi arm64: dts: imx91: add i.MX91 dtsi support arm64: dts: freescale: add i.MX91 11x11 EVK basic support arm64: defconfig: enable i.MX91 pinctrl pmdomain: imx93-blk-ctrl: mask DSI and PXP PD domain register on i.MX91 net: stmmac: imx: add i.MX91 support Pengfei Li (1): dt-bindings: arm: fsl: add i.MX91 11x11 evk board .../devicetree/bindings/arm/fsl.yaml | 6 + .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +- arch/arm64/boot/dts/freescale/Makefile | 1 + .../boot/dts/freescale/imx91-11x11-evk.dts | 878 ++++++++++ arch/arm64/boot/dts/freescale/imx91-pinfunc.h | 770 +++++++++ arch/arm64/boot/dts/freescale/imx91.dtsi | 124 ++ .../boot/dts/freescale/imx91_93_common.dtsi | 1215 ++++++++++++++ arch/arm64/boot/dts/freescale/imx93.dtsi | 1412 ++--------------- arch/arm64/configs/defconfig | 1 + .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 + drivers/pmdomain/imx/imx93-blk-ctrl.c | 15 + 11 files changed, 3166 insertions(+), 1313 deletions(-) create mode 100644 arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts create mode 100644 arch/arm64/boot/dts/freescale/imx91-pinfunc.h create mode 100644 arch/arm64/boot/dts/freescale/imx91.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx91_93_common.dtsi