[0/4] drm/tilcdc: Add DRM panel support and use it for am335x-evm

Message ID cover.1519318304.git.jsarha@ti.com
Headers show
Series
  • drm/tilcdc: Add DRM panel support and use it for am335x-evm
Related show

Message

Jyri Sarha Feb. 22, 2018, 5:07 p.m.
The first patch adds support for drm panels to tilcdc. The second is
just for convenience. The third adds support for am335x-evm's panel to
panel-simple driver. The third changes am335x-evm's dts file to use
panel-simple instead of tilcdc's bundled dpi-panel support.

After the review I will pick the tilcdc patches, but how about the
panel-simple, who will take it?

There is no hurry with the dts patch. We can even wait with it until the
next release, when everything certainly ready for it. The evm works just
fine with the old tilcdc bundled panel support and we probably have to
keep it around indefinately for backward compatibility.

Best regards,
Jyri

Jyri Sarha (4):
  drm/tilcdc: Add support for drm panels
  drm/tilcdc: tilcdc_panel: Rename device from "panel" to "tilcdc-panel"
  drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
  ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel

 arch/arm/boot/dts/am335x-evm.dts         | 44 +++++++++++++-------------------
 drivers/gpu/drm/panel/panel-simple.c     | 26 +++++++++++++++++++
 drivers/gpu/drm/tilcdc/Kconfig           |  2 ++
 drivers/gpu/drm/tilcdc/tilcdc_external.c | 29 ++++++++++++++-------
 drivers/gpu/drm/tilcdc/tilcdc_panel.c    |  2 +-
 5 files changed, 67 insertions(+), 36 deletions(-)

Comments

Tomi Valkeinen Feb. 26, 2018, 9:59 a.m. | #1
On 22/02/18 19:07, Jyri Sarha wrote:
> The first patch adds support for drm panels to tilcdc. The second is
> just for convenience. The third adds support for am335x-evm's panel to
> panel-simple driver. The third changes am335x-evm's dts file to use
> panel-simple instead of tilcdc's bundled dpi-panel support.
> 
> After the review I will pick the tilcdc patches, but how about the
> panel-simple, who will take it?
> 
> There is no hurry with the dts patch. We can even wait with it until the
> next release, when everything certainly ready for it. The evm works just
> fine with the old tilcdc bundled panel support and we probably have to
> keep it around indefinately for backward compatibility.
> 
> Best regards,
> Jyri
> 
> Jyri Sarha (4):
>   drm/tilcdc: Add support for drm panels
>   drm/tilcdc: tilcdc_panel: Rename device from "panel" to "tilcdc-panel"
>   drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
>   ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel
> 
>  arch/arm/boot/dts/am335x-evm.dts         | 44 +++++++++++++-------------------
>  drivers/gpu/drm/panel/panel-simple.c     | 26 +++++++++++++++++++
>  drivers/gpu/drm/tilcdc/Kconfig           |  2 ++
>  drivers/gpu/drm/tilcdc/tilcdc_external.c | 29 ++++++++++++++-------
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c    |  2 +-
>  5 files changed, 67 insertions(+), 36 deletions(-)
> 

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi
Daniel Vetter March 5, 2018, 8:46 a.m. | #2
On Mon, Feb 26, 2018 at 11:59:48AM +0200, Tomi Valkeinen wrote:
> On 22/02/18 19:07, Jyri Sarha wrote:
> > The first patch adds support for drm panels to tilcdc. The second is
> > just for convenience. The third adds support for am335x-evm's panel to
> > panel-simple driver. The third changes am335x-evm's dts file to use
> > panel-simple instead of tilcdc's bundled dpi-panel support.
> > 
> > After the review I will pick the tilcdc patches, but how about the
> > panel-simple, who will take it?
> > 
> > There is no hurry with the dts patch. We can even wait with it until the
> > next release, when everything certainly ready for it. The evm works just
> > fine with the old tilcdc bundled panel support and we probably have to
> > keep it around indefinately for backward compatibility.
> > 
> > Best regards,
> > Jyri
> > 
> > Jyri Sarha (4):
> >   drm/tilcdc: Add support for drm panels
> >   drm/tilcdc: tilcdc_panel: Rename device from "panel" to "tilcdc-panel"
> >   drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
> >   ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel
> > 
> >  arch/arm/boot/dts/am335x-evm.dts         | 44 +++++++++++++-------------------
> >  drivers/gpu/drm/panel/panel-simple.c     | 26 +++++++++++++++++++
> >  drivers/gpu/drm/tilcdc/Kconfig           |  2 ++
> >  drivers/gpu/drm/tilcdc/tilcdc_external.c | 29 ++++++++++++++-------
> >  drivers/gpu/drm/tilcdc/tilcdc_panel.c    |  2 +-
> >  5 files changed, 67 insertions(+), 36 deletions(-)
> > 
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Since panel drivers are in drm-misc probably simplest if we push these all
through that tree? Want commit rights for that?
-Daniel
Jyri Sarha March 5, 2018, 9:29 a.m. | #3
On 05/03/18 10:46, Daniel Vetter wrote:
> On Mon, Feb 26, 2018 at 11:59:48AM +0200, Tomi Valkeinen wrote:
>> On 22/02/18 19:07, Jyri Sarha wrote:
>>> The first patch adds support for drm panels to tilcdc. The second is
>>> just for convenience. The third adds support for am335x-evm's panel to
>>> panel-simple driver. The third changes am335x-evm's dts file to use
>>> panel-simple instead of tilcdc's bundled dpi-panel support.
>>>
>>> After the review I will pick the tilcdc patches, but how about the
>>> panel-simple, who will take it?
>>>
>>> There is no hurry with the dts patch. We can even wait with it until the
>>> next release, when everything certainly ready for it. The evm works just
>>> fine with the old tilcdc bundled panel support and we probably have to
>>> keep it around indefinately for backward compatibility.
>>>
>>> Best regards,
>>> Jyri
>>>
>>> Jyri Sarha (4):
>>>   drm/tilcdc: Add support for drm panels
>>>   drm/tilcdc: tilcdc_panel: Rename device from "panel" to "tilcdc-panel"
>>>   drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
>>>   ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel
>>>
>>>  arch/arm/boot/dts/am335x-evm.dts         | 44 +++++++++++++-------------------
>>>  drivers/gpu/drm/panel/panel-simple.c     | 26 +++++++++++++++++++
>>>  drivers/gpu/drm/tilcdc/Kconfig           |  2 ++
>>>  drivers/gpu/drm/tilcdc/tilcdc_external.c | 29 ++++++++++++++-------
>>>  drivers/gpu/drm/tilcdc/tilcdc_panel.c    |  2 +-
>>>  5 files changed, 67 insertions(+), 36 deletions(-)
>>>
>>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> Since panel drivers are in drm-misc probably simplest if we push these all
> through that tree? Want commit rights for that?
> -Daniel
> 

Sure. However, I already sent a pull request for tilcdc patches. But I
can send another for the panel patch to drm misc.

There is no direct dependency and I the dts patch can wait until the
next release, just to be sure that there is no breakage.

Best regards,
Jyri
Jyri Sarha March 5, 2018, 12:12 p.m. | #4
On 05/03/18 11:29, Jyri Sarha wrote:
>> Since panel drivers are in drm-misc probably simplest if we push these all

>> through that tree? Want commit rights for that?

>> -Daniel

>>

> Sure. However, I already sent a pull request for tilcdc patches. But I

> can send another for the panel patch to drm misc.

> 

> There is no direct dependency and I the dts patch can wait until the

> next release, just to be sure that there is no breakage.

> 


Oh... I was hasty in replying. But yes can push the panel patch to
drm-misc if you give me the rights. I guess you need my ssh public key
(attached) for that.

BR,
Jyri

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Daniel Vetter March 6, 2018, 7:49 a.m. | #5
On Mon, Mar 05, 2018 at 02:12:16PM +0200, Jyri Sarha wrote:
> On 05/03/18 11:29, Jyri Sarha wrote:
> >> Since panel drivers are in drm-misc probably simplest if we push these all
> >> through that tree? Want commit rights for that?
> >> -Daniel
> >>
> > Sure. However, I already sent a pull request for tilcdc patches. But I
> > can send another for the panel patch to drm misc.
> > 
> > There is no direct dependency and I the dts patch can wait until the
> > next release, just to be sure that there is no breakage.
> > 
> 
> Oh... I was hasty in replying. But yes can push the panel patch to
> drm-misc if you give me the rights. I guess you need my ssh public key
> (attached) for that.

You need a fd.o account, please follow the procedure here:

https://www.freedesktop.org/wiki/AccountRequests/

btw if we go this way there's also the question whether you want to
maintain tilcdc in drm-misc, but that's up to you.

Cheers, Daniel