From patchwork Wed Aug 22 16:30:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 144845 Delivered-To: patches@linaro.org Received: by 2002:a2e:164a:0:0:0:0:0 with SMTP id 10-v6csp212027ljw; Wed, 22 Aug 2018 09:30:48 -0700 (PDT) X-Received: by 2002:adf:a11c:: with SMTP id o28-v6mr14743342wro.169.1534955448835; Wed, 22 Aug 2018 09:30:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534955448; cv=none; d=google.com; s=arc-20160816; b=c3K0I5CEmUm58hbF9g1B4AIf8mvpiPZKPAyQqP793sMVcp/97Xp1oK4hjPw1Gy8OK5 PkS5m9HOoR/fJC5wHDvoZESTAnu91l6c3Ub76aIh1ZpyeBll+QHCqEEzCiPeMBvq+KMm sodZk3jQC6v3ZxGe1JU8VNzhsCnVAmkroqfNjIkTq+k9zZy09S1BeaIzDTBqttlkLtg6 9yRbPxnKhQDD5riKVsyFbQj5LNiQCRFZ3XWq1iG0T+Lzg6zjRDmK/EECWZ3TkMofjtVK tCmuMKTe8XpawNfXe/FGnsmRqQjzTIFJd5hoauD9vR/dTiMfdOKQjmH9Ji+JWTqfSngm 1t1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=b1TD9oT+2Ua6aoex0o/CC2wQ1kRH5QnZqlbl5mKQDDs=; b=vL1IXmyMuTpCJWcyQnc3yHdNSb3OUpPJ/jA8xjva5gj1iSXSpmwpNs0uCnQgSckkrK 0nx5v7bSpKucLBBfE77IE6DtIQN/ume1Y/NAna3JlWRSOkvU2Jm5oR+vrFazuvmRCRTX chk7H/Gx36y9FbH3Nej0PUbLAW7Nk8d9ONdjNWYG3F7FVbJdEMgBb8SYJBatKd8CpoaY Pvv6EYP4MIi+8OaPK/Vw80P+0h7g9PltHHrtPrpUjy6Z/bYaMWagETZ5TwXiUVByoBVd IkFO+OGoh5QaoXcP/Eb2X4s/Hx8ZffhhHrk5rxYAGw7n6xjRGRZiFqMwvidfquYRzbZC j8gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hS96m/Vj"; spf=pass (google.com: domain of ryan.harkin@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ryan.harkin@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a21-v6sor532480wmg.77.2018.08.22.09.30.48 for (Google Transport Security); Wed, 22 Aug 2018 09:30:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ryan.harkin@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hS96m/Vj"; spf=pass (google.com: domain of ryan.harkin@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ryan.harkin@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=b1TD9oT+2Ua6aoex0o/CC2wQ1kRH5QnZqlbl5mKQDDs=; b=hS96m/Vjz/prL7jFVW2aafQnpF7Uwz4R7OI0GNngOuLXB+i3R72h1GqVj1+R2tXC0p ap4pFyzf+Co8fCzEwjaL39fewbyZrRfJJVYMlJ+gW+IlAn65Kfa3TTMmbf1o2/kBoq+g 9nILMoSf34pSG3RSo5/ZMfdUwhBNXVo8Qi3L0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=b1TD9oT+2Ua6aoex0o/CC2wQ1kRH5QnZqlbl5mKQDDs=; b=r6FJ6BK4EHaVFvpzaABcq/BsktP51WqSzSFBRGDsnw9PzASblEPLMsyB0qGEmDY4w+ tVq4aoHbIn6T0w+BsNgoobnl1d1jm73vtV/KTFsRJrPe7meN9vb5lpGrSNv1AbaI+HvY Wf6IpV/hT6moaoBFqPT3ylBTiNlHqN427VuaPCSBGnY4U2JXMUSKeFOLYpmy155wSlTj FiaxLjytlOzhNzqZGuvgMk50jHo80lE25VlJZROw9vxK+VIdWAD2ARTKA0qRuAMFeLkL WVar/pX3hM+MT4fWXH1x6S9VZ1U8S1G6O9mSJBkEHJ8LhVvvyQoS0ViQiTnMuh8npXPu n9Tw== X-Gm-Message-State: APzg51B93eckHQVbV7nMy7v/YwK6JfnywF3Cp7kTM1sZBLJK+tBf3ve5 ZXFhHgI1ECbdGIoeNwtp8MYOn8uGlsajaA== X-Google-Smtp-Source: ANB0VdZyF6Rk2MNOAqFwCKvJcy58Eteex0iKqaPamMq+shJqneIH3JWxdw1BDXo2L5QY07Mh/8oOAQ== X-Received: by 2002:a1c:9e89:: with SMTP id h131-v6mr2692583wme.13.1534955448536; Wed, 22 Aug 2018 09:30:48 -0700 (PDT) Return-Path: Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by smtp.gmail.com with ESMTPSA id m8-v6sm2802229wrf.93.2018.08.22.09.30.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Aug 2018 09:30:47 -0700 (PDT) From: Ryan Harkin To: openembedded-core@lists.openembedded.org Cc: martin.jansa@gmail.com, patches@linaro.org, daiane.angolini@nxp.com Subject: [RFC 0/3] Adding BCM43430 NVRAM files Date: Wed, 22 Aug 2018 17:30:33 +0100 Message-Id: <1534955436-729-1-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.7.4 [Resending because I sent to the wrong email address for the oe-core mailing list] NVRAM files for the 43430 modules have been committed into the upstream Linux firmware repo. I'd like to add these files into the linux-firmware recipe. The following files exist upstream on kernel.org: - brcm/brcmfmac43430-sdio.AP6212.txt - brcm/brcmfmac43430-sdio.MUR1DX.txt The AP6212 and MUR1DX are the module types for variants of the 43430 chips. The first patch is a simple update to the latest upstream. I guess someone else will commit a similar change before I get to it, but for now, I need to make the update to test my changes, so I thought I'd send the patch with my RFC series. The second patch adds both NVRAM files into a single new variable. Ideally, the Linux kernel will be extended detect the module type, so having all the NVRAM files in /lib/firmware/brcm seems like a sensible thing to do. But advice here is appreciated. Perhaps I should have a separate variable for each file and allow the machine config to choose which configs to include in the filesystem, similar to how the .bin files are included since Martin Jansa's change? The 3rd patch is trickier, I think. At the moment, the Linux kernel expects there to be only one NVRAM file, named brcmfmac43430-sdio.txt. So to make the system "just work", it seems sensible to provide a way to softlink the module specific NVRAM to the generic filename. I'm trying to avoid each machine type having to define a softlink _append in its own config. Many different machines can use the same module type, for example. I'm just not convinced that the way I've done it is appropriate. eg. I don't like the usage of MACHINEOVERRIDE, or the variable name I've chosen. I'd hoped to do it using a MACHINE_EXTRA_RRECOMMENDS, but I'm not sure if that is possible. Again, advice is appreciated. Ryan Harkin (3): linux-firmware: upgrade to 1d17c18 revision linux-firmware: add BCM43430 nvram files linux-firmware: MACHINEOVERRIDES for BCM43430 NVRAM .../linux-firmware/linux-firmware_git.bb | 23 +++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) -- 2.7.4