[edk2,edk2-platforms,0/4] Platform/ARM: fix DevicePath mishandling in BdsLib

Message ID 20181122172645.20819-1-ard.biesheuvel@linaro.org
Headers show
Series
  • Platform/ARM: fix DevicePath mishandling in BdsLib
Related show

Message

Ard Biesheuvel Nov. 22, 2018, 5:26 p.m.
The deprecated BdsLib library class in ArmPkg is still depended upon, but
only a single implementation exists, which now resides in edk2-platforms.

This implementation has some issues in how it deals with Device Paths,
so let's fix those, but first move over the library interface declaration.
This will permit dropping it from ArmPkg in EDK2.

Ard Biesheuvel (4):
  Platform/ARM: import ARM platform specific BdsLib header
  Platform/ARM/BdsLid: drop unused BdsStartEfiApplication ()
  Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param
  Platform/ARM/BdsLib: maintain alignment for DevicePaths

 Platform/ARM/ARM.dec                          |   3 +
 .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   2 +-
 Platform/ARM/Include/Library/BdsLib.h         | 193 ++++++++++++++++++
 Platform/ARM/Library/BdsLib/BdsFilePath.c     |  71 ++-----
 Platform/ARM/Library/BdsLib/BdsInternal.h     |   1 -
 Platform/ARM/Library/BdsLib/BdsLib.inf        |   2 +-
 6 files changed, 212 insertions(+), 60 deletions(-)
 create mode 100644 Platform/ARM/Include/Library/BdsLib.h

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Thomas Abraham Nov. 23, 2018, 4:20 a.m. | #1
On Thu, Nov 22, 2018 at 10:56 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>

> The deprecated BdsLib library class in ArmPkg is still depended upon, but

> only a single implementation exists, which now resides in edk2-platforms.

>

> This implementation has some issues in how it deals with Device Paths,

> so let's fix those, but first move over the library interface declaration.

> This will permit dropping it from ArmPkg in EDK2.

>

> Ard Biesheuvel (4):

>   Platform/ARM: import ARM platform specific BdsLib header

>   Platform/ARM/BdsLid: drop unused BdsStartEfiApplication ()

>   Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param

>   Platform/ARM/BdsLib: maintain alignment for DevicePaths


This patch series when applied with the below two patch series
- [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB
- [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

does solve the boot issue on the Juno board.
>

>  Platform/ARM/ARM.dec                          |   3 +

>  .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   2 +-

>  Platform/ARM/Include/Library/BdsLib.h         | 193 ++++++++++++++++++

>  Platform/ARM/Library/BdsLib/BdsFilePath.c     |  71 ++-----

>  Platform/ARM/Library/BdsLib/BdsInternal.h     |   1 -

>  Platform/ARM/Library/BdsLib/BdsLib.inf        |   2 +-

>  6 files changed, 212 insertions(+), 60 deletions(-)

>  create mode 100644 Platform/ARM/Include/Library/BdsLib.h

>

> --

> 2.17.1

>

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 23, 2018, 8:44 a.m. | #2
On Fri, 23 Nov 2018 at 05:20, Thomas Abraham <thomas.abraham@arm.com> wrote:
>

> On Thu, Nov 22, 2018 at 10:56 PM Ard Biesheuvel

> <ard.biesheuvel@linaro.org> wrote:

> >

> > The deprecated BdsLib library class in ArmPkg is still depended upon, but

> > only a single implementation exists, which now resides in edk2-platforms.

> >

> > This implementation has some issues in how it deals with Device Paths,

> > so let's fix those, but first move over the library interface declaration.

> > This will permit dropping it from ArmPkg in EDK2.

> >

> > Ard Biesheuvel (4):

> >   Platform/ARM: import ARM platform specific BdsLib header

> >   Platform/ARM/BdsLid: drop unused BdsStartEfiApplication ()

> >   Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param

> >   Platform/ARM/BdsLib: maintain alignment for DevicePaths

>

> This patch series when applied with the below two patch series

> - [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB

> - [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

>

> does solve the boot issue on the Juno board.


Wonderful! Thanks for confirming.

> >

> >  Platform/ARM/ARM.dec                          |   3 +

> >  .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   2 +-

> >  Platform/ARM/Include/Library/BdsLib.h         | 193 ++++++++++++++++++

> >  Platform/ARM/Library/BdsLib/BdsFilePath.c     |  71 ++-----

> >  Platform/ARM/Library/BdsLib/BdsInternal.h     |   1 -

> >  Platform/ARM/Library/BdsLib/BdsLib.inf        |   2 +-

> >  6 files changed, 212 insertions(+), 60 deletions(-)

> >  create mode 100644 Platform/ARM/Include/Library/BdsLib.h

> >

> > --

> > 2.17.1

> >

> > _______________________________________________

> > edk2-devel mailing list

> > edk2-devel@lists.01.org

> > https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel