[0/6] mmc: mmci: Cleanup some variant related code

Message ID 20190306140456.28187-1-ulf.hansson@linaro.org
Headers show
Series
  • mmc: mmci: Cleanup some variant related code
Related show

Message

Ulf Hansson March 6, 2019, 2:04 p.m.
The introduction of variant specific callbacks were recently introduced. In
regards to that, I stumbled over of few things that I think deserves to be
cleaned up, hence this series.

No intentional functional change!

Ulf Hansson (6):
  mmc: mmci: Don't share un-implemented DMA functions
  mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag
  mmc: mmci: Re-work code starting DMA for the qcom variant
  mmc: mmci: Drop qcom specific header file
  mmc: mmci: Share sdmmc_variant_init() via the common header file
  mmc: mmci: Make mmci_variant_init() static

 drivers/mmc/host/mmci.c          | 13 +------------
 drivers/mmc/host/mmci.h          | 14 ++++++++++++++
 drivers/mmc/host/mmci_qcom_dml.c | 11 ++++++++---
 drivers/mmc/host/mmci_qcom_dml.h | 30 ------------------------------
 4 files changed, 23 insertions(+), 45 deletions(-)
 delete mode 100644 drivers/mmc/host/mmci_qcom_dml.h

-- 
2.17.1

Comments

Linus Walleij March 9, 2019, 5:54 p.m. | #1
On Wed, Mar 6, 2019 at 3:05 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:

> The introduction of variant specific callbacks were recently introduced. In

> regards to that, I stumbled over of few things that I think deserves to be

> cleaned up, hence this series.

>

> No intentional functional change!


This series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>


Yours,
Linus Walleij
Ulf Hansson March 18, 2019, 10:51 a.m. | #2
On Wed, 6 Mar 2019 at 15:04, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> The introduction of variant specific callbacks were recently introduced. In

> regards to that, I stumbled over of few things that I think deserves to be

> cleaned up, hence this series.

>

> No intentional functional change!

>

> Ulf Hansson (6):

>   mmc: mmci: Don't share un-implemented DMA functions

>   mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag

>   mmc: mmci: Re-work code starting DMA for the qcom variant

>   mmc: mmci: Drop qcom specific header file

>   mmc: mmci: Share sdmmc_variant_init() via the common header file

>   mmc: mmci: Make mmci_variant_init() static

>

>  drivers/mmc/host/mmci.c          | 13 +------------

>  drivers/mmc/host/mmci.h          | 14 ++++++++++++++

>  drivers/mmc/host/mmci_qcom_dml.c | 11 ++++++++---

>  drivers/mmc/host/mmci_qcom_dml.h | 30 ------------------------------

>  4 files changed, 23 insertions(+), 45 deletions(-)

>  delete mode 100644 drivers/mmc/host/mmci_qcom_dml.h

>

> --

> 2.17.1

>


FYI, applied for next.

Linus, Ludovic, thanks for testing and reviewing!

Kind regards
Uffe