mbox series

[net-next,v2,0/5] net: ipa: endpoint configuration updates

Message ID 20200630133304.1331058-1-elder@linaro.org
Headers show
Series net: ipa: endpoint configuration updates | expand

Message

Alex Elder June 30, 2020, 1:32 p.m. UTC 
This series updates code that configures IPA endpoints.  The changes
made mainly affect access to registers that are valid only for RX, or
only for TX endpoints.

The first three patches avoid writing endpoint registers if they are
not defined to be valid.  The fourth patch slightly modifies the
parameters for the offset macros used for these endpoint registers,
to make it explicit when only some endpoints are valid.

The last patch just tweaks one line of code so it uses a convention
used everywhere else in the driver.

Version 2 of this series eliminates some of the "assert()" comments
that Jakub inquired about.  The ones removed will actually go away
in an upcoming (not-yet-posted) patch series anyway.

					-Alex

Alex Elder (5):
  net: ipa: head-of-line block registers are RX only
  net: ipa: metadata_mask register is RX only
  net: ipa: mode register is TX only
  net: ipa: clarify endpoint register macro constraints
  net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask

 drivers/net/ipa/ipa_endpoint.c | 14 +++++------
 drivers/net/ipa/ipa_reg.h      | 43 ++++++++++++++++++++--------------
 2 files changed, 32 insertions(+), 25 deletions(-)

-- 
2.25.1

Comments

David Miller July 1, 2020, 10:30 p.m. UTC | #1 
From: Alex Elder <elder@linaro.org>

Date: Tue, 30 Jun 2020 08:32:59 -0500

> This series updates code that configures IPA endpoints.  The changes

> made mainly affect access to registers that are valid only for RX, or

> only for TX endpoints.

> 

> The first three patches avoid writing endpoint registers if they are

> not defined to be valid.  The fourth patch slightly modifies the

> parameters for the offset macros used for these endpoint registers,

> to make it explicit when only some endpoints are valid.

> 

> The last patch just tweaks one line of code so it uses a convention

> used everywhere else in the driver.

> 

> Version 2 of this series eliminates some of the "assert()" comments

> that Jakub inquired about.  The ones removed will actually go away

> in an upcoming (not-yet-posted) patch series anyway.


Series applied, thanks.