[v2,0/6] Add new controls for CQ and Frame-skip

Message ID 20200721074538.505-1-stanimir.varbanov@linaro.org
Headers show
Series
  • Add new controls for CQ and Frame-skip
Related show

Message

Stanimir Varbanov July 21, 2020, 7:45 a.m.
Hello,

Here is v2 with following changes:

 * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas
 * 4/6 Fixed compile warning

Previous version can be found at [1].

regards,
Stan

[1] https://lkml.org/lkml/2020/7/20/619

Maheshwar Ajja (1):
  media: v4l2-ctrls: Add encoder constant quality control

Stanimir Varbanov (5):
  venus: venc: Add support for constant quality control
  media: v4l2-ctrl: Add frame-skip std encoder control
  venus: venc: Add support for frame-skip mode v4l2 control
  media: s5p-mfc: Use standard frame skip mode control
  media: docs: Deprecate mfc frame skip control

 .../media/v4l/ext-ctrls-codec.rst             | 53 +++++++++++++++++++
 drivers/media/platform/qcom/venus/core.h      |  2 +
 drivers/media/platform/qcom/venus/hfi_cmds.c  | 37 ++++++++++++-
 .../media/platform/qcom/venus/hfi_helper.h    | 10 +++-
 drivers/media/platform/qcom/venus/venc.c      | 20 +++++--
 .../media/platform/qcom/venus/venc_ctrls.c    | 18 ++++++-
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c  |  6 +++
 drivers/media/v4l2-core/v4l2-ctrls.c          | 12 +++++
 include/uapi/linux/v4l2-controls.h            |  8 +++
 9 files changed, 160 insertions(+), 6 deletions(-)

-- 
2.17.1

Comments

Stanimir Varbanov July 24, 2020, 2:49 p.m. | #1
Hi Hans,

Could you suggest how to proceed with this :

- wait Samsung mainteners for ack.
- make a pull request with your ack for samsung mfc driver changes.
- make a pull request for constant quality only.
- postpone the whole patchset for 5.10 merge window.

On 7/21/20 10:45 AM, Stanimir Varbanov wrote:
> Hello,

> 

> Here is v2 with following changes:

> 

>  * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas

>  * 4/6 Fixed compile warning

> 

> Previous version can be found at [1].

> 

> regards,

> Stan

> 

> [1] https://lkml.org/lkml/2020/7/20/619

> 

> Maheshwar Ajja (1):

>   media: v4l2-ctrls: Add encoder constant quality control

> 

> Stanimir Varbanov (5):

>   venus: venc: Add support for constant quality control

>   media: v4l2-ctrl: Add frame-skip std encoder control

>   venus: venc: Add support for frame-skip mode v4l2 control

>   media: s5p-mfc: Use standard frame skip mode control

>   media: docs: Deprecate mfc frame skip control

> 

>  .../media/v4l/ext-ctrls-codec.rst             | 53 +++++++++++++++++++

>  drivers/media/platform/qcom/venus/core.h      |  2 +

>  drivers/media/platform/qcom/venus/hfi_cmds.c  | 37 ++++++++++++-

>  .../media/platform/qcom/venus/hfi_helper.h    | 10 +++-

>  drivers/media/platform/qcom/venus/venc.c      | 20 +++++--

>  .../media/platform/qcom/venus/venc_ctrls.c    | 18 ++++++-

>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c  |  6 +++

>  drivers/media/v4l2-core/v4l2-ctrls.c          | 12 +++++

>  include/uapi/linux/v4l2-controls.h            |  8 +++

>  9 files changed, 160 insertions(+), 6 deletions(-)

> 


-- 
regards,
Stan
Nicolas Dufresne July 30, 2020, 1:57 p.m. | #2
Le mardi 21 juillet 2020 à 10:45 +0300, Stanimir Varbanov a écrit :
> Hello,

> 

> Here is v2 with following changes:

> 

>  * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas


Thanks for this enhancement. No more comments on the doc from me.

>  * 4/6 Fixed compile warning

> 

> Previous version can be found at [1].

> 

> regards,

> Stan

> 

> [1] https://lkml.org/lkml/2020/7/20/619

> 

> Maheshwar Ajja (1):

>   media: v4l2-ctrls: Add encoder constant quality control

> 

> Stanimir Varbanov (5):

>   venus: venc: Add support for constant quality control

>   media: v4l2-ctrl: Add frame-skip std encoder control

>   venus: venc: Add support for frame-skip mode v4l2 control

>   media: s5p-mfc: Use standard frame skip mode control

>   media: docs: Deprecate mfc frame skip control

> 

>  .../media/v4l/ext-ctrls-codec.rst             | 53 +++++++++++++++++++

>  drivers/media/platform/qcom/venus/core.h      |  2 +

>  drivers/media/platform/qcom/venus/hfi_cmds.c  | 37 ++++++++++++-

>  .../media/platform/qcom/venus/hfi_helper.h    | 10 +++-

>  drivers/media/platform/qcom/venus/venc.c      | 20 +++++--

>  .../media/platform/qcom/venus/venc_ctrls.c    | 18 ++++++-

>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c  |  6 +++

>  drivers/media/v4l2-core/v4l2-ctrls.c          | 12 +++++

>  include/uapi/linux/v4l2-controls.h            |  8 +++

>  9 files changed, 160 insertions(+), 6 deletions(-)

>