mbox series

[PATCHv4,00/35,PATCHv3,00/35] SCSI result handling cleanup, part 1

Message ID 20210113090500.129644-1-hare@suse.de
Headers show
Series SCSI result handling cleanup, part 1 | expand

Message

Hannes Reinecke Jan. 13, 2021, 9:04 a.m. UTC 
Hi all,

this is the first part of an attempt to clean up SCSI result handling.
The patchset primarily cleans up various drivers by fixing up
whitespaces or move to standard definitions.
It also fixes some minor issues in some drivers which set the
wrong result values.
And, of course, another attempt to kill the gdth driver

I have a larger patchset based on this one to update the SCSI result
handling for all drivers, but decided to split things in two to not
overload reviewers

As usual, comments and reviews are welcome.

Changes to v1:
- Add reviews from Christoph
- Included review from Finn Thain
- Add set_status_byte() helper
- Add cleanup for dc395c
- Add additional patch for using SAM status values instead
  of the shifted linux versions

Changes to v2:
- Add Reviewed-by: tags
- Drop additional patches again

Changes to v3:
- Rebased to 5.12/scsi-queue
- Fixup kbuild failures
- Correct review tag from hch

Hannes Reinecke (35):
  scsi: drop gdth driver
  3w-xxxx: Whitespace cleanup
  3w-9xxx: Whitespace cleanup
  3w-sas: Whitespace cleanup
  atp870u: Whitespace cleanup
  aic7xxx,aic79xx: Whitespace cleanup
  aic7xxx,aic79xx: kill pointless forward declarations
  aic7xxx,aic79xxx: remove driver-defined SAM status definitions
  bfa: drop driver-defined SCSI status codes
  acornscsi: use standard defines
  nsp32: fixup status handling
  dc395: drop private SAM status code definitions
  qla4xxx: use standard SAM status definitions
  zfcp: do not set COMMAND_COMPLETE
  aacraid: avoid setting message byte on completion
  hpsa: do not set COMMAND_COMPLETE
  stex: do not set COMMAND_COMPLETE
  nsp_cs: drop internal SCSI message definition
  aic7xxx,aic79xx: drop internal SCSI message definition
  dc395x: drop internal SCSI message definitions
  initio: drop internal SCSI message definition
  scsi_debug: do not set COMMAND_COMPLETE
  ufshcd: do not set COMMAND_COMPLETE
  atp870u: use standard definitions
  mac53c94: Do not set invalid command result
  dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message
  scsi: add 'set_status_byte()' accessor
  esp_scsi: use host byte as last argument to esp_cmd_is_done()
  esp_scsi: do not set SCSI message byte
  wd33c93: use SCSI status
  ips: use correct command completion on error
  storvsc: Return DID_ERROR for invalid commands
  qla2xxx: fc_remote_port_chkready() returns a SCSI result value
  advansys: kill driver_defined status byte accessors
  ncr53c8xx: Use SAM status values

 Documentation/kbuild/makefiles.rst            |    4 +-
 Documentation/process/magic-number.rst        |    2 -
 Documentation/scsi/scsi-parameters.rst        |    3 -
 .../userspace-api/ioctl/ioctl-number.rst      |    1 -
 drivers/s390/scsi/zfcp_fc.h                   |    1 -
 drivers/scsi/3w-9xxx.c                        |   56 +-
 drivers/scsi/3w-9xxx.h                        |  156 +-
 drivers/scsi/3w-sas.c                         |   52 +-
 drivers/scsi/3w-sas.h                         |  118 +-
 drivers/scsi/3w-xxxx.c                        |  251 +-
 drivers/scsi/3w-xxxx.h                        |  199 +-
 drivers/scsi/Kconfig                          |   15 +-
 drivers/scsi/Makefile                         |    2 -
 drivers/scsi/aacraid/aachba.c                 |  173 +-
 drivers/scsi/advansys.c                       |   84 +-
 drivers/scsi/aic7xxx/aic79xx.h                |   36 +-
 drivers/scsi/aic7xxx/aic79xx_core.c           |  257 +-
 drivers/scsi/aic7xxx/aic79xx_osm.c            |   20 +-
 drivers/scsi/aic7xxx/aic79xx_osm.h            |   37 +-
 drivers/scsi/aic7xxx/aic79xx_osm_pci.c        |    6 +-
 drivers/scsi/aic7xxx/aic79xx_proc.c           |   13 +-
 drivers/scsi/aic7xxx/aic7xxx_93cx6.c          |    4 +-
 drivers/scsi/aic7xxx/aic7xxx_core.c           |  263 +-
 drivers/scsi/aic7xxx/aic7xxx_osm.c            |   88 +-
 drivers/scsi/aic7xxx/aic7xxx_osm.h            |   39 +-
 drivers/scsi/aic7xxx/aic7xxx_proc.c           |   15 +-
 drivers/scsi/aic7xxx/aiclib.h                 |   15 -
 drivers/scsi/aic7xxx/scsi_message.h           |   41 -
 drivers/scsi/arm/acornscsi.c                  |   14 +-
 drivers/scsi/atp870u.c                        |  451 +-
 drivers/scsi/atp870u.h                        |   14 +-
 drivers/scsi/bfa/bfa_fc.h                     |   15 -
 drivers/scsi/bfa/bfa_fcpim.c                  |    2 +-
 drivers/scsi/bfa/bfad_im.c                    |    2 +-
 drivers/scsi/dc395x.c                         |   28 +-
 drivers/scsi/dc395x.h                         |   38 -
 drivers/scsi/dpt_i2o.c                        |    2 +-
 drivers/scsi/esp_scsi.c                       |   23 +-
 drivers/scsi/gdth.c                           | 4322 -----------------
 drivers/scsi/gdth.h                           |  981 ----
 drivers/scsi/gdth_ioctl.h                     |  251 -
 drivers/scsi/gdth_proc.c                      |  586 ---
 drivers/scsi/gdth_proc.h                      |   18 -
 drivers/scsi/hpsa.c                           |    4 +-
 drivers/scsi/initio.c                         |   64 +-
 drivers/scsi/initio.h                         |   25 -
 drivers/scsi/ips.c                            |    9 +-
 drivers/scsi/mac53c94.c                       |    1 -
 drivers/scsi/ncr53c8xx.c                      |   83 +-
 drivers/scsi/ncr53c8xx.h                      |   16 -
 drivers/scsi/nsp32.c                          |    2 +-
 drivers/scsi/pcmcia/nsp_cs.c                  |   12 +-
 drivers/scsi/pcmcia/nsp_cs.h                  |   11 -
 drivers/scsi/qla2xxx/qla_os.c                 |    2 +-
 drivers/scsi/qla4xxx/ql4_fw.h                 |    1 -
 drivers/scsi/qla4xxx/ql4_isr.c                |    2 +-
 drivers/scsi/scsi_debug.c                     |    2 +-
 drivers/scsi/stex.c                           |   25 +-
 drivers/scsi/storvsc_drv.c                    |    2 +-
 drivers/scsi/ufs/ufshcd.c                     |    4 +-
 drivers/scsi/wd33c93.c                        |    6 +-
 include/scsi/scsi.h                           |    1 +
 include/scsi/scsi_cmnd.h                      |    5 +
 63 files changed, 1307 insertions(+), 7668 deletions(-)
 delete mode 100644 drivers/scsi/gdth.c
 delete mode 100644 drivers/scsi/gdth.h
 delete mode 100644 drivers/scsi/gdth_ioctl.h
 delete mode 100644 drivers/scsi/gdth_proc.c
 delete mode 100644 drivers/scsi/gdth_proc.h

Comments

Martin K. Petersen Jan. 23, 2021, 2:17 a.m. UTC | #1 
Hannes,

> this is the first part of an attempt to clean up SCSI result handling.

> The patchset primarily cleans up various drivers by fixing up

> whitespaces or move to standard definitions.  It also fixes some minor

> issues in some drivers which set the wrong result values.  And, of

> course, another attempt to kill the gdth driver


Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Jan. 27, 2021, 4:54 a.m. UTC | #2 
On Wed, 13 Jan 2021 10:04:25 +0100, Hannes Reinecke wrote:

> this is the first part of an attempt to clean up SCSI result handling.

> The patchset primarily cleans up various drivers by fixing up

> whitespaces or move to standard definitions.

> It also fixes some minor issues in some drivers which set the

> wrong result values.

> And, of course, another attempt to kill the gdth driver

> 

> [...]


Applied to 5.12/scsi-queue, thanks!

[01/35] scsi: drop gdth driver
        https://git.kernel.org/mkp/scsi/c/0653c358d2dc
[02/35] 3w-xxxx: Whitespace cleanup
        https://git.kernel.org/mkp/scsi/c/8148dfba29e7
[03/35] 3w-9xxx: Whitespace cleanup
        https://git.kernel.org/mkp/scsi/c/bf4eebbf53c9
[04/35] 3w-sas: Whitespace cleanup
        https://git.kernel.org/mkp/scsi/c/1789671ded39
[05/35] atp870u: Whitespace cleanup
        https://git.kernel.org/mkp/scsi/c/bcd5c59f21e3
[06/35] aic7xxx,aic79xx: Whitespace cleanup
        https://git.kernel.org/mkp/scsi/c/7662d92374df
[07/35] aic7xxx,aic79xx: kill pointless forward declarations
        https://git.kernel.org/mkp/scsi/c/c23435dbc747
[08/35] aic7xxx,aic79xxx: remove driver-defined SAM status definitions
        https://git.kernel.org/mkp/scsi/c/54c9f6fdefcc
[09/35] bfa: drop driver-defined SCSI status codes
        https://git.kernel.org/mkp/scsi/c/eb74b9322bce
[10/35] acornscsi: use standard defines
        https://git.kernel.org/mkp/scsi/c/0eb198d2c35f
[11/35] nsp32: fixup status handling
        https://git.kernel.org/mkp/scsi/c/23d339f08fac
[12/35] dc395: drop private SAM status code definitions
        https://git.kernel.org/mkp/scsi/c/f55475891edb
[13/35] qla4xxx: use standard SAM status definitions
        https://git.kernel.org/mkp/scsi/c/35f1cad1f928
[14/35] zfcp: do not set COMMAND_COMPLETE
        https://git.kernel.org/mkp/scsi/c/3273c91bbd01
[15/35] aacraid: avoid setting message byte on completion
        https://git.kernel.org/mkp/scsi/c/cdec16c1177a
[16/35] hpsa: do not set COMMAND_COMPLETE
        https://git.kernel.org/mkp/scsi/c/0e310ac4ef0d
[17/35] stex: do not set COMMAND_COMPLETE
        https://git.kernel.org/mkp/scsi/c/8959e81cf44a
[18/35] nsp_cs: drop internal SCSI message definition
        https://git.kernel.org/mkp/scsi/c/1c9eb798d566
[19/35] aic7xxx,aic79xx: drop internal SCSI message definition
        https://git.kernel.org/mkp/scsi/c/d8cd784ff7b3
[20/35] dc395x: drop internal SCSI message definitions
        https://git.kernel.org/mkp/scsi/c/9c2d26707351
[21/35] initio: drop internal SCSI message definition
        https://git.kernel.org/mkp/scsi/c/9df17f4679b7
[22/35] scsi_debug: do not set COMMAND_COMPLETE
        https://git.kernel.org/mkp/scsi/c/7a64c81448b2
[23/35] ufshcd: do not set COMMAND_COMPLETE
        https://git.kernel.org/mkp/scsi/c/db83d8a5c862
[24/35] atp870u: use standard definitions
        https://git.kernel.org/mkp/scsi/c/f3272258d79a
[25/35] mac53c94: Do not set invalid command result
        https://git.kernel.org/mkp/scsi/c/ddb99b1d1d4a
[26/35] dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message
        https://git.kernel.org/mkp/scsi/c/78c9efdd8dbf
[27/35] scsi: add 'set_status_byte()' accessor
        https://git.kernel.org/mkp/scsi/c/d37932a91600
[28/35] esp_scsi: use host byte as last argument to esp_cmd_is_done()
        https://git.kernel.org/mkp/scsi/c/6b50529e2f6f
[29/35] esp_scsi: do not set SCSI message byte
        https://git.kernel.org/mkp/scsi/c/809dadb15a91
[30/35] wd33c93: use SCSI status
        https://git.kernel.org/mkp/scsi/c/fc8e006c38e2
[31/35] ips: use correct command completion on error
        https://git.kernel.org/mkp/scsi/c/88188179f36c
[32/35] storvsc: Return DID_ERROR for invalid commands
        https://git.kernel.org/mkp/scsi/c/ecc751b27a57
[33/35] qla2xxx: fc_remote_port_chkready() returns a SCSI result value
        https://git.kernel.org/mkp/scsi/c/6098c3005d5a
[34/35] advansys: kill driver_defined status byte accessors
        https://git.kernel.org/mkp/scsi/c/aced5500ec82
[35/35] ncr53c8xx: Use SAM status values
        https://git.kernel.org/mkp/scsi/c/491152c7c3b5

-- 
Martin K. Petersen	Oracle Linux Engineering