| Message ID | 20210305092328.31792-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | testing/next (docs, hexagon, cfi, docker) | expand |
Patchew URL: https://patchew.org/QEMU/20210305092328.31792-1-alex.bennee@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210305092328.31792-1-alex.bennee@linaro.org Subject: [PATCH v1 0/9] testing/next (docs, hexagon, cfi, docker) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210305092328.31792-1-alex.bennee@linaro.org -> patchew/20210305092328.31792-1-alex.bennee@linaro.org Switched to a new branch 'test' 91a7ef1 tests/docker: Use --arch-only when building Debian cross image e0a95da gitlab-ci.yml: Add jobs to test CFI flags 360c5ee gitlab-ci.yml: Allow custom # of parallel linkers 222a269 gitlab: add build-user-hexagon test e226953 tests/tcg: Use Hexagon Docker image ffa599c docker: Add Hexagon image 14ff621 tests/docker: add a test-tcg for building then running check-tcg c540ed9 docs/system: add a gentle prompt for the complexity to come a190f84 docs/devel: re-organise the developers guide into sections === OUTPUT BEGIN === 1/9 Checking commit a190f84a7607 (docs/devel: re-organise the developers guide into sections) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #89: new file mode 100644 total: 0 errors, 1 warnings, 167 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit c540ed9c6222 (docs/system: add a gentle prompt for the complexity to come) 3/9 Checking commit 14ff6214abdf (tests/docker: add a test-tcg for building then running check-tcg) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100755 total: 0 errors, 1 warnings, 22 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit ffa599c3946f (docker: Add Hexagon image) WARNING: line over 80 characters #152: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #179: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #216: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 1 warnings, 184 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit e2269539f712 (tests/tcg: Use Hexagon Docker image) 6/9 Checking commit 222a269a7bf9 (gitlab: add build-user-hexagon test) 7/9 Checking commit 360c5ee0193d (gitlab-ci.yml: Allow custom # of parallel linkers) 8/9 Checking commit e0a95daa34d9 (gitlab-ci.yml: Add jobs to test CFI flags) 9/9 Checking commit 91a7ef19c6c1 (tests/docker: Use --arch-only when building Debian cross image) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210305092328.31792-1-alex.bennee@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, Mar 5, 2021 at 6:31 AM Alex Bennée <alex.bennee@linaro.org> wrote: > > Hi, > > Another week another testing/next roll. The series includes a couple > of my proposed documentation tweaks (including the re-org of the devel > manual). We also enable testing for the hexagon linux-user target to > avoid bitrot. I've documented the process for manually updating the > registry at: > > https://wiki.qemu.org/Testing/DockerBuild#The_GitLab_Registry > I see a mix of valid/invalid URLs, like `registry.gitlab.example.com` and then `registry.gitlab.com`. For consistency, my suggestion is to use either the example URL or a valid URL mentioning that is an example for a specific docker image.
Willian Rampazzo <wrampazz@redhat.com> writes: > On Fri, Mar 5, 2021 at 6:31 AM Alex Bennée <alex.bennee@linaro.org> wrote: >> >> Hi, >> >> Another week another testing/next roll. The series includes a couple >> of my proposed documentation tweaks (including the re-org of the devel >> manual). We also enable testing for the hexagon linux-user target to >> avoid bitrot. I've documented the process for manually updating the >> registry at: >> >> https://wiki.qemu.org/Testing/DockerBuild#The_GitLab_Registry >> > > I see a mix of valid/invalid URLs, like `registry.gitlab.example.com` > and then `registry.gitlab.com`. For consistency, my suggestion is to > use either the example URL or a valid URL mentioning that is an > example for a specific docker image. Oops bad copy/paste from my shell history. Fixed now. -- Alex Bennée