[00/30,Set,2] Rid W=1 warnings in SCSI

Message ID 20210312094738.2207817-1-lee.jones@linaro.org
Headers show
Series
  • Rid W=1 warnings in SCSI
Related show

Message

Lee Jones March 12, 2021, 9:47 a.m.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (30):
  scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot
  scsi: ufs: ufshcd: Fix incorrectly named
    ufshcd_find_max_sup_active_icc_level()
  scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours
  scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions
  scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()
  scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented
    functions/params
  scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()
  scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions
  scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues
  scsi: qla2xxx: qla_nx2: Fix incorrectly named function
    qla8044_check_temp()
  scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions
  scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function
    lpfc_debugfs_commonxripools_data()
  scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions
  scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the
    heap
  scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue
  scsi: ufs: cdns-pltfrm: Supply function names for headers
  scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()
  scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for
    esas2r_log_master()
  scsi: be2iscsi: be_iscsi: Fix incorrect naming of
    beiscsi_iface_config_vlan()
  scsi: be2iscsi: be_main: Provide missing function name in header
  scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header
  scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in
    description
  scsi: initio: Remove unused variable 'prev'
  scsi: a100u2w: Remove unused variable 'bios_phys'
  scsi: dc395x: Fix incorrect naming in function headers
  scsi: atp870u: Fix naming and demote incorrect and non-conformant
    kernel-doc header
  scsi: myrs: Remove a couple of unused 'status' variables
  scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and
    'tw_dev'
  scsi: 3w-9xxx: Remove a few set but unused variables
  scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'

 drivers/scsi/3w-9xxx.c                   | 14 ++++----------
 drivers/scsi/3w-sas.c                    | 10 ++--------
 drivers/scsi/3w-xxxx.c                   |  6 ++----
 drivers/scsi/a100u2w.c                   |  2 --
 drivers/scsi/atp870u.c                   |  7 +++----
 drivers/scsi/be2iscsi/be_iscsi.c         |  2 +-
 drivers/scsi/be2iscsi/be_main.c          |  1 +
 drivers/scsi/be2iscsi/be_mgmt.c          |  2 +-
 drivers/scsi/bfa/bfa_fcs_lport.c         | 20 ++++++++++++++------
 drivers/scsi/bnx2i/bnx2i_sysfs.c         |  2 +-
 drivers/scsi/cxgbi/cxgb3i/cxgb3i.c       |  2 +-
 drivers/scsi/dc395x.c                    |  6 +++---
 drivers/scsi/esas2r/esas2r_log.c         |  7 +++++++
 drivers/scsi/initio.c                    |  5 ++---
 drivers/scsi/libfc/fc_fcp.c              |  2 +-
 drivers/scsi/libfc/fc_rport.c            |  2 +-
 drivers/scsi/lpfc/lpfc_attr.c            | 12 ++++++------
 drivers/scsi/lpfc/lpfc_bsg.c             |  6 +++---
 drivers/scsi/lpfc/lpfc_debugfs.c         |  2 +-
 drivers/scsi/lpfc/lpfc_nvme.c            |  2 +-
 drivers/scsi/lpfc/lpfc_scsi.c            | 24 ++++++++++++------------
 drivers/scsi/mpt3sas/mpt3sas_config.c    | 10 +++++-----
 drivers/scsi/mpt3sas/mpt3sas_ctl.c       | 16 ++++++++--------
 drivers/scsi/mpt3sas/mpt3sas_transport.c |  7 ++++---
 drivers/scsi/myrs.c                      |  6 ++----
 drivers/scsi/qla2xxx/qla_mr.c            |  4 ++--
 drivers/scsi/qla2xxx/qla_nx2.c           |  2 +-
 drivers/scsi/qla2xxx/qla_target.c        |  4 ++--
 drivers/scsi/ufs/cdns-pltfrm.c           |  4 ++++
 drivers/scsi/ufs/ufshcd.c                |  2 +-
 30 files changed, 96 insertions(+), 95 deletions(-)

Cc: Adam Radford <aradford@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ali Akcaagac <aliakc@web.de>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Andre Hedrick <andre@suse.com>
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
Cc: Bradley Grove <linuxdrivers@attotech.com>
Cc: Brian Macy <bmacy@sunshinecomputing.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: "C.L. Huang" <ching@tekram.com.tw>
Cc: dc395x@twibble.org
Cc: de Melo <acme@conectiva.com.br>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: Dimitris Michailidis <dm@chelsio.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Eddie Wai <eddie.wai@broadcom.com>
Cc: Erich Chen <erich@tekram.com.tw>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: Hannes Reinecke <hare@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Jamie Lenehan <lenehan@twibble.org>
Cc: Jan Kotas <jank@cadence.com>
Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Cc: Joel Jacobson <linux@3ware.com>
Cc: Karen Xie <kxie@chelsio.com>
Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
Cc: Kurt Garloff <garloff@suse.de>
Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
Cc: linux-drivers@broadcom.com
Cc: Linux GmbH <hare@suse.com>
Cc: linux-scsi@vger.kernel.org
Cc: Manish Rangankar <mrangankar@marvell.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: MPT-FusionLinux.pdl@avagotech.com
Cc: MPT-FusionLinux.pdl@broadcom.com
Cc: Nathaniel Clark <nate@misrule.us>
Cc: "Nicholas A. Bellinger" <nab@kernel.org>
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Oliver Neukum <oliver@neukum.org>
Cc: QLogic-Storage-Upstream@qlogic.com
Cc: Santosh Yaraganavi <santosh.sy@samsung.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>
Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: Vinayak Holikatti <h.vinayak@samsung.com>
Cc: Vladislav Bolkhovitin <vst@vlnb.net>
-- 
2.27.0

Comments

Martin K. Petersen March 16, 2021, 2:29 a.m. | #1
Lee,

> This set is part of a larger effort attempting to clean-up W=1 kernel

> builds, which are currently overwhelmingly riddled with niggly little

> warnings.


Applied to 5.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Lee Jones March 16, 2021, 7:17 a.m. | #2
On Mon, 15 Mar 2021, Martin K. Petersen wrote:

> 

> Lee,

> 

> > This set is part of a larger effort attempting to clean-up W=1 kernel

> > builds, which are currently overwhelmingly riddled with niggly little

> > warnings.

> 

> Applied to 5.13/scsi-staging, thanks!


Superstar!  Thanks Martin.

Just FYI, there are more 44 more patches left until clean.

Would you like them in 1 or 2 sets?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Martin K. Petersen March 17, 2021, 1:38 a.m. | #3
Lee,

> Would you like them in 1 or 2 sets?


As long as they are trivial, one set is fine.

What does help is to split by complexity. In your two previous series I
would have preferred the mpt3sas and bfa patches that actually change
code to be posted separately. Just to make sure they don't get lost in a
sea of trivial changes.

IOW, if the patches contain substantial functional changes I'd prefer
them to be separate from all the kernel-doc, function prototype,
etc. fixes.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Lee Jones March 17, 2021, 8:13 a.m. | #4
On Tue, 16 Mar 2021, Martin K. Petersen wrote:

> 

> Lee,

> 

> > Would you like them in 1 or 2 sets?

> 

> As long as they are trivial, one set is fine.

> 

> What does help is to split by complexity. In your two previous series I

> would have preferred the mpt3sas and bfa patches that actually change

> code to be posted separately. Just to make sure they don't get lost in a

> sea of trivial changes.

> 

> IOW, if the patches contain substantial functional changes I'd prefer

> them to be separate from all the kernel-doc, function prototype,

> etc. fixes.


At the moment, my process involves a script which opens each file and
works it's way through the reported issues.

I'll take a look through the remaining patches and try to pull out any
that are more complex.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Martin K. Petersen March 19, 2021, 3:46 a.m. | #5
On Fri, 12 Mar 2021 09:47:08 +0000, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1

> kernel builds, which are currently overwhelmingly riddled with

> niggly little warnings.

> 

> Lee Jones (30):

>   scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot

>   scsi: ufs: ufshcd: Fix incorrectly named

>     ufshcd_find_max_sup_active_icc_level()

>   scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours

>   scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions

>   scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()

>   scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented

>     functions/params

>   scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()

>   scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions

>   scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues

>   scsi: qla2xxx: qla_nx2: Fix incorrectly named function

>     qla8044_check_temp()

>   scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions

>   scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function

>     lpfc_debugfs_commonxripools_data()

>   scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions

>   scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the

>     heap

>   scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue

>   scsi: ufs: cdns-pltfrm: Supply function names for headers

>   scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()

>   scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for

>     esas2r_log_master()

>   scsi: be2iscsi: be_iscsi: Fix incorrect naming of

>     beiscsi_iface_config_vlan()

>   scsi: be2iscsi: be_main: Provide missing function name in header

>   scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header

>   scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in

>     description

>   scsi: initio: Remove unused variable 'prev'

>   scsi: a100u2w: Remove unused variable 'bios_phys'

>   scsi: dc395x: Fix incorrect naming in function headers

>   scsi: atp870u: Fix naming and demote incorrect and non-conformant

>     kernel-doc header

>   scsi: myrs: Remove a couple of unused 'status' variables

>   scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and

>     'tw_dev'

>   scsi: 3w-9xxx: Remove a few set but unused variables

>   scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'

> 

> [...]


Applied to 5.13/scsi-queue, thanks!

[01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot
        https://git.kernel.org/mkp/scsi/c/cf9e575e62a4
[02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level()
        https://git.kernel.org/mkp/scsi/c/11eea9b3fd4d
[03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours
        https://git.kernel.org/mkp/scsi/c/0bb87e01d815
[04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions
        https://git.kernel.org/mkp/scsi/c/a3dbf5145d01
[05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()
        https://git.kernel.org/mkp/scsi/c/0dbea7c18873
[06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params
        https://git.kernel.org/mkp/scsi/c/54cb88dc3083
[07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()
        https://git.kernel.org/mkp/scsi/c/775b4d65a6fb
[08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions
        https://git.kernel.org/mkp/scsi/c/381095668d51
[09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues
        https://git.kernel.org/mkp/scsi/c/782a1ab33f71
[10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp()
        https://git.kernel.org/mkp/scsi/c/a736e4490442
[11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions
        https://git.kernel.org/mkp/scsi/c/dc49ab48a77c
[12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data()
        https://git.kernel.org/mkp/scsi/c/2c6400b78243
[13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions
        https://git.kernel.org/mkp/scsi/c/3145d2d69e16
[14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap
        https://git.kernel.org/mkp/scsi/c/a7a11b6cfec2
[15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue
        https://git.kernel.org/mkp/scsi/c/f6b35a75042b
[16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers
        https://git.kernel.org/mkp/scsi/c/d5db88b0ce89
[17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()
        https://git.kernel.org/mkp/scsi/c/181883786427
[18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master()
        https://git.kernel.org/mkp/scsi/c/1c666a3e0a54
[19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan()
        https://git.kernel.org/mkp/scsi/c/1b8a7ee9308e
[20/30] scsi: be2iscsi: be_main: Provide missing function name in header
        https://git.kernel.org/mkp/scsi/c/a905a1dce8bf
[21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header
        https://git.kernel.org/mkp/scsi/c/ab4bab7a977d
[22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description
        https://git.kernel.org/mkp/scsi/c/0a386beb7ebd
[23/30] scsi: initio: Remove unused variable 'prev'
        https://git.kernel.org/mkp/scsi/c/78e40ac8b696
[24/30] scsi: a100u2w: Remove unused variable 'bios_phys'
        https://git.kernel.org/mkp/scsi/c/fb5b29b2ad3f
[25/30] scsi: dc395x: Fix incorrect naming in function headers
        https://git.kernel.org/mkp/scsi/c/167b7e6bfbf5
[26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header
        https://git.kernel.org/mkp/scsi/c/6b71f60ca205
[27/30] scsi: myrs: Remove a couple of unused 'status' variables
        https://git.kernel.org/mkp/scsi/c/3cb0cfb557cd
[28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev'
        https://git.kernel.org/mkp/scsi/c/6c31cb74a1ce
[29/30] scsi: 3w-9xxx: Remove a few set but unused variables
        https://git.kernel.org/mkp/scsi/c/ea7fb5344ad0
[30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'
        https://git.kernel.org/mkp/scsi/c/475bff65c431

-- 
Martin K. Petersen	Oracle Linux Engineering