[0/7] usb: isp1760: extend support for isp1763

Message ID 20210504101910.18619-1-rui.silva@linaro.org
Headers show
Series
  • usb: isp1760: extend support for isp1763
Related show

Message

Rui Miguel Silva May 4, 2021, 10:19 a.m.
The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.
There is already support for the isp1760 and isp1761 in tree, this series extend
the support also for the isp1763.

Move register access using regmap, remove some platform data and code, refactor
the mempool, use dr_mode to align to existing bindings, then add the support for
isp1763 host mode, add bindings files that did not existed and at the end
add also support for peripheral mode for isp1763.

@Laurent and @Sebastian, I add both of you in the bindings files as maintainers
(it is a mandatory field)since you were the ones which contributed with the
initial code and peripheral code, let me know if you are ok with it.
If yes I may send a follow up to add also entries in MAINTAINERS file that it is
also missing.

Cheers,
   Rui

[0]: https://developer.arm.com/tools-and-software/development-boards/fpga-prototyping-boards/mps3
[1]: https://media.digikey.com/pdf/Data%20Sheets/ST%20Ericsson%20PDFs/ISP1763A.pdf

Rui Miguel Silva (7):
  usb: isp1760: move to regmap for register access
  usb: isp1760: remove platform data struct and code
  usb: isp1760: hcd: refactor mempool config and setup
  usb: isp1760: use dr_mode binding
  usb: isp1760: add support for isp1763
  dt-bindings: usb: nxp,isp1760: add bindings
  usb: isp1763: add peripheral mode

 .../devicetree/bindings/usb/nxp,isp1760.yaml  |  59 ++
 arch/arm/boot/dts/arm-realview-eb.dtsi        |   2 +-
 arch/arm/boot/dts/arm-realview-pb1176.dts     |   2 +-
 arch/arm/boot/dts/arm-realview-pb11mp.dts     |   2 +-
 arch/arm/boot/dts/arm-realview-pbx.dtsi       |   2 +-
 arch/arm/boot/dts/vexpress-v2m-rs1.dtsi       |   2 +-
 arch/arm/boot/dts/vexpress-v2m.dtsi           |   2 +-
 drivers/usb/isp1760/Kconfig                   |   4 +-
 drivers/usb/isp1760/isp1760-core.c            | 248 ++++-
 drivers/usb/isp1760/isp1760-core.h            |  44 +-
 drivers/usb/isp1760/isp1760-hcd.c             | 898 ++++++++++++------
 drivers/usb/isp1760/isp1760-hcd.h             |  57 +-
 drivers/usb/isp1760/isp1760-if.c              |  41 +-
 drivers/usb/isp1760/isp1760-regs.h            | 698 ++++++++++----
 drivers/usb/isp1760/isp1760-udc.c             | 240 +++--
 drivers/usb/isp1760/isp1760-udc.h             |  12 +-
 include/linux/usb/isp1760.h                   |  19 -
 17 files changed, 1672 insertions(+), 660 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/nxp,isp1760.yaml
 delete mode 100644 include/linux/usb/isp1760.h

Comments

Greg Kroah-Hartman May 6, 2021, 10:50 a.m. | #1
On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:
> The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> There is already support for the isp1760 and isp1761 in tree, this series extend

> the support also for the isp1763.

> 

> Move register access using regmap, remove some platform data and code, refactor

> the mempool, use dr_mode to align to existing bindings, then add the support for

> isp1763 host mode, add bindings files that did not existed and at the end

> add also support for peripheral mode for isp1763.

> 

> @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> (it is a mandatory field)since you were the ones which contributed with the

> initial code and peripheral code, let me know if you are ok with it.

> If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> also missing.


First 3 patches now applied, feel free to rebase and resend the rest
based on the review comments.

thanks,

greg k-h
Laurent Pinchart May 6, 2021, 12:25 p.m. | #2
Hi Greg,

On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > There is already support for the isp1760 and isp1761 in tree, this series extend

> > the support also for the isp1763.

> > 

> > Move register access using regmap, remove some platform data and code, refactor

> > the mempool, use dr_mode to align to existing bindings, then add the support for

> > isp1763 host mode, add bindings files that did not existed and at the end

> > add also support for peripheral mode for isp1763.

> > 

> > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > (it is a mandatory field)since you were the ones which contributed with the

> > initial code and peripheral code, let me know if you are ok with it.

> > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > also missing.

> 

> First 3 patches now applied, feel free to rebase and resend the rest

> based on the review comments.


That's a bit fast, I've just review 1/7.

-- 
Regards,

Laurent Pinchart
Rui Miguel Silva May 6, 2021, 1:29 p.m. | #3
Hi Greg,
On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote:
> On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > There is already support for the isp1760 and isp1761 in tree, this series extend

> > the support also for the isp1763.

> > 

> > Move register access using regmap, remove some platform data and code, refactor

> > the mempool, use dr_mode to align to existing bindings, then add the support for

> > isp1763 host mode, add bindings files that did not existed and at the end

> > add also support for peripheral mode for isp1763.

> > 

> > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > (it is a mandatory field)since you were the ones which contributed with the

> > initial code and peripheral code, let me know if you are ok with it.

> > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > also missing.

>

> First 3 patches now applied, feel free to rebase and resend the rest

> based on the review comments.


Thanks, yeah, I was taking the chance to clean all the pre-existing
sparse warnings in that driver, since this was triggering some new
ones.

And I knew that you merging this first ones would make Laurent jump
from his chair and review this, eheh. Thanks for that also.

I will rebase and send follow up series that will address all
that sparse warnings.

------
Cheers,
     Rui
Laurent Pinchart May 6, 2021, 1:38 p.m. | #4
On Thu, May 06, 2021 at 02:29:14PM +0100, Rui Miguel Silva wrote:
> On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote:

> > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > > There is already support for the isp1760 and isp1761 in tree, this series extend

> > > the support also for the isp1763.

> > > 

> > > Move register access using regmap, remove some platform data and code, refactor

> > > the mempool, use dr_mode to align to existing bindings, then add the support for

> > > isp1763 host mode, add bindings files that did not existed and at the end

> > > add also support for peripheral mode for isp1763.

> > > 

> > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > > (it is a mandatory field)since you were the ones which contributed with the

> > > initial code and peripheral code, let me know if you are ok with it.

> > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > > also missing.

> >

> > First 3 patches now applied, feel free to rebase and resend the rest

> > based on the review comments.

> 

> Thanks, yeah, I was taking the chance to clean all the pre-existing

> sparse warnings in that driver, since this was triggering some new

> ones.

> 

> And I knew that you merging this first ones would make Laurent jump

> from his chair and review this, eheh. Thanks for that also.


You've planned it together, haven't you, you naughty scoundrels :-D

> I will rebase and send follow up series that will address all

> that sparse warnings.


-- 
Regards,

Laurent Pinchart
Rui Miguel Silva May 6, 2021, 1:41 p.m. | #5
Hi Greg,
On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote:
> Hi Greg,

>

> On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote:

> > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > > There is already support for the isp1760 and isp1761 in tree, this series extend

> > > the support also for the isp1763.

> > > 

> > > Move register access using regmap, remove some platform data and code, refactor

> > > the mempool, use dr_mode to align to existing bindings, then add the support for

> > > isp1763 host mode, add bindings files that did not existed and at the end

> > > add also support for peripheral mode for isp1763.

> > > 

> > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > > (it is a mandatory field)since you were the ones which contributed with the

> > > initial code and peripheral code, let me know if you are ok with it.

> > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > > also missing.

> > 

> > First 3 patches now applied, feel free to rebase and resend the rest

> > based on the review comments.

>

> That's a bit fast, I've just review 1/7.


Let me know if you will drop the patches from your queue, or do you
want me to send some follow up, since Laurent comments are not very
large?

------
Cheers,
     Rui
>

> -- 

> Regards,

>

> Laurent Pinchart
Rui Miguel Silva May 6, 2021, 1:53 p.m. | #6
On Thu May 6, 2021 at 2:38 PM WEST, Laurent Pinchart wrote:

> On Thu, May 06, 2021 at 02:29:14PM +0100, Rui Miguel Silva wrote:

> > On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote:

> > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > > > There is already support for the isp1760 and isp1761 in tree, this series extend

> > > > the support also for the isp1763.

> > > > 

> > > > Move register access using regmap, remove some platform data and code, refactor

> > > > the mempool, use dr_mode to align to existing bindings, then add the support for

> > > > isp1763 host mode, add bindings files that did not existed and at the end

> > > > add also support for peripheral mode for isp1763.

> > > > 

> > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > > > (it is a mandatory field)since you were the ones which contributed with the

> > > > initial code and peripheral code, let me know if you are ok with it.

> > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > > > also missing.

> > >

> > > First 3 patches now applied, feel free to rebase and resend the rest

> > > based on the review comments.

> > 

> > Thanks, yeah, I was taking the chance to clean all the pre-existing

> > sparse warnings in that driver, since this was triggering some new

> > ones.

> > 

> > And I knew that you merging this first ones would make Laurent jump

> > from his chair and review this, eheh. Thanks for that also.

>

> You've planned it together, haven't you, you naughty scoundrels :-D


No, but I wish :)
Greg Kroah-Hartman May 6, 2021, 2:02 p.m. | #7
On Thu, May 06, 2021 at 02:41:14PM +0100, Rui Miguel Silva wrote:
> Hi Greg,

> On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote:

> > Hi Greg,

> >

> > On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote:

> > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > > > There is already support for the isp1760 and isp1761 in tree, this series extend

> > > > the support also for the isp1763.

> > > > 

> > > > Move register access using regmap, remove some platform data and code, refactor

> > > > the mempool, use dr_mode to align to existing bindings, then add the support for

> > > > isp1763 host mode, add bindings files that did not existed and at the end

> > > > add also support for peripheral mode for isp1763.

> > > > 

> > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > > > (it is a mandatory field)since you were the ones which contributed with the

> > > > initial code and peripheral code, let me know if you are ok with it.

> > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > > > also missing.

> > > 

> > > First 3 patches now applied, feel free to rebase and resend the rest

> > > based on the review comments.

> >

> > That's a bit fast, I've just review 1/7.

> 

> Let me know if you will drop the patches from your queue, or do you

> want me to send some follow up, since Laurent comments are not very

> large?


Follow-up is fine :)

thanks,

greg k-h
Rui Miguel Silva May 6, 2021, 2:15 p.m. | #8
On Thu May 6, 2021 at 3:02 PM WEST, Greg Kroah-Hartman wrote:
> On Thu, May 06, 2021 at 02:41:14PM +0100, Rui Miguel Silva wrote:

> > Hi Greg,

> > On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote:

> > > Hi Greg,

> > >

> > > On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote:

> > > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote:

> > > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller.

> > > > > There is already support for the isp1760 and isp1761 in tree, this series extend

> > > > > the support also for the isp1763.

> > > > > 

> > > > > Move register access using regmap, remove some platform data and code, refactor

> > > > > the mempool, use dr_mode to align to existing bindings, then add the support for

> > > > > isp1763 host mode, add bindings files that did not existed and at the end

> > > > > add also support for peripheral mode for isp1763.

> > > > > 

> > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers

> > > > > (it is a mandatory field)since you were the ones which contributed with the

> > > > > initial code and peripheral code, let me know if you are ok with it.

> > > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is

> > > > > also missing.

> > > > 

> > > > First 3 patches now applied, feel free to rebase and resend the rest

> > > > based on the review comments.

> > >

> > > That's a bit fast, I've just review 1/7.

> > 

> > Let me know if you will drop the patches from your queue, or do you

> > want me to send some follow up, since Laurent comments are not very

> > large?

>

> Follow-up is fine :)


Will do, thanks.

------
Cheers,
     Rui