| Message ID | 20210504101910.18619-1-rui.silva@linaro.org |
|---|---|
| Headers | show |
| Series | usb: isp1760: extend support for isp1763 | expand |
On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > There is already support for the isp1760 and isp1761 in tree, this series extend > the support also for the isp1763. > > Move register access using regmap, remove some platform data and code, refactor > the mempool, use dr_mode to align to existing bindings, then add the support for > isp1763 host mode, add bindings files that did not existed and at the end > add also support for peripheral mode for isp1763. > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > (it is a mandatory field)since you were the ones which contributed with the > initial code and peripheral code, let me know if you are ok with it. > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > also missing. First 3 patches now applied, feel free to rebase and resend the rest based on the review comments. thanks, greg k-h
Hi Greg, On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > There is already support for the isp1760 and isp1761 in tree, this series extend > > the support also for the isp1763. > > > > Move register access using regmap, remove some platform data and code, refactor > > the mempool, use dr_mode to align to existing bindings, then add the support for > > isp1763 host mode, add bindings files that did not existed and at the end > > add also support for peripheral mode for isp1763. > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > (it is a mandatory field)since you were the ones which contributed with the > > initial code and peripheral code, let me know if you are ok with it. > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > also missing. > > First 3 patches now applied, feel free to rebase and resend the rest > based on the review comments. That's a bit fast, I've just review 1/7. -- Regards, Laurent Pinchart
Hi Greg, On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote: > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > There is already support for the isp1760 and isp1761 in tree, this series extend > > the support also for the isp1763. > > > > Move register access using regmap, remove some platform data and code, refactor > > the mempool, use dr_mode to align to existing bindings, then add the support for > > isp1763 host mode, add bindings files that did not existed and at the end > > add also support for peripheral mode for isp1763. > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > (it is a mandatory field)since you were the ones which contributed with the > > initial code and peripheral code, let me know if you are ok with it. > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > also missing. > > First 3 patches now applied, feel free to rebase and resend the rest > based on the review comments. Thanks, yeah, I was taking the chance to clean all the pre-existing sparse warnings in that driver, since this was triggering some new ones. And I knew that you merging this first ones would make Laurent jump from his chair and review this, eheh. Thanks for that also. I will rebase and send follow up series that will address all that sparse warnings. ------ Cheers, Rui
On Thu, May 06, 2021 at 02:29:14PM +0100, Rui Miguel Silva wrote: > On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote: > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > > There is already support for the isp1760 and isp1761 in tree, this series extend > > > the support also for the isp1763. > > > > > > Move register access using regmap, remove some platform data and code, refactor > > > the mempool, use dr_mode to align to existing bindings, then add the support for > > > isp1763 host mode, add bindings files that did not existed and at the end > > > add also support for peripheral mode for isp1763. > > > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > > (it is a mandatory field)since you were the ones which contributed with the > > > initial code and peripheral code, let me know if you are ok with it. > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > > also missing. > > > > First 3 patches now applied, feel free to rebase and resend the rest > > based on the review comments. > > Thanks, yeah, I was taking the chance to clean all the pre-existing > sparse warnings in that driver, since this was triggering some new > ones. > > And I knew that you merging this first ones would make Laurent jump > from his chair and review this, eheh. Thanks for that also. You've planned it together, haven't you, you naughty scoundrels :-D > I will rebase and send follow up series that will address all > that sparse warnings. -- Regards, Laurent Pinchart
Hi Greg, On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote: > Hi Greg, > > On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote: > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > > There is already support for the isp1760 and isp1761 in tree, this series extend > > > the support also for the isp1763. > > > > > > Move register access using regmap, remove some platform data and code, refactor > > > the mempool, use dr_mode to align to existing bindings, then add the support for > > > isp1763 host mode, add bindings files that did not existed and at the end > > > add also support for peripheral mode for isp1763. > > > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > > (it is a mandatory field)since you were the ones which contributed with the > > > initial code and peripheral code, let me know if you are ok with it. > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > > also missing. > > > > First 3 patches now applied, feel free to rebase and resend the rest > > based on the review comments. > > That's a bit fast, I've just review 1/7. Let me know if you will drop the patches from your queue, or do you want me to send some follow up, since Laurent comments are not very large? ------ Cheers, Rui > > -- > Regards, > > Laurent Pinchart
On Thu May 6, 2021 at 2:38 PM WEST, Laurent Pinchart wrote: > On Thu, May 06, 2021 at 02:29:14PM +0100, Rui Miguel Silva wrote: > > On Thu May 6, 2021 at 11:50 AM WEST, Greg Kroah-Hartman wrote: > > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > > > There is already support for the isp1760 and isp1761 in tree, this series extend > > > > the support also for the isp1763. > > > > > > > > Move register access using regmap, remove some platform data and code, refactor > > > > the mempool, use dr_mode to align to existing bindings, then add the support for > > > > isp1763 host mode, add bindings files that did not existed and at the end > > > > add also support for peripheral mode for isp1763. > > > > > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > > > (it is a mandatory field)since you were the ones which contributed with the > > > > initial code and peripheral code, let me know if you are ok with it. > > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > > > also missing. > > > > > > First 3 patches now applied, feel free to rebase and resend the rest > > > based on the review comments. > > > > Thanks, yeah, I was taking the chance to clean all the pre-existing > > sparse warnings in that driver, since this was triggering some new > > ones. > > > > And I knew that you merging this first ones would make Laurent jump > > from his chair and review this, eheh. Thanks for that also. > > You've planned it together, haven't you, you naughty scoundrels :-D No, but I wish :)
On Thu, May 06, 2021 at 02:41:14PM +0100, Rui Miguel Silva wrote: > Hi Greg, > On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote: > > Hi Greg, > > > > On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > > > There is already support for the isp1760 and isp1761 in tree, this series extend > > > > the support also for the isp1763. > > > > > > > > Move register access using regmap, remove some platform data and code, refactor > > > > the mempool, use dr_mode to align to existing bindings, then add the support for > > > > isp1763 host mode, add bindings files that did not existed and at the end > > > > add also support for peripheral mode for isp1763. > > > > > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > > > (it is a mandatory field)since you were the ones which contributed with the > > > > initial code and peripheral code, let me know if you are ok with it. > > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > > > also missing. > > > > > > First 3 patches now applied, feel free to rebase and resend the rest > > > based on the review comments. > > > > That's a bit fast, I've just review 1/7. > > Let me know if you will drop the patches from your queue, or do you > want me to send some follow up, since Laurent comments are not very > large? Follow-up is fine :) thanks, greg k-h
On Thu May 6, 2021 at 3:02 PM WEST, Greg Kroah-Hartman wrote: > On Thu, May 06, 2021 at 02:41:14PM +0100, Rui Miguel Silva wrote: > > Hi Greg, > > On Thu May 6, 2021 at 1:25 PM WEST, Laurent Pinchart wrote: > > > Hi Greg, > > > > > > On Thu, May 06, 2021 at 12:50:05PM +0200, Greg Kroah-Hartman wrote: > > > > On Tue, May 04, 2021 at 11:19:03AM +0100, Rui Miguel Silva wrote: > > > > > The Arm MPS3 FPGA prototyping board [0] have an isp1763 [1] as USB controller. > > > > > There is already support for the isp1760 and isp1761 in tree, this series extend > > > > > the support also for the isp1763. > > > > > > > > > > Move register access using regmap, remove some platform data and code, refactor > > > > > the mempool, use dr_mode to align to existing bindings, then add the support for > > > > > isp1763 host mode, add bindings files that did not existed and at the end > > > > > add also support for peripheral mode for isp1763. > > > > > > > > > > @Laurent and @Sebastian, I add both of you in the bindings files as maintainers > > > > > (it is a mandatory field)since you were the ones which contributed with the > > > > > initial code and peripheral code, let me know if you are ok with it. > > > > > If yes I may send a follow up to add also entries in MAINTAINERS file that it is > > > > > also missing. > > > > > > > > First 3 patches now applied, feel free to rebase and resend the rest > > > > based on the review comments. > > > > > > That's a bit fast, I've just review 1/7. > > > > Let me know if you will drop the patches from your queue, or do you > > want me to send some follow up, since Laurent comments are not very > > large? > > Follow-up is fine :) Will do, thanks. ------ Cheers, Rui