mbox series

[v2,0/5] gpio: xilinx: convert to use bitmap API

Message ID 20210510194633.11943-1-andriy.shevchenko@linux.intel.com
Headers show
Series gpio: xilinx: convert to use bitmap API | expand

Message

Andy Shevchenko May 10, 2021, 7:46 p.m. UTC
The change in the series has been inspired by [1], which, I think,
can be improved. Here I present the view how it may be done.

[1]: cover.1617380819.git.syednwaris@gmail.com

In v2:
- folding followup fix into patch 4
- added Tested-by (Srinivas)
- added Ack (Yuri)
- added Rb (Michal)
- rebased on top of v5.13-rc1

Andy Shevchenko (5):
  bitmap: Make bitmap_remap() and bitmap_bitremap() available to users
  gpio: xilinx: Correct kernel doc for xgpio_probe()
  gpio: xilinx: Introduce xgpio_read_chan() / xgpio_write_chan()
  gpio: xilinx: Switch to use bitmap APIs
  gpio: xilinx: No need to disable IRQs in the handler

 drivers/gpio/gpio-xilinx.c | 385 +++++++++++++++++++------------------
 lib/bitmap.c               |   5 +-
 2 files changed, 198 insertions(+), 192 deletions(-)

Comments

Bartosz Golaszewski May 12, 2021, 11:55 a.m. UTC | #1
On Mon, May 10, 2021 at 9:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>

> The change in the series has been inspired by [1], which, I think,

> can be improved. Here I present the view how it may be done.

>

> [1]: cover.1617380819.git.syednwaris@gmail.com

>

> In v2:

> - folding followup fix into patch 4

> - added Tested-by (Srinivas)

> - added Ack (Yuri)

> - added Rb (Michal)

> - rebased on top of v5.13-rc1

>

> Andy Shevchenko (5):

>   bitmap: Make bitmap_remap() and bitmap_bitremap() available to users

>   gpio: xilinx: Correct kernel doc for xgpio_probe()

>   gpio: xilinx: Introduce xgpio_read_chan() / xgpio_write_chan()

>   gpio: xilinx: Switch to use bitmap APIs

>   gpio: xilinx: No need to disable IRQs in the handler

>

>  drivers/gpio/gpio-xilinx.c | 385 +++++++++++++++++++------------------

>  lib/bitmap.c               |   5 +-

>  2 files changed, 198 insertions(+), 192 deletions(-)

>

> --

> 2.30.2

>


Series applied, thanks a lot!

Bartosz
Linus Walleij May 19, 2021, 11:29 p.m. UTC | #2
On Mon, May 10, 2021 at 9:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Currently the bitmap_remap() and bitmap_bitremap() are available

> only for CONFIG_NUMA=y case, while some users may benefit out of it

> and being independent to NUMA code. Make them available to users

> by moving out of ifdeffery and exporting for modules.

>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Tested-by: Neeli Srinivas <sneeli@xilinx.com>

> Acked-by: Yury Norov <yury.norov@gmail.com>


This series:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>


Yours,
Linus Walleij