[RESEND,v2,00/13] Simplify + drop board file support for Samsung PMIC

Message ID 20210526124711.33223-1-krzysztof.kozlowski@canonical.com
Headers show
Series
  • Simplify + drop board file support for Samsung PMIC
Related show

Message

Krzysztof Kozlowski May 26, 2021, 12:46 p.m.
Hi Lee,

This is the resend of two previous series, combined together as the
latter depends on the first:
https://lore.kernel.org/lkml/20210420113929.278082-1-krzysztof.kozlowski@canonical.com/
https://lore.kernel.org/lkml/20210420170118.12788-1-krzysztof.kozlowski@canonical.com/

Everything rebased on latest next.

This also includes two MFD "Correct kerneldoc" patches which seems to be
still valid, even though you mentioned they were fixed.


The Samsung PMIC drivers since long time are used only on devicetree
platforms (Samsung Exynos) and there are no users with board files.

Drop the support for board files entirely and depend on OF for matching.
This makes the code smaller and simpler.

Best regards,
Krzysztof

Krzysztof Kozlowski (13):
  mfd: max8997: Simplify getting of_device_id match data
  mfd: max8998: Simplify getting of_device_id match data
  mfd: da9052: Simplify getting of_device_id match data
  mfd: da9062: Simplify getting of_device_id match data
  mfd: sec: Simplify getting of_device_id match data
  mfd: wm831x: Correct kerneldoc
  mfd: twl: Correct kerneldoc
  mfd: sec: Drop support for board files and require devicetree
  mfd: sec: Remove unused cfg_pmic_irq in platform data
  mfd: sec: Remove unused device_type in platform data
  mfd: sec: Remove unused irq_base in platform data
  mfd: sec: Enable wakeup from suspend via devicetree property
  mfd: sec: Remove unused platform data members

 drivers/mfd/Kconfig              |  1 +
 drivers/mfd/da9052-i2c.c         |  9 +---
 drivers/mfd/da9062-core.c        | 13 ++----
 drivers/mfd/max8997.c            |  9 ++--
 drivers/mfd/max8998.c            |  8 ++--
 drivers/mfd/sec-core.c           | 70 +++++---------------------------
 drivers/mfd/sec-irq.c            |  4 +-
 drivers/mfd/twl-core.c           |  4 +-
 drivers/mfd/wm831x-core.c        |  2 +-
 include/linux/mfd/samsung/core.h | 33 ---------------
 10 files changed, 29 insertions(+), 124 deletions(-)

Comments

Lee Jones May 26, 2021, 2:49 p.m. | #1
On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
65;6200;1c
> Correct kerneldoc function name to fix W=1 warning:
> 
>   drivers/mfd/wm831x-core.c:121: warning:
>     expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> 
> ---
> 
> Changes since v1:
> 1. Add Ack
> ---
>  drivers/mfd/wm831x-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This one has been fixed already:

https://lore.kernel.org/lkml/20210520120820.3465562-2-lee.jones@linaro.org/

> diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
> index bcef08f58fb3..c31809b17547 100644
> --- a/drivers/mfd/wm831x-core.c
> +++ b/drivers/mfd/wm831x-core.c
> @@ -109,7 +109,7 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg)
>  }
>  
>  /**
> - * wm831x_reg_unlock: Unlock user keyed registers
> + * wm831x_reg_lock: Unlock user keyed registers
>   *
>   * The WM831x has a user key preventing writes to particularly
>   * critical registers.  This function locks those registers,
Lee Jones June 1, 2021, 3:28 p.m. | #2
On Wed, 26 May 2021, Krzysztof Kozlowski wrote:

> Hi Lee,
> 
> This is the resend of two previous series, combined together as the
> latter depends on the first:
> https://lore.kernel.org/lkml/20210420113929.278082-1-krzysztof.kozlowski@canonical.com/
> https://lore.kernel.org/lkml/20210420170118.12788-1-krzysztof.kozlowski@canonical.com/
> 
> Everything rebased on latest next.
> 
> This also includes two MFD "Correct kerneldoc" patches which seems to be
> still valid, even though you mentioned they were fixed.
> 
> 
> The Samsung PMIC drivers since long time are used only on devicetree
> platforms (Samsung Exynos) and there are no users with board files.
> 
> Drop the support for board files entirely and depend on OF for matching.
> This makes the code smaller and simpler.
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (13):
>   mfd: max8997: Simplify getting of_device_id match data
>   mfd: max8998: Simplify getting of_device_id match data
>   mfd: da9052: Simplify getting of_device_id match data
>   mfd: da9062: Simplify getting of_device_id match data
>   mfd: sec: Simplify getting of_device_id match data
>   mfd: wm831x: Correct kerneldoc
>   mfd: twl: Correct kerneldoc
>   mfd: sec: Drop support for board files and require devicetree
>   mfd: sec: Remove unused cfg_pmic_irq in platform data
>   mfd: sec: Remove unused device_type in platform data
>   mfd: sec: Remove unused irq_base in platform data
>   mfd: sec: Enable wakeup from suspend via devicetree property
>   mfd: sec: Remove unused platform data members
> 
>  drivers/mfd/Kconfig              |  1 +
>  drivers/mfd/da9052-i2c.c         |  9 +---
>  drivers/mfd/da9062-core.c        | 13 ++----
>  drivers/mfd/max8997.c            |  9 ++--
>  drivers/mfd/max8998.c            |  8 ++--
>  drivers/mfd/sec-core.c           | 70 +++++---------------------------
>  drivers/mfd/sec-irq.c            |  4 +-
>  drivers/mfd/twl-core.c           |  4 +-
>  drivers/mfd/wm831x-core.c        |  2 +-
>  include/linux/mfd/samsung/core.h | 33 ---------------
>  10 files changed, 29 insertions(+), 124 deletions(-)

Applied all except patches 6 and 7, thanks.