[0/9] Drop ROHM BD70528 support

Message ID cover.1621937490.git.matti.vaittinen@fi.rohmeurope.com
Headers show
Series
  • Drop ROHM BD70528 support
Related show

Message

Vaittinen, Matti May 25, 2021, 10:13 a.m.
Drop ROHM BD70528 support

Unfortunately there has not been a big demand for ROHM BD70528
IC. The few users I know control PMIC from separate M4-core,
which is not running Linux. I am not aware of any users of this
Linux driver.

While I did really like this IC and writing the drivers for it,
seems like these drivers are becoming useless burden. So, I see
no point in maintaining them. Let's just drop the drivers if
there is no objections to this series. :(

Few notes:

The GPIO, regulator, power-supply and watchdog drivers should be
only used on BD70528 and depend on the BD70528 MFD Kconfig. I guess
the removal can be independently merged to the respective subsystems.

The BD70528 RTC driver is still used by BD71815 and BD71828 -
but the watchdog-hack can be removed and driver is greatly
simplified. However, it's worth noting that there is dependency
from the BD70528 RTC driver to the header files - thus the
RTC driver changes should be merged before MFD changes. Also the
CLK driver remains in use and needs the BD70528 IC-type.

As a final note - Few improvements/fixes were just applied to the
regulator tree so this series is likely to conflict. Some fixes
were also added to RTC Kconfig - which means also the RTC tree
may have conflicts. Please let me know if you wish me to rebase
this series or those patches.

---

Matti Vaittinen (9):
  dt-bindings: mfd: regulator: Drop BD70528 support
  rtc: bd70528: Drop BD70528 support
  watchdog: bd70528 drop bd70528 support
  regulator: bd70528: Drop BD70528 support
  clk: bd718xx: Drop BD70528 support
  gpio: bd70528 Drop BD70528 support
  power: supply: Drop BD70528 support
  mfd: bd70528: Drop BD70528 support
  MAINTAINERS: bd70528: Drop ROHM BD70528 drivers

 .../bindings/mfd/rohm,bd70528-pmic.txt        | 102 ---
 .../regulator/rohm,bd70528-regulator.txt      |  68 --
 MAINTAINERS                                   |   8 -
 drivers/clk/Kconfig                           |   6 +-
 drivers/clk/clk-bd718x7.c                     |  11 +-
 drivers/gpio/Kconfig                          |  11 -
 drivers/gpio/Makefile                         |   1 -
 drivers/gpio/gpio-bd70528.c                   | 230 ------
 drivers/mfd/Kconfig                           |  17 -
 drivers/mfd/Makefile                          |   1 -
 drivers/mfd/rohm-bd70528.c                    | 314 --------
 drivers/power/supply/Kconfig                  |   9 -
 drivers/power/supply/Makefile                 |   1 -
 drivers/power/supply/bd70528-charger.c        | 710 ------------------
 drivers/regulator/Kconfig                     |  11 -
 drivers/regulator/Makefile                    |   1 -
 drivers/regulator/bd70528-regulator.c         | 283 -------
 drivers/rtc/Kconfig                           |   4 +-
 drivers/rtc/rtc-bd70528.c                     | 316 +-------
 drivers/watchdog/Kconfig                      |  12 -
 drivers/watchdog/Makefile                     |   1 -
 drivers/watchdog/bd70528_wdt.c                | 291 -------
 include/linux/mfd/rohm-bd70528.h              | 391 ----------
 include/linux/mfd/rohm-generic.h              |   1 -
 24 files changed, 18 insertions(+), 2782 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
 delete mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd70528-regulator.txt
 delete mode 100644 drivers/gpio/gpio-bd70528.c
 delete mode 100644 drivers/mfd/rohm-bd70528.c
 delete mode 100644 drivers/power/supply/bd70528-charger.c
 delete mode 100644 drivers/regulator/bd70528-regulator.c
 delete mode 100644 drivers/watchdog/bd70528_wdt.c
 delete mode 100644 include/linux/mfd/rohm-bd70528.h


base-commit: c4681547bcce777daf576925a966ffa824edd09d

Comments

Vaittinen, Matti May 27, 2021, 10:35 a.m. | #1
On Tue, 2021-05-25 at 13:13 +0300, Matti Vaittinen wrote:
> Drop ROHM BD70528 support

> 

> Unfortunately there has not been a big demand for ROHM BD70528

> IC. The few users I know control PMIC from separate M4-core,

> which is not running Linux. I am not aware of any users of this

> Linux driver.

> 

> While I did really like this IC and writing the drivers for it,

> seems like these drivers are becoming useless burden. So, I see

> no point in maintaining them. Let's just drop the drivers if

> there is no objections to this series. :(

> 

> Few notes:

> 

> The GPIO, regulator, power-supply and watchdog drivers should be

> only used on BD70528 and depend on the BD70528 MFD Kconfig. I guess

> the removal can be independently merged to the respective subsystems.

> 

> The BD70528 RTC driver is still used by BD71815 and BD71828 -

> but the watchdog-hack can be removed and driver is greatly

> simplified. However, it's worth noting that there is dependency

> from the BD70528 RTC driver to the header files - thus the

> RTC driver changes should be merged before MFD changes. Also the

> CLK driver remains in use and needs the BD70528 IC-type.

> 

> As a final note - Few improvements/fixes were just applied to the

> regulator tree so this series is likely to conflict. Some fixes

> were also added to RTC Kconfig - which means also the RTC tree

> may have conflicts. Please let me know if you wish me to rebase

> this series or those patches.


As shortly discussed with Alexandre here:
https://lore.kernel.org/lkml/YKz25PDL2Z6vgqJv@piout.net/

The easiest way to drop the support without breaking the dependencies
and without introducing conflicts is to drop support from sub-devices
in one cycle and the MFD only at next cycle. So Lee, please ignore the
MFD part for now.

I'll rebase the RTC and regulator patches to RTC and regulator trees
and send them as individual patches to Mark and Alexandre. I think the
other sub-device patches and the DT bindings patch should apply cleanly
to the respective trees. Please let me know if this does not work for
you.

I'll re-spin the MFD portion during the next cycle.

Best Regards
	Matti Vaittinen