[v6,0/9] gpio-rockchip driver

Message ID 20210618062449.1067106-1-jay.xu@rock-chips.com
Headers show
Series
  • gpio-rockchip driver
Related show

Message

Jianqun Xu June 18, 2021, 6:24 a.m.
Separate gpio driver from pinctrl driver, and support gpio v2 controller.

Jianqun Xu (8):
  pinctrl/rockchip: always enable clock for gpio controller
  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
  pinctrl/rockchip: add pinctrl device to gpio bank struct
  gpio/rockchip: add driver for rockchip gpio
  gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
  gpio/rockchip: support next version gpio controller
  gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
  pinctrl/rockchip: drop the gpio related codes

Liang Chen (1):
  dt-bindings: gpio: change items restriction of clock for
    rockchip,gpio-bank

 .../bindings/gpio/rockchip,gpio-bank.yaml     |   5 +-
 drivers/gpio/Kconfig                          |   8 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-rockchip.c                  | 766 +++++++++++++++
 drivers/pinctrl/pinctrl-rockchip.c            | 911 +-----------------
 drivers/pinctrl/pinctrl-rockchip.h            | 287 ++++++
 6 files changed, 1085 insertions(+), 893 deletions(-)
 create mode 100644 drivers/gpio/gpio-rockchip.c
 create mode 100644 drivers/pinctrl/pinctrl-rockchip.h

Comments

Linus Walleij July 23, 2021, 10:07 a.m. | #1
On Fri, Jun 18, 2021 at 8:24 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Separate gpio driver from pinctrl driver, and support gpio v2 controller.

>

> Jianqun Xu (8):

>   pinctrl/rockchip: always enable clock for gpio controller

>   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file

>   pinctrl/rockchip: add pinctrl device to gpio bank struct

>   gpio/rockchip: add driver for rockchip gpio

>   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller

>   gpio/rockchip: support next version gpio controller

>   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

>   pinctrl/rockchip: drop the gpio related codes

>

> Liang Chen (1):

>   dt-bindings: gpio: change items restriction of clock for

>     rockchip,gpio-bank


I have applied the series to an immutable branch in the pinctrl tree:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-rockchip-split
Then I pulled that into devel.

Bartosz: if you want you can pull this into the GPIO tree as well
(makes it possible to continue work on drivers/gpio/gpio-rockchip.c
and avoids clashes in Kconfig and Makefile)

Yours,
Linus Walleij
Linus Walleij July 23, 2021, 10:14 a.m. | #2
On Fri, Jul 23, 2021 at 12:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Jun 18, 2021 at 8:24 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

>

> > Separate gpio driver from pinctrl driver, and support gpio v2 controller.

> >

> > Jianqun Xu (8):

> >   pinctrl/rockchip: always enable clock for gpio controller

> >   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file

> >   pinctrl/rockchip: add pinctrl device to gpio bank struct

> >   gpio/rockchip: add driver for rockchip gpio

> >   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller

> >   gpio/rockchip: support next version gpio controller

> >   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

> >   pinctrl/rockchip: drop the gpio related codes

> >

> > Liang Chen (1):

> >   dt-bindings: gpio: change items restriction of clock for

> >     rockchip,gpio-bank

>

> I have applied the series to an immutable branch in the pinctrl tree:

> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-rockchip-split

> Then I pulled that into devel.

>

> Bartosz: if you want you can pull this into the GPIO tree as well

> (makes it possible to continue work on drivers/gpio/gpio-rockchip.c

> and avoids clashes in Kconfig and Makefile)


Oops I saw there is still discussion about some of the patches
and found a bug myself. Pulled this out again and deleted the
branch.

See you again in v7 :D

Yours,
Linus Walleij
Peter Geis July 23, 2021, 1:47 p.m. | #3
On Fri, Jul 23, 2021 at 6:15 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>

> On Fri, Jul 23, 2021 at 12:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> > On Fri, Jun 18, 2021 at 8:24 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> >

> > > Separate gpio driver from pinctrl driver, and support gpio v2 controller.

> > >

> > > Jianqun Xu (8):

> > >   pinctrl/rockchip: always enable clock for gpio controller

> > >   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file

> > >   pinctrl/rockchip: add pinctrl device to gpio bank struct

> > >   gpio/rockchip: add driver for rockchip gpio

> > >   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller

> > >   gpio/rockchip: support next version gpio controller

> > >   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

> > >   pinctrl/rockchip: drop the gpio related codes

> > >

> > > Liang Chen (1):

> > >   dt-bindings: gpio: change items restriction of clock for

> > >     rockchip,gpio-bank

> >

> > I have applied the series to an immutable branch in the pinctrl tree:

> > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-rockchip-split

> > Then I pulled that into devel.

> >

> > Bartosz: if you want you can pull this into the GPIO tree as well

> > (makes it possible to continue work on drivers/gpio/gpio-rockchip.c

> > and avoids clashes in Kconfig and Makefile)

>

> Oops I saw there is still discussion about some of the patches

> and found a bug myself. Pulled this out again and deleted the

> branch.

>

> See you again in v7 :D


Good Morning,

I have a patch ready to fix loading the new gpio driver with new
device trees that are missing the named gpio banks.
This also fixes loading on the rk3568, which need this driver for gpio support.
I will rebase it to the v7 when it drops (hopefully soon).

Very Respectfully,
Peter Geis

>

> Yours,

> Linus Walleij

>

> _______________________________________________

> Linux-rockchip mailing list

> Linux-rockchip@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-rockchip