| Message ID | 20170523170336.7326-1-julien.grall@arm.com |
|---|---|
| State | Accepted |
| Commit | f4a27a000d03e121eb1a36c485049a820c395539 |
| Headers | show |
On Tue, 23 May 2017, Julien Grall wrote: > Both helpers access_ok and array_access_ok are not used on ARM. Remove > them. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > xen/include/asm-arm/guest_access.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h > index 421bca5f36..251e935597 100644 > --- a/xen/include/asm-arm/guest_access.h > +++ b/xen/include/asm-arm/guest_access.h > @@ -4,13 +4,6 @@ > #include <xen/guest_access.h> > #include <xen/errno.h> > > -/* Guests have their own comlete address space */ > -#define access_ok(addr,size) (1) > - > -#define array_access_ok(addr,count,size) \ > - (likely((count) < (~0UL / (size))) && \ > - access_ok(addr, 0 + (count) * (size))) > - > unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len); > unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, > unsigned len); > -- > 2.11.0 >
Hi Stefano, On 23/05/17 19:26, Stefano Stabellini wrote: > On Tue, 23 May 2017, Julien Grall wrote: >> Both helpers access_ok and array_access_ok are not used on ARM. Remove >> them. >> >> Signed-off-by: Julien Grall <julien.grall@arm.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> I don't see this patch in staging. Can you please apply it? Cheers, > >> --- >> xen/include/asm-arm/guest_access.h | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h >> index 421bca5f36..251e935597 100644 >> --- a/xen/include/asm-arm/guest_access.h >> +++ b/xen/include/asm-arm/guest_access.h >> @@ -4,13 +4,6 @@ >> #include <xen/guest_access.h> >> #include <xen/errno.h> >> >> -/* Guests have their own comlete address space */ >> -#define access_ok(addr,size) (1) >> - >> -#define array_access_ok(addr,count,size) \ >> - (likely((count) < (~0UL / (size))) && \ >> - access_ok(addr, 0 + (count) * (size))) >> - >> unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len); >> unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, >> unsigned len); >> -- >> 2.11.0 >>
On Tue, 6 Jun 2017, Julien Grall wrote: > Hi Stefano, > > On 23/05/17 19:26, Stefano Stabellini wrote: > > On Tue, 23 May 2017, Julien Grall wrote: > > > Both helpers access_ok and array_access_ok are not used on ARM. Remove > > > them. > > > > > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > I don't see this patch in staging. Can you please apply it? Same here. It is committed now. > > > > > --- > > > xen/include/asm-arm/guest_access.h | 7 ------- > > > 1 file changed, 7 deletions(-) > > > > > > diff --git a/xen/include/asm-arm/guest_access.h > > > b/xen/include/asm-arm/guest_access.h > > > index 421bca5f36..251e935597 100644 > > > --- a/xen/include/asm-arm/guest_access.h > > > +++ b/xen/include/asm-arm/guest_access.h > > > @@ -4,13 +4,6 @@ > > > #include <xen/guest_access.h> > > > #include <xen/errno.h> > > > > > > -/* Guests have their own comlete address space */ > > > -#define access_ok(addr,size) (1) > > > - > > > -#define array_access_ok(addr,count,size) \ > > > - (likely((count) < (~0UL / (size))) && \ > > > - access_ok(addr, 0 + (count) * (size))) > > > - > > > unsigned long raw_copy_to_guest(void *to, const void *from, unsigned > > > len); > > > unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, > > > unsigned len); > > > -- > > > 2.11.0 > > > > > -- > Julien Grall >
diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h index 421bca5f36..251e935597 100644 --- a/xen/include/asm-arm/guest_access.h +++ b/xen/include/asm-arm/guest_access.h @@ -4,13 +4,6 @@ #include <xen/guest_access.h> #include <xen/errno.h> -/* Guests have their own comlete address space */ -#define access_ok(addr,size) (1) - -#define array_access_ok(addr,count,size) \ - (likely((count) < (~0UL / (size))) && \ - access_ok(addr, 0 + (count) * (size))) - unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len); unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, unsigned len);
Both helpers access_ok and array_access_ok are not used on ARM. Remove them. Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/include/asm-arm/guest_access.h | 7 ------- 1 file changed, 7 deletions(-)