diff mbox

gpio: moxart: fix build regression

Message ID 4110228.QqTjkKaKSX@wuerfel
State New
Headers show

Commit Message

Arnd Bergmann Jan. 7, 2016, 1:55 p.m. UTC
A cleanup patch replaced bgpio_chip with gpio_chip but missed
two references to the bgpio_chip:

drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);
drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
        gc->bgpio_data = bgc->read_reg(bgc->reg_set);

This adds the missing change.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
---


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Arnd Bergmann Jan. 7, 2016, 2:03 p.m. UTC | #1
On Thursday 07 January 2016 14:55:34 Arnd Bergmann wrote:
> A cleanup patch replaced bgpio_chip with gpio_chip but missed

> two references to the bgpio_chip:

> 

> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?

>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);

> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here

> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?

>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);

> 

> This adds the missing change.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")

> ---


Adding Jonas to Cc, sorry for forgetting him first.

> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c

> index 71c13c4e12b5..ca604538ebf7 100644

> --- a/drivers/gpio/gpio-moxart.c

> +++ b/drivers/gpio/gpio-moxart.c

> @@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)

>  	gc->label = "moxart-gpio";

>  	gc->request = gpiochip_generic_request;

>  	gc->free = gpiochip_generic_free;

> -	gc->bgpio_data = bgc->read_reg(bgc->reg_set);

> +	gc->bgpio_data = gc->read_reg(gc->reg_set);

>  	gc->base = 0;

>  	gc->ngpio = 32;

>  	gc->parent = dev;

> 

> 

> _______________________________________________

> linux-arm-kernel mailing list

> linux-arm-kernel@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 7, 2016, 3:17 p.m. UTC | #2
On Thu, Jan 7, 2016 at 2:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> A cleanup patch replaced bgpio_chip with gpio_chip but missed

> two references to the bgpio_chip:

>

> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?

>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);

> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here

> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?

>         gc->bgpio_data = bgc->read_reg(bgc->reg_set);

>

> This adds the missing change.

>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")


Patch applied, sorry for the mess...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index 71c13c4e12b5..ca604538ebf7 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -57,7 +57,7 @@  static int moxart_gpio_probe(struct platform_device *pdev)
 	gc->label = "moxart-gpio";
 	gc->request = gpiochip_generic_request;
 	gc->free = gpiochip_generic_free;
-	gc->bgpio_data = bgc->read_reg(bgc->reg_set);
+	gc->bgpio_data = gc->read_reg(gc->reg_set);
 	gc->base = 0;
 	gc->ngpio = 32;
 	gc->parent = dev;