[oe] meson: don't pass localedir

Message ID 1496655970-1826-1-git-send-email-ross.burton@intel.com
State New
Headers show

Commit Message

Ross Burton June 5, 2017, 9:46 a.m.
For historic reasons the localedir directory is where binary locales are stored
(/usr/lib/locale) , not where application translations belong (typically,
/usr/share/locale).  Don't pass localedir explicitly, and let Meson use the
default of $datadir/locale to match the behaviour of autotools.bbclass and the
expectations of the system.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta-oe/classes/meson.bbclass | 1 -
 1 file changed, 1 deletion(-)

-- 
2.8.1

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Christopher Larson June 5, 2017, 7:41 p.m. | #1
On Mon, Jun 5, 2017 at 2:46 AM, Ross Burton <ross.burton@intel.com> wrote:

> For historic reasons the localedir directory is where binary locales are

> stored

> (/usr/lib/locale) , not where application translations belong (typically,

> /usr/share/locale).  Don't pass localedir explicitly, and let Meson use the

> default of $datadir/locale to match the behaviour of autotools.bbclass

> and the

> expectations of the system.

>

> Signed-off-by: Ross Burton <ross.burton@intel.com>

>


Maybe we should think about renaming that variable for clarity.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ross Burton June 6, 2017, 10:19 a.m. | #2
On 5 June 2017 at 20:41, Christopher Larson <kergoth@gmail.com> wrote:

> Maybe we should think about renaming that variable for clarity.

>


Yes.  Not sure what to though.

Ross
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/classes/meson.bbclass b/meta-oe/classes/meson.bbclass
index 0cf78e4..54b984f 100644
--- a/meta-oe/classes/meson.bbclass
+++ b/meta-oe/classes/meson.bbclass
@@ -27,7 +27,6 @@  MESONOPTS = " --prefix ${prefix} \
               --libexecdir ${@noprefix('libexecdir', d)} \
               --includedir ${@noprefix('includedir', d)} \
               --mandir ${@noprefix('mandir', d)} \
-              --localedir ${@noprefix('localedir', d)} \
               --sysconfdir ${sysconfdir}"
 
 MESON_C_ARGS = "${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}"