diff mbox series

[v2,04/11] nios2: fix timer initcall return value

Message ID 20161110164454.293477-5-arnd@arndb.de
State Superseded
Headers show
Series [v2,01/11] Kbuild: enable -Wmaybe-uninitialized warning for "make W=1" | expand

Commit Message

Arnd Bergmann Nov. 10, 2016, 4:44 p.m. UTC 
When called more than twice, the nios2_time_init() function
return an uninitialized value, as detected by gcc -Wmaybe-uninitialized

arch/nios2/kernel/time.c: warning: 'ret' may be used uninitialized in this function

This makes it return '0' here, matching the comment above the
function.

Acked-by: Ley Foon Tan <lftan@altera.com>

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/nios2/kernel/time.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0
diff mbox series

Patch

diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
index d9563dd..746bf5c 100644
--- a/arch/nios2/kernel/time.c
+++ b/arch/nios2/kernel/time.c
@@ -324,6 +324,7 @@  static int __init nios2_time_init(struct device_node *timer)
 		ret = nios2_clocksource_init(timer);
 		break;
 	default:
+		ret = 0;
 		break;
 	}