diff mbox series

[PULL,7/8] block/qcow.c: Fix memory leak in qcow_create()

Message ID 1496857819-12466-8-git-send-email-kwolf@redhat.com
State Accepted
Commit 272545cf215f183ecb84c1d0fca3fd38db806977
Headers show
Series None | expand

Commit Message

Kevin Wolf June 7, 2017, 5:50 p.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---
 block/qcow.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.8.3.1
diff mbox series

Patch

diff --git a/block/qcow.c b/block/qcow.c
index 95ab123..7bd94dc 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -852,6 +852,7 @@  static int qcow_create(const char *filename, QemuOpts *opts, Error **errp)
             header_size += backing_filename_len;
         } else {
             /* special backing file for vvfat */
+            g_free(backing_file);
             backing_file = NULL;
         }
         header.cluster_bits = 9; /* 512 byte cluster to avoid copying