| Message ID | 20170612124317.29313-2-robdclark@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 06/12, Rob Clark wrote: > From: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > Signed-off-by: Rob Clark <robdclark@gmail.com> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, Andy, On 06/12/2017 03:43 PM, Rob Clark wrote: > From: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > Signed-off-by: Rob Clark <robdclark@gmail.com> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 24c24ab..1dcd632 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -88,6 +88,13 @@ > no-map; > }; > > + venus_mem: venus@89900000 { > + compatible = "shared-dma-pool"; > + reg = <0x0 0x89900000 0x0 0x800000>; > + alignment = <0x1000>; > + no-map; > + }; In the spirit of 377a22d3caec3d2cda0cc996101121145ac43ff2 "media: venus: don't abuse dma_alloc for non-DMA allocations" commit the above venus_mem should be changed to: venus_mem: venus@89900000 { reg = <0x0 0x89900000 0x0 0x600000>; no-map; }; > + > mba_mem: mba@8ea00000 { > no-map; > reg = <0 0x8ea00000 0 0x100000>; > @@ -1214,6 +1221,27 @@ > }; > }; > }; > + > + venus: video-codec@1d00000 { > + compatible = "qcom,msm8916-venus"; > + reg = <0x01d00000 0xff000>; > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&gcc VENUS_GDSC>; > + clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, > + <&gcc GCC_VENUS0_AHB_CLK>, > + <&gcc GCC_VENUS0_AXI_CLK>; > + clock-names = "core", "iface", "bus"; > + memory-region = <&venus_mem>; > + status = "okay"; Is that correct, shouldn't the status be disabled and enabled in the board dts(i) files? > + > + video-decoder { > + compatible = "venus-decoder"; > + }; > + > + video-encoder { > + compatible = "venus-encoder"; > + }; > + }; > }; > > smd { > -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 16, 2017 at 05:31:47PM +0300, Stanimir Varbanov wrote: > Hi Rob, Andy, > > On 06/12/2017 03:43 PM, Rob Clark wrote: > > From: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > Signed-off-by: Rob Clark <robdclark@gmail.com> > > --- > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > index 24c24ab..1dcd632 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > @@ -88,6 +88,13 @@ > > no-map; > > }; > > > > + venus_mem: venus@89900000 { > > + compatible = "shared-dma-pool"; > > + reg = <0x0 0x89900000 0x0 0x800000>; > > + alignment = <0x1000>; > > + no-map; > > + }; > > In the spirit of 377a22d3caec3d2cda0cc996101121145ac43ff2 "media: venus: > don't abuse dma_alloc for non-DMA allocations" commit the above > venus_mem should be changed to: > > venus_mem: venus@89900000 { > reg = <0x0 0x89900000 0x0 0x600000>; > no-map; > }; > Ok, I'll fix this up. No need to send any update. > > + > > mba_mem: mba@8ea00000 { > > no-map; > > reg = <0 0x8ea00000 0 0x100000>; > > @@ -1214,6 +1221,27 @@ > > }; > > }; > > }; > > + > > + venus: video-codec@1d00000 { > > + compatible = "qcom,msm8916-venus"; > > + reg = <0x01d00000 0xff000>; > > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; > > + power-domains = <&gcc VENUS_GDSC>; > > + clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, > > + <&gcc GCC_VENUS0_AHB_CLK>, > > + <&gcc GCC_VENUS0_AXI_CLK>; > > + clock-names = "core", "iface", "bus"; > > + memory-region = <&venus_mem>; > > + status = "okay"; > > Is that correct, shouldn't the status be disabled and enabled in the > board dts(i) files? There isn't anything board specific for this, so it should be enabled by default. > > + > > + video-decoder { > > + compatible = "venus-decoder"; > > + }; > > + > > + video-encoder { > > + compatible = "venus-encoder"; > > + }; > > + }; > > }; > > > > smd { > > Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 24c24ab..1dcd632 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -88,6 +88,13 @@ no-map; }; + venus_mem: venus@89900000 { + compatible = "shared-dma-pool"; + reg = <0x0 0x89900000 0x0 0x800000>; + alignment = <0x1000>; + no-map; + }; + mba_mem: mba@8ea00000 { no-map; reg = <0 0x8ea00000 0 0x100000>; @@ -1214,6 +1221,27 @@ }; }; }; + + venus: video-codec@1d00000 { + compatible = "qcom,msm8916-venus"; + reg = <0x01d00000 0xff000>; + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&gcc VENUS_GDSC>; + clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, + <&gcc GCC_VENUS0_AHB_CLK>, + <&gcc GCC_VENUS0_AXI_CLK>; + clock-names = "core", "iface", "bus"; + memory-region = <&venus_mem>; + status = "okay"; + + video-decoder { + compatible = "venus-decoder"; + }; + + video-encoder { + compatible = "venus-encoder"; + }; + }; }; smd {