diff mbox series

[oe,meta-oe,5/7] hwloc: Inherit pkgconfig

Message ID 20170626053446.37959-5-raj.khem@gmail.com
State Accepted
Commit 66b88f7729d24ef2e3469fcaca172f420c4d54be
Headers show
Series [oe,meta-oe,1/7] live555: Define XLOCALE_NOT_USED for glibc too | expand

Commit Message

Khem Raj June 26, 2017, 5:34 a.m. UTC
Fixes
| checking for LIBXML2... cannot check without pkg-config
| configure: WARNING: --enable-libxml2 requested, but libxml2 was not found
| configure: error: Cannot continue

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.13.1

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Khem Raj June 26, 2017, 2:22 p.m. UTC | #1
Hi Martin


I see that you did not pick this into master-next but this patch is independent
of the other patch where you have comments to address. Although they
address same package this patch is not depening on that patch, however
that patch does depend on this one. So you can cherry pick this one regardless.

On Sun, Jun 25, 2017 at 10:34 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Fixes

> | checking for LIBXML2... cannot check without pkg-config

> | configure: WARNING: --enable-libxml2 requested, but libxml2 was not found

> | configure: error: Cannot continue

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> index 16cd507e6..1194af0d2 100644

> --- a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> +++ b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> @@ -11,7 +11,7 @@ SRC_URI = "https://www.open-mpi.org/software/${PN}/v1.11/downloads/${BP}.tar.bz2

>  SRC_URI[md5sum] = "96c34136ff416d2b13a7821c27477bed"

>  SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac90698782bb36e5504f4bac1bba2394ba14dbbad24"

>

> -inherit autotools

> +inherit autotools pkgconfig

>

>  DEPENDS += "ncurses udev zlib"

>  DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'libselinux', '', d)}"

> --

> 2.13.1

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Martin Jansa June 26, 2017, 2:24 p.m. UTC | #2
Hi Khem,

thanks for info, for some reason I haven't seen hwloc failing without
pkgconfig before.

So when it failed to apply without the PACKAGECONFIG one, I just dropped it
assuming that it's not needed now.

Will try to remember to cherry-pick this next time I'm updating master-next.

Regards,

On Mon, Jun 26, 2017 at 4:22 PM, Khem Raj <raj.khem@gmail.com> wrote:

> Hi Martin

>

>

> I see that you did not pick this into master-next but this patch is

> independent

> of the other patch where you have comments to address. Although they

> address same package this patch is not depening on that patch, however

> that patch does depend on this one. So you can cherry pick this one

> regardless.

>

> On Sun, Jun 25, 2017 at 10:34 PM, Khem Raj <raj.khem@gmail.com> wrote:

> > Fixes

> > | checking for LIBXML2... cannot check without pkg-config

> > | configure: WARNING: --enable-libxml2 requested, but libxml2 was not

> found

> > | configure: error: Cannot continue

> >

> > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > ---

> >  meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> > index 16cd507e6..1194af0d2 100644

> > --- a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> > +++ b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb

> > @@ -11,7 +11,7 @@ SRC_URI = "https://www.open-mpi.org/

> software/${PN}/v1.11/downloads/${BP}.tar.bz2

> >  SRC_URI[md5sum] = "96c34136ff416d2b13a7821c27477bed"

> >  SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac9069878

> 2bb36e5504f4bac1bba2394ba14dbbad24"

> >

> > -inherit autotools

> > +inherit autotools pkgconfig

> >

> >  DEPENDS += "ncurses udev zlib"

> >  DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux',

> 'libselinux', '', d)}"

> > --

> > 2.13.1

> >

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
index 16cd507e6..1194af0d2 100644
--- a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
+++ b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
@@ -11,7 +11,7 @@  SRC_URI = "https://www.open-mpi.org/software/${PN}/v1.11/downloads/${BP}.tar.bz2
 SRC_URI[md5sum] = "96c34136ff416d2b13a7821c27477bed"
 SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac90698782bb36e5504f4bac1bba2394ba14dbbad24"
 
-inherit autotools
+inherit autotools pkgconfig
 
 DEPENDS += "ncurses udev zlib"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'libselinux', '', d)}"