diff mbox

news: qemu platform serial devices now use -chardev

Message ID 0e36765f5b3d4394c1d42c616de7c070a30b6bff.1499722626.git.crobinso@redhat.com
State Accepted
Commit 3d52a8444bc01d8d3d1b7a38976633fcbc645d21
Headers show

Commit Message

Cole Robinson July 10, 2017, 9:38 p.m. UTC
Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 docs/news.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Andrea Bolognani July 11, 2017, 6:45 a.m. UTC | #1
On Mon, 2017-07-10 at 17:38 -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  docs/news.xml | 11 +++++++++++
>  1 file changed, 11 insertions(+)

> diff --git a/docs/news.xml b/docs/news.xml
> index f44d676c1..10faad673 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -42,6 +42,17 @@
>        </change>
>      </section>
>      <section title="Improvements">
> +      <change>
> +        <summary>
> +          qemu: arm/aarch64 serial devices can now use chardev features

I would replace "arm/aarch64" with "platform".

> +        </summary>
> +        <description>
> +          qemu VMs that depend on platform serial devices can now use
> +          qemu's -chardev option, which enables access to advanced features

Please add <code> around -chardev so that it will look
nicer on the website, and spell out QEMU all caps in
the description.


Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Cole Robinson July 12, 2017, 1:46 p.m. UTC | #2
On 07/11/2017 02:45 AM, Andrea Bolognani wrote:
> On Mon, 2017-07-10 at 17:38 -0400, Cole Robinson wrote:

>> Signed-off-by: Cole Robinson <crobinso@redhat.com>

>> ---

>>   docs/news.xml | 11 +++++++++++

>>   1 file changed, 11 insertions(+)

>>  

>> diff --git a/docs/news.xml b/docs/news.xml

>> index f44d676c1..10faad673 100644

>> --- a/docs/news.xml

>> +++ b/docs/news.xml

>> @@ -42,6 +42,17 @@

>>         </change>

>>       </section>

>>       <section title="Improvements">

>> +      <change>

>> +        <summary>

>> +          qemu: arm/aarch64 serial devices can now use chardev features

> 

> I would replace "arm/aarch64" with "platform".

> 

>> +        </summary>

>> +        <description>

>> +          qemu VMs that depend on platform serial devices can now use

>> +          qemu's -chardev option, which enables access to advanced features

> 

> Please add <code> around -chardev so that it will look

> nicer on the website, and spell out QEMU all caps in

> the description.

> 

> 


Fixed and pushed

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/docs/news.xml b/docs/news.xml
index f44d676c1..10faad673 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -42,6 +42,17 @@ 
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          qemu: arm/aarch64 serial devices can now use chardev features
+        </summary>
+        <description>
+          qemu VMs that depend on platform serial devices can now use
+          qemu's -chardev option, which enables access to advanced features
+          like log file configuration. This applies to the default serial
+          devices for arm, aarch64, and some ppc configurations.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>