| Message ID | 1499929218-1167-2-git-send-email-odpbot@yandex.ru |
|---|---|
| State | New |
| Headers | show |
| Series | [API-NEXT,v1,1/1] Adding additonal capability options to IPSEC APIs. | expand |
> -----Original Message----- > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, July 13, 2017 10:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability > options to IPSEC APIs. Typo: additional It would be better to describe the change in subject exactly: "api: ipsec: add retain header capability" > > From: Nikhil Agarwal <nikhil.agarwal@linaro.org> > > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@linaro.org> > --- > /** Email created from pull request 12 (NikhilA-Linaro:api-next) > ** https://github.com/Linaro/odp/pull/12 > ** Patch: https://github.com/Linaro/odp/pull/12.patch > ** Base sha: ee5be324411a7520528a367967c28fc529d3bc2e > ** Merge commit sha: 9707a5a9286600a44e06e0a4cb809b6f1fda0a3e > **/ > include/odp/api/spec/ipsec.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h > index e602e4b8..59272226 100644 > --- a/include/odp/api/spec/ipsec.h > +++ b/include/odp/api/spec/ipsec.h > @@ -262,12 +262,24 @@ typedef struct odp_ipsec_capability_t { > */ > odp_support_t pipeline_cls; > > + /** > + * Support of retaining outer headers (retain_outer) of > resulting > + * inbound packets > + */ > + odp_support_t retain_header; > + "Support of retaining outer headers (retain_outer) in inbound inline processed packets" This is more accurate reference to the feature than "...resulting inbound packets" > /** Maximum number of different destination CoSes in > classification > * pipelining. The same CoS may be used for many SAs. This is > equal or > * less than 'max_cos' capability in classifier API. > */ > uint32_t max_cls_cos; > > + /** Maximum number of different destination queues that can be > used as > + * IPsec destination queues. The same queue may be used for > many SAs. > + * This is equal or less than 'max_queue' capability in > classifier API. > + */ > + uint32_t max_ipsec_queues; > + This is already defined in my patch set. There's no need to refer to cls API. Implementation may set those to be equal, but it's not required by the API. -Petri
diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index e602e4b8..59272226 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -262,12 +262,24 @@ typedef struct odp_ipsec_capability_t { */ odp_support_t pipeline_cls; + /** + * Support of retaining outer headers (retain_outer) of resulting + * inbound packets + */ + odp_support_t retain_header; + /** Maximum number of different destination CoSes in classification * pipelining. The same CoS may be used for many SAs. This is equal or * less than 'max_cos' capability in classifier API. */ uint32_t max_cls_cos; + /** Maximum number of different destination queues that can be used as + * IPsec destination queues. The same queue may be used for many SAs. + * This is equal or less than 'max_queue' capability in classifier API. + */ + uint32_t max_ipsec_queues; + /** Soft expiry limit in seconds support * * 0: Limit is not supported