| Message ID | 20170714054013.34458-8-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 43022b71013e4fd992a7b381d70dea2df59de127 |
| Headers | show |
| Series | [oe,meta-initramfs,01/18] klibc: Fix build issue when default ISA is not thumb | expand |
On Fri, Jul 14, 2017 at 7:40 AM, Khem Raj <raj.khem@gmail.com> wrote: > Its unused, moreover it helps it compile with musl > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > ...ude-sys-sysctl.h-its-unused-on-linux-port.patch | 25 ++++++++++++++++++++++ > .../netload/xfce4-netload-plugin_1.3.1.bb | 3 +++ > 2 files changed, 28 insertions(+) > create mode 100644 meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch > > diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch > new file mode 100644 > index 000000000..e35418192 > --- /dev/null > +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch > @@ -0,0 +1,25 @@ > +From 7fcc7352ec11644ac8be4e9ec1584a5be3333684 Mon Sep 17 00:00:00 2001 > +From: Khem Raj <raj.khem@gmail.com> > +Date: Wed, 12 Jul 2017 18:18:30 -0700 > +Subject: [PATCH] Do not include sys/sysctl.h its unused on linux port > + > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > +--- > + panel-plugin/os.h | 1 - > + 1 file changed, 1 deletion(-) > + > +diff --git a/panel-plugin/os.h b/panel-plugin/os.h > +index 473c2a4..9a5c544 100644 > +--- a/panel-plugin/os.h > ++++ b/panel-plugin/os.h > +@@ -170,7 +170,6 @@ > + #elif __linux__ /* L I N U X */ > + # include <stdio.h> > + # include <sys/param.h> > +-# include <sys/sysctl.h> > + # include <stdlib.h> > + # include <stdarg.h> > + # include <unistd.h> > +-- > +2.13.2 > + > diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb > index 7d7778202..35c8861bc 100644 > --- a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb > +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb > @@ -5,5 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=35a7203c41b86d15546dddc05995f97f" > > inherit xfce-panel-plugin > > +SRC_URI = "http://archive.xfce.org/src/panel-plugins/${BPN}/${@'${PV}'[0:3]}/${BPN}-${PV}.tar.bz2 \ > + file://0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch \ > + " > SRC_URI[md5sum] = "f25aa3242e3119b49f259a3e4a1af08b" > SRC_URI[sha256sum] = "99762781099d1e0ab9aa6a7b30c2bd94d8f658dbe61c760410d5d42d0766391c" > -- > 2.13.2 > Please add Upstream-Status (or even better - send the xfce patches upstream) Andreas -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
On Thu, Jul 13, 2017 at 11:45 PM, Andreas Müller <schnitzeltony@googlemail.com> wrote: > On Fri, Jul 14, 2017 at 7:40 AM, Khem Raj <raj.khem@gmail.com> wrote: >> Its unused, moreover it helps it compile with musl >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> ...ude-sys-sysctl.h-its-unused-on-linux-port.patch | 25 ++++++++++++++++++++++ >> .../netload/xfce4-netload-plugin_1.3.1.bb | 3 +++ >> 2 files changed, 28 insertions(+) >> create mode 100644 meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >> >> diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >> new file mode 100644 >> index 000000000..e35418192 >> --- /dev/null >> +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >> @@ -0,0 +1,25 @@ >> +From 7fcc7352ec11644ac8be4e9ec1584a5be3333684 Mon Sep 17 00:00:00 2001 >> +From: Khem Raj <raj.khem@gmail.com> >> +Date: Wed, 12 Jul 2017 18:18:30 -0700 >> +Subject: [PATCH] Do not include sys/sysctl.h its unused on linux port >> + >> +Signed-off-by: Khem Raj <raj.khem@gmail.com> >> +--- >> + panel-plugin/os.h | 1 - >> + 1 file changed, 1 deletion(-) >> + >> +diff --git a/panel-plugin/os.h b/panel-plugin/os.h >> +index 473c2a4..9a5c544 100644 >> +--- a/panel-plugin/os.h >> ++++ b/panel-plugin/os.h >> +@@ -170,7 +170,6 @@ >> + #elif __linux__ /* L I N U X */ >> + # include <stdio.h> >> + # include <sys/param.h> >> +-# include <sys/sysctl.h> >> + # include <stdlib.h> >> + # include <stdarg.h> >> + # include <unistd.h> >> +-- >> +2.13.2 >> + >> diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >> index 7d7778202..35c8861bc 100644 >> --- a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >> +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >> @@ -5,5 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=35a7203c41b86d15546dddc05995f97f" >> >> inherit xfce-panel-plugin >> >> +SRC_URI = "http://archive.xfce.org/src/panel-plugins/${BPN}/${@'${PV}'[0:3]}/${BPN}-${PV}.tar.bz2 \ >> + file://0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch \ >> + " >> SRC_URI[md5sum] = "f25aa3242e3119b49f259a3e4a1af08b" >> SRC_URI[sha256sum] = "99762781099d1e0ab9aa6a7b30c2bd94d8f658dbe61c760410d5d42d0766391c" >> -- >> 2.13.2 >> > Please add Upstream-Status (or even better - send the xfce patches upstream) > help me upstream it > Andreas
On Fri, Jul 14, 2017 at 3:25 PM, Khem Raj <raj.khem@gmail.com> wrote: > On Thu, Jul 13, 2017 at 11:45 PM, Andreas Müller > <schnitzeltony@googlemail.com> wrote: >> On Fri, Jul 14, 2017 at 7:40 AM, Khem Raj <raj.khem@gmail.com> wrote: >>> Its unused, moreover it helps it compile with musl >>> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com> >>> --- >>> ...ude-sys-sysctl.h-its-unused-on-linux-port.patch | 25 ++++++++++++++++++++++ >>> .../netload/xfce4-netload-plugin_1.3.1.bb | 3 +++ >>> 2 files changed, 28 insertions(+) >>> create mode 100644 meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >>> >>> diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >>> new file mode 100644 >>> index 000000000..e35418192 >>> --- /dev/null >>> +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch >>> @@ -0,0 +1,25 @@ >>> +From 7fcc7352ec11644ac8be4e9ec1584a5be3333684 Mon Sep 17 00:00:00 2001 >>> +From: Khem Raj <raj.khem@gmail.com> >>> +Date: Wed, 12 Jul 2017 18:18:30 -0700 >>> +Subject: [PATCH] Do not include sys/sysctl.h its unused on linux port >>> + >>> +Signed-off-by: Khem Raj <raj.khem@gmail.com> >>> +--- >>> + panel-plugin/os.h | 1 - >>> + 1 file changed, 1 deletion(-) >>> + >>> +diff --git a/panel-plugin/os.h b/panel-plugin/os.h >>> +index 473c2a4..9a5c544 100644 >>> +--- a/panel-plugin/os.h >>> ++++ b/panel-plugin/os.h >>> +@@ -170,7 +170,6 @@ >>> + #elif __linux__ /* L I N U X */ >>> + # include <stdio.h> >>> + # include <sys/param.h> >>> +-# include <sys/sysctl.h> >>> + # include <stdlib.h> >>> + # include <stdarg.h> >>> + # include <unistd.h> >>> +-- >>> +2.13.2 >>> + >>> diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >>> index 7d7778202..35c8861bc 100644 >>> --- a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >>> +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb >>> @@ -5,5 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=35a7203c41b86d15546dddc05995f97f" >>> >>> inherit xfce-panel-plugin >>> >>> +SRC_URI = "http://archive.xfce.org/src/panel-plugins/${BPN}/${@'${PV}'[0:3]}/${BPN}-${PV}.tar.bz2 \ >>> + file://0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch \ >>> + " >>> SRC_URI[md5sum] = "f25aa3242e3119b49f259a3e4a1af08b" >>> SRC_URI[sha256sum] = "99762781099d1e0ab9aa6a7b30c2bd94d8f658dbe61c760410d5d42d0766391c" >>> -- >>> 2.13.2 >>> >> Please add Upstream-Status (or even better - send the xfce patches upstream) >> > > help me upstream it > OK - but I think the next 2-3 weeks there is no time for that Andreas
diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch new file mode 100644 index 000000000..e35418192 --- /dev/null +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch @@ -0,0 +1,25 @@ +From 7fcc7352ec11644ac8be4e9ec1584a5be3333684 Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Wed, 12 Jul 2017 18:18:30 -0700 +Subject: [PATCH] Do not include sys/sysctl.h its unused on linux port + +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + panel-plugin/os.h | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/panel-plugin/os.h b/panel-plugin/os.h +index 473c2a4..9a5c544 100644 +--- a/panel-plugin/os.h ++++ b/panel-plugin/os.h +@@ -170,7 +170,6 @@ + #elif __linux__ /* L I N U X */ + # include <stdio.h> + # include <sys/param.h> +-# include <sys/sysctl.h> + # include <stdlib.h> + # include <stdarg.h> + # include <unistd.h> +-- +2.13.2 + diff --git a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb index 7d7778202..35c8861bc 100644 --- a/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb +++ b/meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin_1.3.1.bb @@ -5,5 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=35a7203c41b86d15546dddc05995f97f" inherit xfce-panel-plugin +SRC_URI = "http://archive.xfce.org/src/panel-plugins/${BPN}/${@'${PV}'[0:3]}/${BPN}-${PV}.tar.bz2 \ + file://0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch \ + " SRC_URI[md5sum] = "f25aa3242e3119b49f259a3e4a1af08b" SRC_URI[sha256sum] = "99762781099d1e0ab9aa6a7b30c2bd94d8f658dbe61c760410d5d42d0766391c"
Its unused, moreover it helps it compile with musl Signed-off-by: Khem Raj <raj.khem@gmail.com> --- ...ude-sys-sysctl.h-its-unused-on-linux-port.patch | 25 ++++++++++++++++++++++ .../netload/xfce4-netload-plugin_1.3.1.bb | 3 +++ 2 files changed, 28 insertions(+) create mode 100644 meta-xfce/recipes-panel-plugins/netload/xfce4-netload-plugin/0001-Do-not-include-sys-sysctl.h-its-unused-on-linux-port.patch -- 2.13.2 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel