| Message ID | 1502329914-27098-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
On Thu, 10 Aug 2017, Masahiro Yamada wrote: > This function has "desc->handle_irq = handle;" a few lines above. > The second assignment is redundant. It's not as redundant as you might think. You missed to read the comment above that. See also commit 1e12c4a9393b7. Thanks, tglx
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 51ccc77f1fe0..33fa2a95d768 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -931,10 +931,8 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle, * chained interrupt. Reset it immediately because we * do know better. */ - if (type != IRQ_TYPE_NONE) { + if (type != IRQ_TYPE_NONE) __irq_set_trigger(desc, type); - desc->handle_irq = handle; - } irq_settings_set_noprobe(desc); irq_settings_set_norequest(desc);
This function has "desc->handle_irq = handle;" a few lines above. The second assignment is redundant. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- kernel/irq/chip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.7.4