From patchwork Mon Aug 14 14:23:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 110008 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp4281632obb; Mon, 14 Aug 2017 07:26:20 -0700 (PDT) X-Received: by 10.36.214.203 with SMTP id o194mr5672078itg.3.1502720780611; Mon, 14 Aug 2017 07:26:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502720780; cv=none; d=google.com; s=arc-20160816; b=UfLWCnNTzkOFA0pRzHjPObW/dPn+AFJuljw5KKwNIGao1MXdueVDTV/lWVZQ0uoz5O bHX2tUxk94fnmYys2jQgBX+S6CQmkB8dVo7WLg2BlxX+WIekG/AijYpt3F4anuqlqaCi 21RiAh1TnzN5zZ1I2ej6mu45uASFsMstByaeGTSdsWWfWKttEMzIQHaDNYlqj8bV0nab mTW/AHXXfZW5IFuGbK9UAlFjoW5mQ2Gt7VWJ4gVlUq1HROEQoJVfR8RrckV/HCVuUh+Q zx6Riwzit05uZseV/xff0/RXWp0wm1yqu5RhGWXLDIkOrmd10BJbazbnMIW/POlX4b6p 8/9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:arc-authentication-results; bh=ViCZZAX4rejmxoBY+sDu1VC+cqew6idIM4cvwgTN6Ss=; b=bXjoipTWGdrP91DrVSp7CLYMHZX0jfeVeSxGuQx3P+T71owuX+GYuZtMei/pzcVBgg 0KDEro5I+JE5+2VXTRtnOkEC01CVs2THAZ/gi5ZVj7ZAHDTQ2lBI6tIhK36pxPcvSWrD liFkTCDA6spe3z/9A9XARnqSaYGEukUGTziM+mLhaSIvXNrohsee3JfJiTndxWvxsDen IROPtBNv9Oh+9hnkXzusyEdX+gL2Url9o5UqkpfTF1rCM+2u2bf/RgNUJ0T1GhL1ABl4 fNzH7VePvkpySPAV8btCo+tMP/qrG4OyzFKYLWxvCGFKU4iK6iEui2wenS9IuCrGu3E1 oxEA== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id y144si7144632iof.216.2017.08.14.07.26.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2017 07:26:20 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGIG-0000CC-Ql; Mon, 14 Aug 2017 14:24:36 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGIF-0000Ae-UY for xen-devel@lists.xen.org; Mon, 14 Aug 2017 14:24:36 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id E5/21-22472-3A2B1995; Mon, 14 Aug 2017 14:24:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRWlGSWpSXmKPExsVysyfVTXfRpom RBlf3alks+biYxYHR4+ju30wBjFGsmXlJ+RUJrBm/v01jKjjNVvFw4ga2BsbTrF2MXBxCApsZ JRaub2KHcE4zSrRevA3kcHKwCWhK3Pn8iQnEFhGQlrj2+TIjSBGzwHJGiQ37V4AVCQt4Ssxuv 8YIYrMIqEq8PXYHzOYVsJRYfvAYG4gtISAvsavtIiuIzSlgJdF5dycLiC0EVHNi9Wy2CYzcCx gZVjFqFKcWlaUW6RoZ6SUVZaZnlOQmZuboGhoY6+WmFhcnpqfmJCYV6yXn525iBPq4noGBcQf j1BN+hxglOZiURHkTfHojhfiS8lMqMxKLM+KLSnNSiw8xynBwKEnw3tg4MVJIsCg1PbUiLTMH GGwwaQkOHiUR3lkgad7igsTc4sx0iNQpRmOOpg9bvjBxvJrw/xuTEEtefl6qlDhvOUipAEhpR mke3CBYFFxilJUS5mVkYGAQ4ilILcrNLEGVf8UozsGoJMxbCTKFJzOvBG7fK6BTmIBO6QP5gr e4JBEhJdXAmK9lfPDM+9hNZ3Rnz39ak1z/TuPalO5lz99VtjDlBO3q5NjyTp+9T+yUzL5C68R b+++3pV6oOnLjZWiKzOfZl0LmzfjBzzMhY/WNbH+R8w1SLOaLn0S8+soh9cu6etkmsZ0nVTyE Km4nnHZd4KVsx5JTUdudoflH6Omf6msH7BSEHmfMzK1KVmIpzkg01GIuKk4EANYmj9B9AgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1502720674!109784799!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 45832 invoked from network); 14 Aug 2017 14:24:34 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-14.tower-31.messagelabs.com with SMTP; 14 Aug 2017 14:24:34 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEA92164F; Mon, 14 Aug 2017 07:24:32 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBEB13F483; Mon, 14 Aug 2017 07:24:31 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Mon, 14 Aug 2017 15:23:53 +0100 Message-Id: <20170814142418.13267-3-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170814142418.13267-1-julien.grall@arm.com> References: <20170814142418.13267-1-julien.grall@arm.com> Cc: andre.przywara@arm.com, Julien Grall , sstabellini@kernel.org, Jan Beulich , Andrew Cooper Subject: [Xen-devel] [PATCH 02/27] xen/x86: srat: Don't check alloc_boot_pages return X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" alloc_boot_pages will panic if it is not possible to allocate. So the check in the caller is pointless. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/srat.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index cd1283e58c..95660a9bbc 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -194,11 +194,6 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) return; } mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); - if (!mfn) { - printk(KERN_ERR "ACPI: Unable to allocate memory for " - "saving ACPI SLIT numa information.\n"); - return; - } acpi_slit = mfn_to_virt(mfn); memcpy(acpi_slit, slit, slit->header.length); }