| Message ID | 20170823134406.1023727-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@arndb.de> wrote: > We get a compile error without it, at least in some configurations: > > kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input > > Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Oh, how completely strange. I never saw this in my build testing. If you have the .config that tripped this, please let me know. James, can you take this for -next please? Acked-by: Kees Cook <keescook@chromium.org> Thanks! -Kees > --- > kernel/seccomp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/seccomp.c b/kernel/seccomp.c > index c24579dfa7a1..3eeb2257bd62 100644 > --- a/kernel/seccomp.c > +++ b/kernel/seccomp.c > @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void) > return 0; > } > > -device_initcall(seccomp_sysctl_init) > +device_initcall(seccomp_sysctl_init); > > #endif /* CONFIG_SYSCTL */ > -- > 2.9.0 > -- Kees Cook Pixel Security
On 08/23/2017 11:20 AM, Kees Cook wrote: > On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@arndb.de> wrote: >> We get a compile error without it, at least in some configurations: >> >> kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input >> >> Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Oh, how completely strange. I never saw this in my build testing. If > you have the .config that tripped this, please let me know. Same here... Thanks for the fix, Arnd! Tyler > > James, can you take this for -next please? > > Acked-by: Kees Cook <keescook@chromium.org> > > Thanks! > > -Kees > >> --- >> kernel/seccomp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/seccomp.c b/kernel/seccomp.c >> index c24579dfa7a1..3eeb2257bd62 100644 >> --- a/kernel/seccomp.c >> +++ b/kernel/seccomp.c >> @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void) >> return 0; >> } >> >> -device_initcall(seccomp_sysctl_init) >> +device_initcall(seccomp_sysctl_init); >> >> #endif /* CONFIG_SYSCTL */ >> -- >> 2.9.0 >> > > >
diff --git a/kernel/seccomp.c b/kernel/seccomp.c index c24579dfa7a1..3eeb2257bd62 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void) return 0; } -device_initcall(seccomp_sysctl_init) +device_initcall(seccomp_sysctl_init); #endif /* CONFIG_SYSCTL */
We get a compile error without it, at least in some configurations: kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/seccomp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0