| Message ID | 20171004102823.1887173-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | e42eef4ba38806b18c4a74f0c276fb2e0b548173 |
| Headers | show |
| Series | KVM: add X86_LOCAL_APIC dependency | expand |
2017-10-04 12:28+0200, Arnd Bergmann: > The rework of the posted interrupt handling broke building without > support for the local APIC: > > ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined! > > That configuration is probably not particularly useful anyway, so > we can avoid the randconfig failures by adding a Kconfig dependency. Yeah, and we can follow up by removing few ifdefs. > Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts") The offending cpu_physical_id() was there even before, so it is probably the change of condition in pi_post_block that violated dead code detection. > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Applied, thanks.
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig index 3ea624452f93..3c48bc8bf08c 100644 --- a/arch/x86/kvm/Kconfig +++ b/arch/x86/kvm/Kconfig @@ -23,6 +23,7 @@ config KVM depends on HIGH_RES_TIMERS # for TASKSTATS/TASK_DELAY_ACCT: depends on NET && MULTIUSER + depends on X86_LOCAL_APIC select PREEMPT_NOTIFIERS select MMU_NOTIFIER select ANON_INODES
The rework of the posted interrupt handling broke building without support for the local APIC: ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined! That configuration is probably not particularly useful anyway, so we can avoid the randconfig failures by adding a Kconfig dependency. Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/x86/kvm/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0