[Xen-devel,4/7] xen/kimage: Remove defined but unused variables

Message ID 20171004181526.9405-5-julien.grall@linaro.org
State Superseded
Headers show
Series
  • xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN
Related show

Commit Message

Julien Grall Oct. 4, 2017, 6:15 p.m.
In the function kimage_alloc_normal_control_page, the variables mfn and
emfn are defined but not used. Remove them.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---

Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/common/kimage.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andrew Cooper Oct. 4, 2017, 10:42 p.m. | #1
On 04/10/2017 19:15, Julien Grall wrote:
> In the function kimage_alloc_normal_control_page, the variables mfn and
> emfn are defined but not used. Remove them.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Oops.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Patch

diff --git a/xen/common/kimage.c b/xen/common/kimage.c
index ebc71affd1..07587896a4 100644
--- a/xen/common/kimage.c
+++ b/xen/common/kimage.c
@@ -310,14 +310,11 @@  static struct page_info *kimage_alloc_normal_control_page(
      * destination page.
      */
     do {
-        unsigned long mfn, emfn;
         paddr_t addr, eaddr;
 
         page = kimage_alloc_zeroed_page(memflags);
         if ( !page )
             break;
-        mfn   = page_to_mfn(page);
-        emfn  = mfn + 1;
         addr  = page_to_maddr(page);
         eaddr = addr + PAGE_SIZE;
         if ( kimage_is_destination_range(image, addr, eaddr) )