diff mbox series

[BUG] get_maintainers: Inconsistent behavior on multiple runs

Message ID CAKohpoknWcxnrgTQUBFR5eEpbcs_=BbsjKUuzKJVqx3QFXv7AQ@mail.gmail.com
State New
Headers show
Series [BUG] get_maintainers: Inconsistent behavior on multiple runs | expand

Commit Message

Viresh Kumar Oct. 5, 2017, 6:51 a.m. UTC 
Hi Joe,

Recently I was Cc'd for some of the patches from Manu, as
get_maintainers incorrectly mentioned me.

Apart from the fact that I never contributed to the mentioned
file (drivers/phy/qualcomm/phy-qcom-qmp.c), the behavior (output)
of get_maintainers changes on multiple runs. I tried following tests on
pm/linux-next branch today (should be same on any of the latest -rc
releases). There was no difference in the environment between the
two runs.

$ scripts/get_maintainer.pl drivers/phy/qualcomm/phy-qcom-qmp.c
Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY
FRAMEWORK,commit_signer:7/7=100%)
Vivek Gautam <vivek.gautam@codeaurora.org>
(commit_signer:5/7=71%,authored:3/7=43%)
Varadarajan Narayanan <varada@codeaurora.org>
(commit_signer:2/7=29%,authored:2/7=29%)
Fengguang Wu <fengguang.wu@intel.com> (commit_signer:1/7=14%,authored:1/7=14%)
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> (commit_signer:1/7=14%)
Wei Yongjun <weiyongjun1@huawei.com> (authored:1/7=14%)
linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK)

$ scripts/get_maintainer.pl drivers/phy/qualcomm/phy-qcom-qmp.c
Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY
FRAMEWORK,commit_signer:7/7=100%)
Vivek Gautam <vivek.gautam@codeaurora.org>
(commit_signer:5/7=71%,authored:3/7=43%)
Varadarajan Narayanan <varada@codeaurora.org>
(commit_signer:2/7=29%,authored:2/7=29%)
Krzysztof Kozlowski <krzk@kernel.org> (commit_signer:1/7=14%)
Viresh Kumar <viresh.kumar@linaro.org> (commit_signer:1/7=14%)
Wei Yongjun <weiyongjun1@huawei.com> (authored:1/7=14%)
Fengguang Wu <fengguang.wu@intel.com> (authored:1/7=14%)
linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK)

The second one incorrectly adds me to the list. Also the order of entries
is different, not sure if it should be.

The same inconsistency is seen while running on the real patch (attached).

$ scripts/get_maintainer.pl ~/Downloads/original_msg.txt
Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY
FRAMEWORK,commit_signer:7/7=100%)
Vivek Gautam <vivek.gautam@codeaurora.org>
(commit_signer:5/7=71%,authored:3/7=43%)
Varadarajan Narayanan <varada@codeaurora.org>
(commit_signer:2/7=29%,authored:2/7=29%)
Heiko Stuebner <heiko@sntech.de> (commit_signer:1/7=14%)
Jaehoon Chung <jh80.chung@samsung.com> (commit_signer:1/7=14%)
Wei Yongjun <weiyongjun1@huawei.com> (authored:1/7=14%)
Fengguang Wu <fengguang.wu@intel.com> (authored:1/7=14%)
linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK)

$ scripts/get_maintainer.pl ~/Downloads/original_msg.txt
Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY
FRAMEWORK,commit_signer:7/7=100%)
Vivek Gautam <vivek.gautam@codeaurora.org>
(commit_signer:5/7=71%,authored:3/7=43%)
Varadarajan Narayanan <varada@codeaurora.org>
(commit_signer:2/7=29%,authored:2/7=29%)
Viresh Kumar <viresh.kumar@linaro.org> (commit_signer:1/7=14%)
Fengguang Wu <fengguang.wu@intel.com> (commit_signer:1/7=14%,authored:1/7=14%)
Wei Yongjun <weiyongjun1@huawei.com> (authored:1/7=14%)
linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK)

I have no clue on why this happened and so including you in the chain :)

--
viresh
Delivered-To: viresh.linux@gmail.com
Received: by 10.2.180.65 with SMTP id w1csp4538366jaj;
        Wed, 27 Sep 2017 02:11:06 -0700 (PDT)
X-Google-Smtp-Source: AOwi7QBZHaq0V0J8uYgB6DJBV4OJ/tEj+pmXv8bkLSVUA7XIcqkCZM9kqacUKqBEIg1BV/1tMLzl
X-Received: by 10.99.112.94 with SMTP id a30mr743393pgn.304.1506503465989;
        Wed, 27 Sep 2017 02:11:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1506503465; cv=none;
        d=google.com; s=arc-20160816;
        b=NTa1mneBllPtaQJbVq0uet/5ZYb5Oz45j+a+dDl90NOSX1X79hWkv89/ncoXZ2AZtC
         lMbUOPmxImLC6+CLLR0b8FfihuWFDqZjRRv55oRzib7xZDgyACBw1jOYRnc8bdSRHcrK
         tM5riVWhTxHmkPkEU80miKHqY7DZj0olBa9iur6rJoW46bzsxZaZiWKxFdNHLYaJziOb
         6TVzUCKTVLYjvimSGpTMhY5YZbjTuAkx32C4YJVINDOZ5SbI3MnOMuVqHA7sSgg/qPCf
         1oxoZsSZ8ZvKinLiSQzLsKty+2fhvuYu0lcav+jvSdAg3rO6ntMiNQ62SfpvH5CMAvSN
         c0jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:references:in-reply-to:message-id:date
         :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature
         :arc-authentication-results;
        bh=nHZTbxWXg77oeyRzx8iNby04MJyxMIzRrg6dKzeoq0Q=;
        b=eyKuJmHJkeU5rO0IRFJ0HFtYPOmLMHbGgIxSHsfPd+xU7XJsWvHc/+ijmK04ldyTff
         P0sBsot2vbwpreWW348nxcFjfKVit9AnRU21sX54LwsZVssBJfN/97LFjuIkXKPaYY5P
         0aHB0g4qp8cDrjxG8Mk9sQtAoMoAetbfTbqk4PB6fhlsPLDT9vzTNTLS5qL2ZJtNJJ4n
         tNJqziKUH2GAXWNoX02/LFJDiTgNteID0mCHvw4jBpd6SCrWL/oVxMMau8zm8vmT0qze
         mkIFpV6iyYN9ouuYg1FFWWjkuCHPrb0srt3lbyUncbk5z1AmLaXd6ApzVuXiPBSIj2lL
         xJKg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=VxUZlWdu;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=XwfEIRXT;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id y7si6995567pln.60.2017.09.27.02.10.53;
        Wed, 27 Sep 2017 02:11:05 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=VxUZlWdu;
       dkim=pass header.i=@codeaurora.org header.s=default header.b=XwfEIRXT;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752601AbdI0JAB (ORCPT <rfc822;thornbird.kernel@gmail.com>
        + 99 others); Wed, 27 Sep 2017 05:00:01 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:49970 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752339AbdI0I74 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 04:59:56 -0400
Received: by smtp.codeaurora.org (Postfix, from userid 1000)
        id 0AE3560B7C; Wed, 27 Sep 2017 08:59:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;
        s=default; t=1506502796;
        bh=B7w2C0LJ42VFqs35ImnVN3C/Y7sW+Iq2EvkrT2orw7w=;
        h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
        b=VxUZlWdu5WKitSofZt2Nmi3hPnnBsUeWisxrMMu8KJdpqUy+bGXpP0NN7lJaOoBMh
         /0TXSumyMktCryFxLR2ScsY6034Eqf8sG9zXJpE3nM4IRFkm1FKhTq3gdmvtRiS23j
         FQwFXHrlEuSmWCdjdip1B/pj/yhhuZ51uKdzT/oI=
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
        pdx-caf-mail.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,
        DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0
Received: from mgautam-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))
        (No client certificate requested)
        (Authenticated sender: mgautam@smtp.codeaurora.org)
        by smtp.codeaurora.org (Postfix) with ESMTPSA id 1E0336071D;
        Wed, 27 Sep 2017 08:59:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;
        s=default; t=1506502794;
        bh=B7w2C0LJ42VFqs35ImnVN3C/Y7sW+Iq2EvkrT2orw7w=;
        h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
        b=XwfEIRXTiizYBhJL7sCP6QgMzVw7Px5Tnt2DPRhjwhgIvaPm4c1Mp3b1g+Jcuk2kb
         fYZAWFJq4oxALlAQ8HSE6mI+Bt1D6aVg4Zd8ayn6hAFuWNkWy9FN4HfGeki01lskgi
         5GlY0j3UVOoNVKjhloYBzNRGZbuX4ntR2vnv1Xss=
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1E0336071D
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org
From:   Manu Gautam <mgautam@codeaurora.org>

To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Felipe Balbi <balbi@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-usb@vger.kernel.org,
        Vivek Gautam <vivek.gautam@codeaurora.org>,
        Manu Gautam <mgautam@codeaurora.org>,
        Varadarajan Narayanan <varada@codeaurora.org>,
        Fengguang Wu <fengguang.wu@intel.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK)
Subject: [PATCH v2 02/17] phy: qcom-qmp: Adapt to clk_bulk_* APIs
Date:   Wed, 27 Sep 2017 14:28:58 +0530
Message-Id: <1506502753-27408-3-git-send-email-mgautam@codeaurora.org>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <1506502753-27408-1-git-send-email-mgautam@codeaurora.org>
References: <1506502753-27408-1-git-send-email-mgautam@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Vivek Gautam <vivek.gautam@codeaurora.org>


Move from using array of clocks to clk_bulk_* APIs that
are available now.

Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>

Signed-off-by: Manu Gautam <mgautam@codeaurora.org>

---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 50 ++++++++++++-------------------------
 1 file changed, 16 insertions(+), 34 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Comments

Joe Perches Oct. 5, 2017, 11:41 a.m. UTC | #1 
On Thu, 2017-10-05 at 12:21 +0530, Viresh Kumar wrote:
> Hi Joe,


Hi Viresh.

> Recently I was Cc'd for some of the patches from Manu, as

> get_maintainers incorrectly mentioned me.

> 

> Apart from the fact that I never contributed to the mentioned

> file (drivers/phy/qualcomm/phy-qcom-qmp.c), the behavior (output)

> of get_maintainers changes on multiple runs. I tried following tests on

> pm/linux-next branch today (should be same on any of the latest -rc

> releases). There was no difference in the environment between the

> two runs.


Here's an explanation of the behavior

https://lkml.org/lkml/2017/7/13/789
diff mbox series

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 76acaec..90794dd 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -555,7 +555,7 @@  struct qcom_qmp {
 	struct device *dev;
 	void __iomem *serdes;
 
-	struct clk **clks;
+	struct clk_bulk_data *clks;
 	struct reset_control **resets;
 	struct regulator_bulk_data *vregs;
 
@@ -848,22 +848,19 @@  static int qcom_qmp_phy_init(struct phy *phy)
 	void __iomem *pcs = qphy->pcs;
 	void __iomem *status;
 	unsigned int mask, val;
-	int ret, i;
+	int ret;
 
 	dev_vdbg(qmp->dev, "Initializing QMP phy\n");
 
-	for (i = 0; i < qmp->cfg->num_clks; i++) {
-		ret = clk_prepare_enable(qmp->clks[i]);
-		if (ret) {
-			dev_err(qmp->dev, "failed to enable %s clk, err=%d\n",
-				qmp->cfg->clk_list[i], ret);
-			goto err_clk;
-		}
+	ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
+	if (ret) {
+		dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+		return ret;
 	}
 
 	ret = qcom_qmp_phy_com_init(qmp);
 	if (ret)
-		goto err_clk;
+		goto err_com_init;
 
 	if (cfg->has_lane_rst) {
 		ret = reset_control_deassert(qphy->lane_rst);
@@ -918,9 +915,8 @@  static int qcom_qmp_phy_init(struct phy *phy)
 		reset_control_assert(qphy->lane_rst);
 err_lane_rst:
 	qcom_qmp_phy_com_exit(qmp);
-err_clk:
-	while (--i >= 0)
-		clk_disable_unprepare(qmp->clks[i]);
+err_com_init:
+	clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks);
 
 	return ret;
 }
@@ -930,7 +926,6 @@  static int qcom_qmp_phy_exit(struct phy *phy)
 	struct qmp_phy *qphy = phy_get_drvdata(phy);
 	struct qcom_qmp *qmp = qphy->qmp;
 	const struct qmp_phy_cfg *cfg = qmp->cfg;
-	int i = cfg->num_clks;
 
 	clk_disable_unprepare(qphy->pipe_clk);
 
@@ -948,8 +943,7 @@  static int qcom_qmp_phy_exit(struct phy *phy)
 
 	qcom_qmp_phy_com_exit(qmp);
 
-	while (--i >= 0)
-		clk_disable_unprepare(qmp->clks[i]);
+	clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks);
 
 	return 0;
 }
@@ -998,29 +992,17 @@  static int qcom_qmp_phy_reset_init(struct device *dev)
 static int qcom_qmp_phy_clk_init(struct device *dev)
 {
 	struct qcom_qmp *qmp = dev_get_drvdata(dev);
-	int ret, i;
+	int num = qmp->cfg->num_clks;
+	int i;
 
-	qmp->clks = devm_kcalloc(dev, qmp->cfg->num_clks,
-				 sizeof(*qmp->clks), GFP_KERNEL);
+	qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL);
 	if (!qmp->clks)
 		return -ENOMEM;
 
-	for (i = 0; i < qmp->cfg->num_clks; i++) {
-		struct clk *_clk;
-		const char *name = qmp->cfg->clk_list[i];
-
-		_clk = devm_clk_get(dev, name);
-		if (IS_ERR(_clk)) {
-			ret = PTR_ERR(_clk);
-			if (ret != -EPROBE_DEFER)
-				dev_err(dev, "failed to get %s clk, %d\n",
-					name, ret);
-			return ret;
-		}
-		qmp->clks[i] = _clk;
-	}
+	for (i = 0; i < num; i++)
+		qmp->clks->id = qmp->cfg->clk_list[i];
 
-	return 0;
+	return devm_clk_bulk_get(dev, num, qmp->clks);
 }
 
 /*