From patchwork Mon Oct 9 16:59:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 115278 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2772463qgn; Mon, 9 Oct 2017 10:00:55 -0700 (PDT) X-Google-Smtp-Source: AOwi7QAVoJiE/loeLEQH2F3QkzwrA9nNyK6Z/S1mztYSbFK2VJsOPjbdVau0tvDaF3vWwFcQh7G6 X-Received: by 10.84.179.165 with SMTP id b34mr9467423plc.15.1507568455609; Mon, 09 Oct 2017 10:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507568455; cv=none; d=google.com; s=arc-20160816; b=wwerX38sTiUHsqaWateKEfD2JOnwu+pvfOobI7ZrPUktQ4sfG97xqHKaqdCc+ET1yp 7qXbWRoL4dRMfF87e5bguB+6S5rbctWF0dvXew+itV34bHlcho73CBe8vU7GjAjGKve4 7vY/JuxhUwVScR2FeQr3bNXQH4PubNClidTAVag0B6j4N0XAtt7ZUbdNIkttOoOPwAtF nMmGwzA5e3vlqGO5SbxouhVOlR7vMqAq770HgQx5GFpzNvcxBFmPdp3++PayB1Z8/Uoq hijMfY6Ld0NNA9qCODgt+J3SzrcKGwUgp+kNSxImZQ2IAqMl7Eu10nbCSvh4H7fBuj2f pjWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=XKo3fsDwMAdt/niJxeMAKDx/3nuIhU3K6iXaNa3c46s=; b=0ktDhAqtJSKgkRwmkgXoQpWh1bi1qqnJZj8yGKQqVoLlOlKDQIcULv1XrKcNivgqEp dPTBSdqt9BzbAK08kjBg/5QlMqzoRlrb9pRSwfSJanC2u0fsj9fFftqtx5IShedyWqxH MKXYgSwG0KRl+s8rbwIETtbroSDP6g1M0uEv0WISEOlxsMYMJtgkLfe38Ixz30xBB9HO 7yzfFgbphE6p/60JAH9MVFoOQoewbxXS+Z7yJsknVGJPRdc23fSmQZxeAgT3+aZ8beXE OcKhRgcOn0zEpXpMQIhI0WB8jG1JEtpWCZO1pkjrwN1LAEnSdwudTCTVRffCwu/JNhCV Y8+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=atXBdbWo; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u131si6358968pgc.272.2017.10.09.10.00.55; Mon, 09 Oct 2017 10:00:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=atXBdbWo; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754381AbdJIRAx (ORCPT + 8 others); Mon, 9 Oct 2017 13:00:53 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:60291 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754049AbdJIRAw (ORCPT ); Mon, 9 Oct 2017 13:00:52 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v99GxinD020389; Mon, 9 Oct 2017 11:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1507568384; bh=f/4Rva1dMFtGUvGeQd77eNgnsge+p9bbikyCbO+ME0Q=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=atXBdbWoOk1C5FcPg1QkyC4W7kZ97+ykQh6ncaWx2DlAbLMmZxRoV0HUdz4D7P3i5 q1MQV3TnDAb0p1iWXi4EcBkAkKVQH5v5uC0GkmIifZW//evfd9VlYsyf0FN2GdTkC/ /RsP/4Sp6VPHg4Le44ptyHbre5z15d4qiZO8Wzks= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v99Gxd15019938; Mon, 9 Oct 2017 11:59:39 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Mon, 9 Oct 2017 11:59:39 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Mon, 9 Oct 2017 11:59:39 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v99Gxdmw012128; Mon, 9 Oct 2017 11:59:39 -0500 Received: from localhost ([172.22.136.90]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id v99Gxc313277; Mon, 9 Oct 2017 11:59:39 -0500 (CDT) From: Dan Murphy To: , CC: , , , Dan Murphy Subject: [PATCH v4 2/2] net: phy: at803x: Change error to EINVAL for invalid MAC Date: Mon, 9 Oct 2017 11:59:34 -0500 Message-ID: <20171009165934.12671-2-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20171009165934.12671-1-dmurphy@ti.com> References: <20171009165934.12671-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy --- v4 - Updated $subject to include the part number - https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html v3 - No changes made v2 - There was no v1 on this patch this is new. drivers/net/phy/at803x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.0 diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index c1e52b9dc58d..5f93e6add563 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -167,7 +167,7 @@ static int at803x_set_wol(struct phy_device *phydev, mac = (const u8 *) ndev->dev_addr; if (!is_valid_ether_addr(mac)) - return -EFAULT; + return -EINVAL; for (i = 0; i < 3; i++) { phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,