From patchwork Mon Oct 9 18:28:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 115284 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2862447qgn; Mon, 9 Oct 2017 11:30:55 -0700 (PDT) X-Google-Smtp-Source: AOwi7QC87z5+F/nePZ5cedGr//FvDy400jpBxo0X7kh1K5Tzl/vY9zpcxi6ILECE07+29Bx+yhkS X-Received: by 10.84.248.152 with SMTP id q24mr9534161pll.75.1507573855176; Mon, 09 Oct 2017 11:30:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507573855; cv=none; d=google.com; s=arc-20160816; b=zBnfyyEVi03FUynoanUkn6xlTeY9FJcoEtYwOkMTfAgNThj4A/dF7zzIpBc1xgtWhm xVW+3/PXvis3MjWFUl4K8BeAFZ1BjhOX+cxOy5h5sO3j05nLdUa/isfo6paPKZZsFWSc v7DWsymAjhZLPo870u+IgEowavnk5lngkGDYE4w107HVdiPc02pjxHIxCN2h/6kt3R+P O9Xad1LwBpdO6vh0zAUY6NpBfRtMFtRVv/lNCAguUAFfm5xWkbGg+UdYFeEA1F1dQYfh qFTh98bCRvtrZduo/6YA+5KosHTyJ7N118RKxbF4equ3kkgqiovCYQwZTs7l7kB0zGQb Ua4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=xaj//vOUy7O9OuG4yN7+O5NG8ODdK2sRoQuxKhDHKEw=; b=uNP7TDdES8j+/M19BJioE47PtrZb6iTohnPrMnHhOZ4H787DTGfIx7U78ruiBCm4/9 e+yC2S5RUYMYyjBDokIXMIg1LvHkTklZCTbjRggrkX1MVhcGV62F8lgWB8kA7YKCpMfF VRjVUhh1J1QyhqD3qfNZnnaMnP82zxGMdUGT2Gv3pK7Uo5DNf0oo8hg+IZH3+OSkh5CX y6Ygjd2A8jL5a1IT7of1qBokxS1T9QUWvnRvB4cAh9QLb4DQAZo4ozNBMkz41nQW9fM+ tnI3R4NzUwBVAyXX9rwZgvwro/xwU+4Q1RljyQiliVeh++gBIvzYmANIjIkVoFcapZsu 6uZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e72si7432058pfm.35.2017.10.09.11.30.54; Mon, 09 Oct 2017 11:30:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755301AbdJISaw (ORCPT + 26 others); Mon, 9 Oct 2017 14:30:52 -0400 Received: from foss.arm.com ([217.140.101.70]:33776 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246AbdJISas (ORCPT ); Mon, 9 Oct 2017 14:30:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D047E15AD; Mon, 9 Oct 2017 11:30:47 -0700 (PDT) Received: from leverpostej.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E5AD03F483; Mon, 9 Oct 2017 11:30:46 -0700 (PDT) From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: Mark Rutland , Alexander Viro , Petr Vandrovec Subject: [PATCH 05/13] fs: ncpfs: kill off ACCESS_ONCE() Date: Mon, 9 Oct 2017 19:28:42 +0100 Message-Id: <1507573730-8083-6-git-send-email-mark.rutland@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507573730-8083-1-git-send-email-mark.rutland@arm.com> References: <1507573730-8083-1-git-send-email-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The NCPFS code has some stale comments regarding ACCESS_ONCE() uses which were removed a long time ago. Let's remove the stale comments. Signed-off-by: Mark Rutland Cc: Alexander Viro Cc: Petr Vandrovec --- fs/ncpfs/dir.c | 9 --------- 1 file changed, 9 deletions(-) -- 1.9.1 diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 088f524..72cfaa2 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -119,10 +119,6 @@ static inline int ncp_case_sensitive(const struct inode *i) /* * Note: leave the hash unchanged if the directory * is case-sensitive. - * - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. */ static int ncp_hash_dentry(const struct dentry *dentry, struct qstr *this) @@ -147,11 +143,6 @@ static inline int ncp_case_sensitive(const struct inode *i) return 0; } -/* - * Accessing the parent inode can be racy under RCU pathwalking. - * Use ACCESS_ONCE() to make sure we use _one_ particular inode, - * the callers will handle races. - */ static int ncp_compare_dentry(const struct dentry *dentry, unsigned int len, const char *str, const struct qstr *name)