diff mbox series

kconfig: kill off GENERIC_IO option

Message ID 20171016221631.23472-1-robh@kernel.org
State Accepted
Commit 9de8da47742b22ddec872a4dff5bd7caec98e5ba
Headers show
Series kconfig: kill off GENERIC_IO option | expand

Commit Message

Rob Herring (Arm) Oct. 16, 2017, 10:16 p.m. UTC
The GENERIC_IO option is set for every architecture except tile and score
as those define NO_IOMEM. The option only controls visibility of
CONFIG_MTD which doesn't appear to be necessary for any reason, so let's
just remove GENERIC_IO.

Signed-off-by: Rob Herring <robh@kernel.org>

Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: user-mode-linux-user@lists.sourceforge.net
Cc: linux-mtd@lists.infradead.org
---
 arch/um/Kconfig.common | 1 -
 drivers/mtd/Kconfig    | 1 -
 lib/Kconfig            | 4 ----
 3 files changed, 6 deletions(-)

-- 
2.11.0

Comments

Richard Weinberger Oct. 16, 2017, 10:23 p.m. UTC | #1
Am Dienstag, 17. Oktober 2017, 00:16:31 CEST schrieb Rob Herring:
> The GENERIC_IO option is set for every architecture except tile and score

> as those define NO_IOMEM. The option only controls visibility of

> CONFIG_MTD which doesn't appear to be necessary for any reason, so let's

> just remove GENERIC_IO.

> 

> Signed-off-by: Rob Herring <robh@kernel.org>

> Cc: Jeff Dike <jdike@addtoit.com>

> Cc: Richard Weinberger <richard@nod.at>

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: Brian Norris <computersforpeace@gmail.com>

> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>

> Cc: Marek Vasut <marek.vasut@gmail.com>

> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

> Cc: user-mode-linux-devel@lists.sourceforge.net

> Cc: user-mode-linux-user@lists.sourceforge.net

> Cc: linux-mtd@lists.infradead.org

> ---

>  arch/um/Kconfig.common | 1 -

>  drivers/mtd/Kconfig    | 1 -

>  lib/Kconfig            | 4 ----

>  3 files changed, 6 deletions(-)


Acked-by: Richard Weinberger <richard@nod.at>


Thanks,
//richard
Boris Brezillon Oct. 31, 2017, 10:44 a.m. UTC | #2
On Mon, 16 Oct 2017 17:16:31 -0500
Rob Herring <robh@kernel.org> wrote:

> The GENERIC_IO option is set for every architecture except tile and score

> as those define NO_IOMEM. The option only controls visibility of

> CONFIG_MTD which doesn't appear to be necessary for any reason, so let's

> just remove GENERIC_IO.

> 

> Signed-off-by: Rob Herring <robh@kernel.org>

> Cc: Jeff Dike <jdike@addtoit.com>

> Cc: Richard Weinberger <richard@nod.at>

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: Brian Norris <computersforpeace@gmail.com>

> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>


Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>


> Cc: Marek Vasut <marek.vasut@gmail.com>

> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

> Cc: user-mode-linux-devel@lists.sourceforge.net

> Cc: user-mode-linux-user@lists.sourceforge.net

> Cc: linux-mtd@lists.infradead.org

> ---

>  arch/um/Kconfig.common | 1 -

>  drivers/mtd/Kconfig    | 1 -

>  lib/Kconfig            | 4 ----

>  3 files changed, 6 deletions(-)

> 

> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common

> index 85f6dd204ab6..5514ec52108f 100644

> --- a/arch/um/Kconfig.common

> +++ b/arch/um/Kconfig.common

> @@ -9,7 +9,6 @@ config UML

>  	select HAVE_DEBUG_KMEMLEAK

>  	select GENERIC_IRQ_SHOW

>  	select GENERIC_CPU_DEVICES

> -	select GENERIC_IO

>  	select GENERIC_CLOCKEVENTS

>  	select HAVE_GCC_PLUGINS

>  	select TTY # Needed for line.c

> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig

> index 5a2d71729b9a..2a8ac6829d42 100644

> --- a/drivers/mtd/Kconfig

> +++ b/drivers/mtd/Kconfig

> @@ -1,6 +1,5 @@

>  menuconfig MTD

>  	tristate "Memory Technology Device (MTD) support"

> -	depends on GENERIC_IO

>  	help

>  	  Memory Technology Devices are flash, RAM and similar chips, often

>  	  used for solid state file systems on embedded devices. This option

> diff --git a/lib/Kconfig b/lib/Kconfig

> index b1445b22a6de..994fa37a1d96 100644

> --- a/lib/Kconfig

> +++ b/lib/Kconfig

> @@ -46,10 +46,6 @@ config GENERIC_IOMAP

>  	bool

>  	select GENERIC_PCI_IOMAP

>  

> -config GENERIC_IO

> -	bool

> -	default n

> -

>  config STMP_DEVICE

>  	bool

>
Rob Herring (Arm) Oct. 31, 2017, 7:34 p.m. UTC | #3
On Mon, Oct 16, 2017 at 5:16 PM, Rob Herring <robh@kernel.org> wrote:
> The GENERIC_IO option is set for every architecture except tile and score

> as those define NO_IOMEM. The option only controls visibility of

> CONFIG_MTD which doesn't appear to be necessary for any reason, so let's

> just remove GENERIC_IO.


Andrew, there's no clear owner for this, can you take it?

Rob

>

> Signed-off-by: Rob Herring <robh@kernel.org>

> Cc: Jeff Dike <jdike@addtoit.com>

> Cc: Richard Weinberger <richard@nod.at>

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: Brian Norris <computersforpeace@gmail.com>

> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>

> Cc: Marek Vasut <marek.vasut@gmail.com>

> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

> Cc: user-mode-linux-devel@lists.sourceforge.net

> Cc: user-mode-linux-user@lists.sourceforge.net

> Cc: linux-mtd@lists.infradead.org

> ---

>  arch/um/Kconfig.common | 1 -

>  drivers/mtd/Kconfig    | 1 -

>  lib/Kconfig            | 4 ----

>  3 files changed, 6 deletions(-)

>

> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common

> index 85f6dd204ab6..5514ec52108f 100644

> --- a/arch/um/Kconfig.common

> +++ b/arch/um/Kconfig.common

> @@ -9,7 +9,6 @@ config UML

>         select HAVE_DEBUG_KMEMLEAK

>         select GENERIC_IRQ_SHOW

>         select GENERIC_CPU_DEVICES

> -       select GENERIC_IO

>         select GENERIC_CLOCKEVENTS

>         select HAVE_GCC_PLUGINS

>         select TTY # Needed for line.c

> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig

> index 5a2d71729b9a..2a8ac6829d42 100644

> --- a/drivers/mtd/Kconfig

> +++ b/drivers/mtd/Kconfig

> @@ -1,6 +1,5 @@

>  menuconfig MTD

>         tristate "Memory Technology Device (MTD) support"

> -       depends on GENERIC_IO

>         help

>           Memory Technology Devices are flash, RAM and similar chips, often

>           used for solid state file systems on embedded devices. This option

> diff --git a/lib/Kconfig b/lib/Kconfig

> index b1445b22a6de..994fa37a1d96 100644

> --- a/lib/Kconfig

> +++ b/lib/Kconfig

> @@ -46,10 +46,6 @@ config GENERIC_IOMAP

>         bool

>         select GENERIC_PCI_IOMAP

>

> -config GENERIC_IO

> -       bool

> -       default n

> -

>  config STMP_DEVICE

>         bool

>

> --

> 2.11.0

>
Richard Weinberger Oct. 31, 2017, 8:24 p.m. UTC | #4
Am Dienstag, 31. Oktober 2017, 20:34:35 CET schrieb Rob Herring:
> On Mon, Oct 16, 2017 at 5:16 PM, Rob Herring <robh@kernel.org> wrote:

> > The GENERIC_IO option is set for every architecture except tile and score

> > as those define NO_IOMEM. The option only controls visibility of

> > CONFIG_MTD which doesn't appear to be necessary for any reason, so let's

> > just remove GENERIC_IO.

> 

> Andrew, there's no clear owner for this, can you take it?


Well, I can take it via the UML since I maintain UML and MTD. :)

Thanks,
//richard
diff mbox series

Patch

diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
index 85f6dd204ab6..5514ec52108f 100644
--- a/arch/um/Kconfig.common
+++ b/arch/um/Kconfig.common
@@ -9,7 +9,6 @@  config UML
 	select HAVE_DEBUG_KMEMLEAK
 	select GENERIC_IRQ_SHOW
 	select GENERIC_CPU_DEVICES
-	select GENERIC_IO
 	select GENERIC_CLOCKEVENTS
 	select HAVE_GCC_PLUGINS
 	select TTY # Needed for line.c
diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 5a2d71729b9a..2a8ac6829d42 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -1,6 +1,5 @@ 
 menuconfig MTD
 	tristate "Memory Technology Device (MTD) support"
-	depends on GENERIC_IO
 	help
 	  Memory Technology Devices are flash, RAM and similar chips, often
 	  used for solid state file systems on embedded devices. This option
diff --git a/lib/Kconfig b/lib/Kconfig
index b1445b22a6de..994fa37a1d96 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -46,10 +46,6 @@  config GENERIC_IOMAP
 	bool
 	select GENERIC_PCI_IOMAP
 
-config GENERIC_IO
-	bool
-	default n
-
 config STMP_DEVICE
 	bool