diff mbox series

[008/nnn] poly_int: create_integer_operand

Message ID 87zi8hsspl.fsf@linaro.org
State New
Headers show
Series [008/nnn] poly_int: create_integer_operand | expand

Commit Message

Richard Sandiford Oct. 23, 2017, 5:02 p.m. UTC 
This patch generalises create_integer_operand so that it accepts
poly_int64s rather than HOST_WIDE_INTs.


2017-10-23  Richard Sandiford  <richard.sandiford@linaro.org>
	    Alan Hayward  <alan.hayward@arm.com>
	    David Sherwood  <david.sherwood@arm.com>

gcc/
	* optabs.h (expand_operand): Add an int_value field.
	(create_expand_operand): Add an int_value parameter and use it
	to initialize the new expand_operand field.
	(create_integer_operand): Replace with a declaration of a function
	that accepts poly_int64s.  Move the implementation to...
	* optabs.c (create_integer_operand): ...here.
	(maybe_legitimize_operand): For EXPAND_INTEGER, check whether the
	mode preserves the value of int_value, instead of calling
	const_int_operand on the rtx.

Comments

Jeff Law Nov. 17, 2017, 3:37 a.m. UTC | #1 
On 10/23/2017 11:02 AM, Richard Sandiford wrote:
> This patch generalises create_integer_operand so that it accepts

> poly_int64s rather than HOST_WIDE_INTs.

> 

> 

> 2017-10-23  Richard Sandiford  <richard.sandiford@linaro.org>

> 	    Alan Hayward  <alan.hayward@arm.com>

> 	    David Sherwood  <david.sherwood@arm.com>

> 

> gcc/

> 	* optabs.h (expand_operand): Add an int_value field.

> 	(create_expand_operand): Add an int_value parameter and use it

> 	to initialize the new expand_operand field.

> 	(create_integer_operand): Replace with a declaration of a function

> 	that accepts poly_int64s.  Move the implementation to...

> 	* optabs.c (create_integer_operand): ...here.

> 	(maybe_legitimize_operand): For EXPAND_INTEGER, check whether the

> 	mode preserves the value of int_value, instead of calling

> 	const_int_operand on the rtx.

OK.
jeff
diff mbox series

Patch

Index: gcc/optabs.h
===================================================================
--- gcc/optabs.h	2017-10-23 16:52:20.393664364 +0100
+++ gcc/optabs.h	2017-10-23 17:01:02.532643107 +0100
@@ -60,6 +60,9 @@  struct expand_operand {
 
   /* The value of the operand.  */
   rtx value;
+
+  /* The value of an EXPAND_INTEGER operand.  */
+  poly_int64 int_value;
 };
 
 /* Initialize OP with the given fields.  Initialise the other fields
@@ -69,13 +72,14 @@  struct expand_operand {
 create_expand_operand (struct expand_operand *op,
 		       enum expand_operand_type type,
 		       rtx value, machine_mode mode,
-		       bool unsigned_p)
+		       bool unsigned_p, poly_int64 int_value = 0)
 {
   op->type = type;
   op->unsigned_p = unsigned_p;
   op->unused = 0;
   op->mode = mode;
   op->value = value;
+  op->int_value = int_value;
 }
 
 /* Make OP describe an operand that must use rtx X, even if X is volatile.  */
@@ -142,18 +146,7 @@  create_address_operand (struct expand_op
   create_expand_operand (op, EXPAND_ADDRESS, value, Pmode, false);
 }
 
-/* Make OP describe an input operand that has value INTVAL and that has
-   no inherent mode.  This function should only be used for operands that
-   are always expand-time constants.  The backend may request that INTVAL
-   be copied into a different kind of rtx, but it must specify the mode
-   of that rtx if so.  */
-
-static inline void
-create_integer_operand (struct expand_operand *op, HOST_WIDE_INT intval)
-{
-  create_expand_operand (op, EXPAND_INTEGER, GEN_INT (intval), VOIDmode, false);
-}
-
+extern void create_integer_operand (struct expand_operand *, poly_int64);
 
 /* Passed to expand_simple_binop and expand_binop to say which options
    to try to use if the requested operation can't be open-coded on the
Index: gcc/optabs.c
===================================================================
--- gcc/optabs.c	2017-10-23 16:52:20.393664364 +0100
+++ gcc/optabs.c	2017-10-23 17:01:02.531644016 +0100
@@ -6959,6 +6959,20 @@  valid_multiword_target_p (rtx target)
   return true;
 }
 
+/* Make OP describe an input operand that has value INTVAL and that has
+   no inherent mode.  This function should only be used for operands that
+   are always expand-time constants.  The backend may request that INTVAL
+   be copied into a different kind of rtx, but it must specify the mode
+   of that rtx if so.  */
+
+void
+create_integer_operand (struct expand_operand *op, poly_int64 intval)
+{
+  create_expand_operand (op, EXPAND_INTEGER,
+			 gen_int_mode (intval, MAX_MODE_INT),
+			 VOIDmode, false, intval);
+}
+
 /* Like maybe_legitimize_operand, but do not change the code of the
    current rtx value.  */
 
@@ -7071,7 +7085,9 @@  maybe_legitimize_operand (enum insn_code
 
     case EXPAND_INTEGER:
       mode = insn_data[(int) icode].operand[opno].mode;
-      if (mode != VOIDmode && const_int_operand (op->value, mode))
+      if (mode != VOIDmode
+	  && must_eq (trunc_int_for_mode (op->int_value, mode),
+		      op->int_value))
 	goto input;
       break;
     }