diff mbox series

[009/nnn] poly_int: TRULY_NOOP_TRUNCATION

Message ID 87tvypssob.fsf@linaro.org
State New
Headers show
Series [009/nnn] poly_int: TRULY_NOOP_TRUNCATION | expand

Commit Message

Richard Sandiford Oct. 23, 2017, 5:03 p.m. UTC 
This patch makes TRULY_NOOP_TRUNCATION take the mode sizes as
poly_uint64s instead of unsigned ints.  The function bodies
don't need to change.


2017-10-23  Richard Sandiford  <richard.sandiford@linaro.org>
	    Alan Hayward  <alan.hayward@arm.com>
	    David Sherwood  <david.sherwood@arm.com>

gcc/
	* target.def (truly_noop_truncation): Take poly_uint64s instead of
	unsigned ints.  Change default to hook_bool_puint64_puint64_true.
	* doc/tm.texi: Regenerate.
	* hooks.h (hook_bool_uint_uint_true): Delete.
	(hook_bool_puint64_puint64_true): Declare.
	* hooks.c (hook_bool_uint_uint_true): Delete.
	(hook_bool_puint64_puint64_true): New function.
	* config/mips/mips.c (mips_truly_noop_truncation): Take poly_uint64s
	instead of unsigned ints.
	* config/spu/spu.c (spu_truly_noop_truncation): Likewise.
	* config/tilegx/tilegx.c (tilegx_truly_noop_truncation): Likewise.

Comments

Jeff Law Nov. 17, 2017, 3:38 a.m. UTC | #1 
On 10/23/2017 11:03 AM, Richard Sandiford wrote:
> This patch makes TRULY_NOOP_TRUNCATION take the mode sizes as

> poly_uint64s instead of unsigned ints.  The function bodies

> don't need to change.

> 

> 

> 2017-10-23  Richard Sandiford  <richard.sandiford@linaro.org>

> 	    Alan Hayward  <alan.hayward@arm.com>

> 	    David Sherwood  <david.sherwood@arm.com>

> 

> gcc/

> 	* target.def (truly_noop_truncation): Take poly_uint64s instead of

> 	unsigned ints.  Change default to hook_bool_puint64_puint64_true.

> 	* doc/tm.texi: Regenerate.

> 	* hooks.h (hook_bool_uint_uint_true): Delete.

> 	(hook_bool_puint64_puint64_true): Declare.

> 	* hooks.c (hook_bool_uint_uint_true): Delete.

> 	(hook_bool_puint64_puint64_true): New function.

> 	* config/mips/mips.c (mips_truly_noop_truncation): Take poly_uint64s

> 	instead of unsigned ints.

> 	* config/spu/spu.c (spu_truly_noop_truncation): Likewise.

> 	* config/tilegx/tilegx.c (tilegx_truly_noop_truncation): Likewise.

OK
jeff
diff mbox series

Patch

Index: gcc/target.def
===================================================================
--- gcc/target.def	2017-10-23 17:00:20.920834919 +0100
+++ gcc/target.def	2017-10-23 17:01:04.215112587 +0100
@@ -3155,8 +3155,8 @@  is correct for most machines.\n\
 If @code{TARGET_MODES_TIEABLE_P} returns false for a pair of modes,\n\
 suboptimal code can result if this hook returns true for the corresponding\n\
 mode sizes.  Making this hook return false in such cases may improve things.",
- bool, (unsigned int outprec, unsigned int inprec),
- hook_bool_uint_uint_true)
+ bool, (poly_uint64 outprec, poly_uint64 inprec),
+ hook_bool_puint64_puint64_true)
 
 /* If the representation of integral MODE is such that values are
    always sign-extended to a wider mode MODE_REP then return
Index: gcc/doc/tm.texi
===================================================================
--- gcc/doc/tm.texi	2017-10-23 17:00:20.917834257 +0100
+++ gcc/doc/tm.texi	2017-10-23 17:01:04.214113496 +0100
@@ -10823,7 +10823,7 @@  nevertheless truncate the shift count, y
 by overriding it.
 @end deftypefn
 
-@deftypefn {Target Hook} bool TARGET_TRULY_NOOP_TRUNCATION (unsigned int @var{outprec}, unsigned int @var{inprec})
+@deftypefn {Target Hook} bool TARGET_TRULY_NOOP_TRUNCATION (poly_uint64 @var{outprec}, poly_uint64 @var{inprec})
 This hook returns true if it is safe to ``convert'' a value of
 @var{inprec} bits to one of @var{outprec} bits (where @var{outprec} is
 smaller than @var{inprec}) by merely operating on it as if it had only
Index: gcc/hooks.h
===================================================================
--- gcc/hooks.h	2017-10-23 16:52:20.369642299 +0100
+++ gcc/hooks.h	2017-10-23 17:01:04.214113496 +0100
@@ -39,7 +39,7 @@  extern bool hook_bool_const_rtx_insn_con
 							  const rtx_insn *);
 extern bool hook_bool_mode_uhwi_false (machine_mode,
 				       unsigned HOST_WIDE_INT);
-extern bool hook_bool_uint_uint_true (unsigned int, unsigned int);
+extern bool hook_bool_puint64_puint64_true (poly_uint64, poly_uint64);
 extern bool hook_bool_uint_mode_false (unsigned int, machine_mode);
 extern bool hook_bool_uint_mode_true (unsigned int, machine_mode);
 extern bool hook_bool_tree_false (tree);
Index: gcc/hooks.c
===================================================================
--- gcc/hooks.c	2017-10-23 16:52:20.369642299 +0100
+++ gcc/hooks.c	2017-10-23 17:01:04.214113496 +0100
@@ -133,9 +133,9 @@  hook_bool_mode_uhwi_false (machine_mode,
   return false;
 }
 
-/* Generic hook that takes (unsigned int, unsigned int) and returns true.  */
+/* Generic hook that takes (poly_uint64, poly_uint64) and returns true.  */
 bool
-hook_bool_uint_uint_true (unsigned int, unsigned int)
+hook_bool_puint64_puint64_true (poly_uint64, poly_uint64)
 {
   return true;
 }
Index: gcc/config/mips/mips.c
===================================================================
--- gcc/config/mips/mips.c	2017-10-23 17:00:43.528930533 +0100
+++ gcc/config/mips/mips.c	2017-10-23 17:01:04.211116223 +0100
@@ -22322,7 +22322,7 @@  mips_promote_function_mode (const_tree t
 /* Implement TARGET_TRULY_NOOP_TRUNCATION.  */
 
 static bool
-mips_truly_noop_truncation (unsigned int outprec, unsigned int inprec)
+mips_truly_noop_truncation (poly_uint64 outprec, poly_uint64 inprec)
 {
   return !TARGET_64BIT || inprec <= 32 || outprec > 32;
 }
Index: gcc/config/spu/spu.c
===================================================================
--- gcc/config/spu/spu.c	2017-10-23 17:00:43.548912356 +0100
+++ gcc/config/spu/spu.c	2017-10-23 17:01:04.212115314 +0100
@@ -7182,7 +7182,7 @@  spu_can_change_mode_class (machine_mode
 /* Implement TARGET_TRULY_NOOP_TRUNCATION.  */
 
 static bool
-spu_truly_noop_truncation (unsigned int outprec, unsigned int inprec)
+spu_truly_noop_truncation (poly_uint64 outprec, poly_uint64 inprec)
 {
   return inprec <= 32 && outprec <= inprec;
 }
Index: gcc/config/tilegx/tilegx.c
===================================================================
--- gcc/config/tilegx/tilegx.c	2017-10-23 17:00:43.551909629 +0100
+++ gcc/config/tilegx/tilegx.c	2017-10-23 17:01:04.213114405 +0100
@@ -5566,7 +5566,7 @@  tilegx_file_end (void)
    as sign-extended DI values in registers.  */
 
 static bool
-tilegx_truly_noop_truncation (unsigned int outprec, unsigned int inprec)
+tilegx_truly_noop_truncation (poly_uint64 outprec, poly_uint64 inprec)
 {
   return inprec <= 32 || outprec > 32;
 }