[15/17] clocksource/drivers/mips-gic-timer: Remove pointless irq_save,restore

Message ID 1509312035-17368-15-git-send-email-daniel.lezcano@linaro.org
State Accepted
Commit 7957b07b559175500b2a03e8a39738c1b4a832fe
Headers show
Series
  • [01/17] dt-bindings: timer: renesas, cmt: Fix SoC-specific compatible values
Related show

Commit Message

Daniel Lezcano Oct. 29, 2017, 9:20 p.m.
From: Matt Redfearn <matt.redfearn@mips.com>


The function gic_next_event is always called with interrupts disabled, so
the local_irq_save / local_irq_restore are pointless - remove them.

[Daniel Lezcano: Fixed warning by removing unused variable 'flags']

Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>

Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

---
 drivers/clocksource/mips-gic-timer.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.7.4

Patch

diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
index ae3167c..775dea0 100644
--- a/drivers/clocksource/mips-gic-timer.c
+++ b/drivers/clocksource/mips-gic-timer.c
@@ -39,16 +39,13 @@  static u64 notrace gic_read_count(void)
 
 static int gic_next_event(unsigned long delta, struct clock_event_device *evt)
 {
-	unsigned long flags;
 	u64 cnt;
 	int res;
 
 	cnt = gic_read_count();
 	cnt += (u64)delta;
-	local_irq_save(flags);
 	write_gic_vl_other(mips_cm_vp_id(cpumask_first(evt->cpumask)));
 	write_gic_vo_compare(cnt);
-	local_irq_restore(flags);
 	res = ((int)(gic_read_count() - cnt) >= 0) ? -ETIME : 0;
 	return res;
 }