| Message ID | 1509708195-25699-1-git-send-email-rogerq@ti.com |
|---|---|
| State | Accepted |
| Commit | 8ea409044ca0f8504b69ece3ef69191aa846090b |
| Headers | show |
| Series | USB: dummy-hcd: don't set gadget.speed in dummy_hub_control() | expand |
On Fri, 3 Nov 2017, Roger Quadros wrote: > There will never be a case when gadget.speed isn't already > USB_SPEED_FULL if connection is not USB-3 and gadget.speed > is not USB_SPEED_HIGH or USB_SPEED_LOW. > > Remove the unnecessary code. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > drivers/usb/gadget/udc/dummy_hcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c > index c42ca8e..41cefc5 100644 > --- a/drivers/usb/gadget/udc/dummy_hcd.c > +++ b/drivers/usb/gadget/udc/dummy_hcd.c > @@ -2166,8 +2166,6 @@ static int dummy_hub_control( > USB_PORT_STAT_LOW_SPEED; > break; > default: > - dum_hcd->dum->gadget.speed = > - USB_SPEED_FULL; > break; > } > } Acked-by: Alan Stern <stern@rowland.harvard.edu>
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index c42ca8e..41cefc5 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -2166,8 +2166,6 @@ static int dummy_hub_control( USB_PORT_STAT_LOW_SPEED; break; default: - dum_hcd->dum->gadget.speed = - USB_SPEED_FULL; break; } }
There will never be a case when gadget.speed isn't already USB_SPEED_FULL if connection is not USB-3 and gadget.speed is not USB_SPEED_HIGH or USB_SPEED_LOW. Remove the unnecessary code. Signed-off-by: Roger Quadros <rogerq@ti.com> --- drivers/usb/gadget/udc/dummy_hcd.c | 2 -- 1 file changed, 2 deletions(-) -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki