| Message ID | 20171120075019.68767-1-jc@linux.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE | expand |
On 20/11/17 07:50, Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o > see include/linux/module.h for more information > > This adds the license as "GPL", which matches the header of the file. > > MODULE_DESCRIPTION is also added. > > Signed-off-by: Jesse Chan <jc@linux.com> > --- > drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c > index 2d62a8c57332..b61d56367773 100644 > --- a/drivers/staging/comedi/drivers/ni_atmio.c > +++ b/drivers/staging/comedi/drivers/ni_atmio.c > @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = { > .detach = ni_atmio_detach, > }; > module_comedi_driver(ni_atmio_driver); > + > +MODULE_DESCRIPTION("Comedi low-level driver"); > +MODULE_LICENSE("GPL"); Thanks! I wonder how I managed to miss out this driver in commit 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI modules")? Reviewed-by: Ian Abbott <abbotti@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
On 20/11/17 10:29, Ian Abbott wrote: > On 20/11/17 07:50, Jesse Chan wrote: >> This change resolves a new compile-time warning >> when built as a loadable module: >> >> WARNING: modpost: missing MODULE_LICENSE() in >> drivers/staging/comedi/drivers/ni_atmio.o >> see include/linux/module.h for more information >> >> This adds the license as "GPL", which matches the header of the file. >> >> MODULE_DESCRIPTION is also added. >> >> Signed-off-by: Jesse Chan <jc@linux.com> >> --- >> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c >> b/drivers/staging/comedi/drivers/ni_atmio.c >> index 2d62a8c57332..b61d56367773 100644 >> --- a/drivers/staging/comedi/drivers/ni_atmio.c >> +++ b/drivers/staging/comedi/drivers/ni_atmio.c >> @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = { >> .detach = ni_atmio_detach, >> }; >> module_comedi_driver(ni_atmio_driver); >> + >> +MODULE_DESCRIPTION("Comedi low-level driver"); >> +MODULE_LICENSE("GPL"); > > Thanks! I wonder how I managed to miss out this driver in commit > 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI > modules")? > > Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Despite my above comment, we should probably give precedence to Matthew Giassa's patch for the same issue, since it was sent earlier. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
* Ian Abbott <abbotti@mev.co.uk> [2017-11-20 10:46:36 +0000]: >On 20/11/17 10:29, Ian Abbott wrote: >>On 20/11/17 07:50, Jesse Chan wrote: >>>This change resolves a new compile-time warning >>>when built as a loadable module: >>> >>>WARNING: modpost: missing MODULE_LICENSE() in >>>drivers/staging/comedi/drivers/ni_atmio.o >>>see include/linux/module.h for more information >>> >>>This adds the license as "GPL", which matches the header of the file. >>> >>>MODULE_DESCRIPTION is also added. >>> >>>Signed-off-by: Jesse Chan <jc@linux.com> >>>--- >>> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>>diff --git a/drivers/staging/comedi/drivers/ni_atmio.c >>>b/drivers/staging/comedi/drivers/ni_atmio.c >>>index 2d62a8c57332..b61d56367773 100644 >>>--- a/drivers/staging/comedi/drivers/ni_atmio.c >>>+++ b/drivers/staging/comedi/drivers/ni_atmio.c >>>@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = { >>> .detach = ni_atmio_detach, >>> }; >>> module_comedi_driver(ni_atmio_driver); >>>+ >>>+MODULE_DESCRIPTION("Comedi low-level driver"); >>>+MODULE_LICENSE("GPL"); >> >>Thanks! I wonder how I managed to miss out this driver in commit >>3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI >>modules")? >> >>Reviewed-by: Ian Abbott <abbotti@mev.co.uk> > >Despite my above comment, we should probably give precedence to >Matthew Giassa's patch for the same issue, since it was sent earlier. > >-- >-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- >-=( Web: http://www.mev.co.uk/ )=- -- Thanks. Also, this one should probably include the MODULE_AUTHOR macro as well. Cheers!
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index 2d62a8c57332..b61d56367773 100644 --- a/drivers/staging/comedi/drivers/ni_atmio.c +++ b/drivers/staging/comedi/drivers/ni_atmio.c @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = { .detach = ni_atmio_detach, }; module_comedi_driver(ni_atmio_driver); + +MODULE_DESCRIPTION("Comedi low-level driver"); +MODULE_LICENSE("GPL");
This change resolves a new compile-time warning when built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see include/linux/module.h for more information This adds the license as "GPL", which matches the header of the file. MODULE_DESCRIPTION is also added. Signed-off-by: Jesse Chan <jc@linux.com> --- drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.14.1