| Message ID | 1349432276-22919-5-git-send-email-inderpal.singh@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Fri, 2012-10-05 at 15:47 +0530, Inderpal Singh wrote: > unregister dma_device in module's remove function. > > Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org> > --- > drivers/dma/pl330.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 4b7a34d..e7dc040 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -3017,6 +3017,8 @@ static int __devexit pl330_remove(struct amba_device *adev) > return -EBUSY; > } > > + dma_async_device_unregister(&pdmac->ddma); > + > amba_set_drvdata(adev, NULL); > > list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels, Ok with this one :) Tried applying but didn't work out. You would need to regenerate this one. Thanks
On 24 October 2012 09:49, Vinod Koul <vkoul@infradead.org> wrote: > On Fri, 2012-10-05 at 15:47 +0530, Inderpal Singh wrote: >> unregister dma_device in module's remove function. >> >> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org> >> --- >> drivers/dma/pl330.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c >> index 4b7a34d..e7dc040 100644 >> --- a/drivers/dma/pl330.c >> +++ b/drivers/dma/pl330.c >> @@ -3017,6 +3017,8 @@ static int __devexit pl330_remove(struct amba_device *adev) >> return -EBUSY; >> } >> >> + dma_async_device_unregister(&pdmac->ddma); >> + >> amba_set_drvdata(adev, NULL); >> >> list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels, > > Ok with this one :) > > Tried applying but didn't work out. You would need to regenerate this > one. > I will regenerate this along with other patches and resend. With Regards, Inder > Thanks > -- > Vinod Koul > Intel Corp. >
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 4b7a34d..e7dc040 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -3017,6 +3017,8 @@ static int __devexit pl330_remove(struct amba_device *adev) return -EBUSY; } + dma_async_device_unregister(&pdmac->ddma); + amba_set_drvdata(adev, NULL); list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels,
unregister dma_device in module's remove function. Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org> --- drivers/dma/pl330.c | 2 ++ 1 file changed, 2 insertions(+)