From patchwork Wed Dec 13 09:53:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 121729 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5256993qgn; Wed, 13 Dec 2017 01:55:14 -0800 (PST) X-Google-Smtp-Source: ACJfBouIMnG038zmSt9Mj2irTg9oitpeagVmf1412jsGiM3+68r1MBy1f/o89ItKqBPf5lEyXh2W X-Received: by 10.99.142.73 with SMTP id k70mr4928178pge.426.1513158914170; Wed, 13 Dec 2017 01:55:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513158914; cv=none; d=google.com; s=arc-20160816; b=k4Bl20UaOnG5r/M9vA+vu2P0zL+B1OH7D1PicvCRz8dwz7QF/60uONtyM3TMSeda00 WZfwnh4ONPsLKT6zHNmLodL6iJ+8RFmP59PgjoZBnJXRxODOY8IN/k1AcJCmczBevdz4 PEAWJDOKJZRbUiNrhYWgm+f7DUUin/1i5DzrAawqpxwHg6/rPsUnOxzfzGdMkcjpW78g FVdk+LSzHuIiDicJTxZZLnlOEPaYlYUkpzL7UsF1gr7UGnc16Y9du56+nprZiyD7eJ6W +ZSlkPIzEWLBESvOwJs98+/1r0XnYawLATlrZ87fFF2iHa48dtQ5fHS5DVl9Rne3GgXG 3qBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=feT0mkzsi4yWrZLiEjaEY4NfSgsS7ip6gjhGbZvoQBU=; b=yf5WCJG+xkXTsEvbHOAovvgvF/3rMf3XyLIIXlx/alzeZkEVBv+MoKWsohUzCs22BG 3CLCgtbdPbcBTz/sYouymO1GNESh7R2M7+8aFtihfXW1s407G6GBPgcavpWDY7DRdRW8 +WZ6FqeKH0BPMuFsoYKuyx6wR9S0UPh/t+6kmVHg9rE9G/6u8tsE86XXhWZt8vjgX3ce YlTDGB5P65juPEE4B8gWdh50/jd4YS5KadqWzDsM6jadC+79U5noG29v+QymgplI2bEA SFusINFQ5TC5nYxAzBuHmCaLu5asJ57lfiDZP9sx+PAG5E25OXGpz1LqoTI+jLIIjQZy UsuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jOwOoBSd; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si1140380pfd.107.2017.12.13.01.55.13; Wed, 13 Dec 2017 01:55:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jOwOoBSd; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbdLMJzM (ORCPT + 11 others); Wed, 13 Dec 2017 04:55:12 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:43937 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbdLMJxi (ORCPT ); Wed, 13 Dec 2017 04:53:38 -0500 Received: by mail-pf0-f193.google.com with SMTP id e3so1096280pfi.10 for ; Wed, 13 Dec 2017 01:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=feT0mkzsi4yWrZLiEjaEY4NfSgsS7ip6gjhGbZvoQBU=; b=jOwOoBSdHME1rukBPY+lYH8diTBFsvR0jjiyDUtjx/HkfCDLx+m2XjyD0bugq3wjR+ CIAwVDM63+8QqRtD3mtOsznLxcZEaenczpzZ0eL9QrDY7Zt3jieME6Z3RpTUWq3sapqi q52yN0tUEeVIQ2+nELzBomB7/08u1CVKdYn4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=feT0mkzsi4yWrZLiEjaEY4NfSgsS7ip6gjhGbZvoQBU=; b=A4cEparogcByg21e/sCtYwMbEulKgZRaKsRnXRGh2rvPqwQD3ooV/fxfDrPrdbWaOj KkbQGqHkkWRbXMJ9jcY8Gc6Jx7skHN+SHg5aRXThqXw7upXbpMi37+ZB6iKGf39ktMuA EdeVAuwK7+LHLilpMKmHZYIlEY34s5qraw9pQ7VbrflwQopdZoFQwiIo3470enWLJ23+ nXVQvVDHFtBwdwy6YuZkYSht4piGJwCCKhUmvl/Vf+ySnZZF/GEenA+THnGuYluYVLwM sneCAqK9CagbjsUXMNo9vnpxuNvUB2TEXVIyJrf50wozNAVYrEAtNPdDz327zu8O2V+h leaw== X-Gm-Message-State: AKGB3mIzzJ/wCDRIrs3EViY6wPi9pjcZTzslmh6dDH9ksFsdZCDoo8My pRon3Bu+v9tkO9We8U5XVrSLCQ== X-Received: by 10.101.100.77 with SMTP id s13mr4816506pgv.15.1513158817125; Wed, 13 Dec 2017 01:53:37 -0800 (PST) Received: from localhost ([122.172.99.7]) by smtp.gmail.com with ESMTPSA id d81sm3005183pfj.163.2017.12.13.01.53.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2017 01:53:36 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , Ingo Molnar , Peter Zijlstra Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , dietmar.eggemann@arm.com, morten.rasmussen@arm.com, juri.lelli@redhat.com, tkjos@android.com, joelaf@google.com, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost() Date: Wed, 13 Dec 2017 15:23:22 +0530 Message-Id: <4ec5562b1a87e146ebab11fb5dde1ca9c763a7fb.1513158452.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org We are already passing sg_cpu as argument to sugov_set_iowait_boost() helper and the same can be used to retrieve the flags value. Get rid of the redundant argument. Signed-off-by: Viresh Kumar --- kernel/sched/cpufreq_schedutil.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.15.0.194.g9af6a3dea062 diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 60a2dea4c8cc..7edfdc59ee8f 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -187,10 +187,9 @@ static void sugov_get_util(unsigned long *util, unsigned long *max, int cpu) *max = cfs_max; } -static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time, - unsigned int flags) +static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time) { - if (flags & SCHED_CPUFREQ_IOWAIT) { + if (sg_cpu->flags & SCHED_CPUFREQ_IOWAIT) { sg_cpu->flags &= ~SCHED_CPUFREQ_IOWAIT; if (sg_cpu->iowait_boost_pending) @@ -273,7 +272,7 @@ static void sugov_update_single(struct update_util_data *hook, u64 time, sg_cpu->flags |= flags; - sugov_set_iowait_boost(sg_cpu, time, flags); + sugov_set_iowait_boost(sg_cpu, time); sg_cpu->last_update = time; if (!sugov_should_update_freq(sg_policy, time)) @@ -363,7 +362,7 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time, sg_cpu->max = max; sg_cpu->flags |= flags; - sugov_set_iowait_boost(sg_cpu, time, flags); + sugov_set_iowait_boost(sg_cpu, time); sg_cpu->last_update = time; if (sugov_should_update_freq(sg_policy, time)) {