| Message ID | 20171229063145.29167-36-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add hppa-softmmu | expand |
Hi, Since you're specifically CC'ing me, some nits: Am 29.12.2017 um 07:31 schrieb Richard Henderson: > This lets us tell bottom levels of virtual memory translation > routines that the access is from within QEMU itself and bypass > certain tests. This sentence could use a tweak for clarity: tell bottom levels of virtual memory translation routines ... to bypass? or that the access ... bypasses? or that this lets us ... bypass? > > Cc: Andreas Färber <afaerber@suse.de> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > include/qom/cpu.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index c2fa151228..d5361ffd0e 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -64,7 +64,8 @@ typedef uint64_t vaddr; > typedef enum MMUAccessType { > MMU_DATA_LOAD = 0, > MMU_DATA_STORE = 1, > - MMU_INST_FETCH = 2 > + MMU_INST_FETCH = 2, > + MMU_DEBUG_LOAD = 3 Given that you had to touch the previous line for your comma, it would be advisable to add one on the new line to avoid that next time. > } MMUAccessType; > > typedef struct CPUWatchpoint CPUWatchpoint; Either way please take the patch through a suitable tree. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h index c2fa151228..d5361ffd0e 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -64,7 +64,8 @@ typedef uint64_t vaddr; typedef enum MMUAccessType { MMU_DATA_LOAD = 0, MMU_DATA_STORE = 1, - MMU_INST_FETCH = 2 + MMU_INST_FETCH = 2, + MMU_DEBUG_LOAD = 3 } MMUAccessType; typedef struct CPUWatchpoint CPUWatchpoint;
This lets us tell bottom levels of virtual memory translation routines that the access is from within QEMU itself and bypass certain tests. Cc: Andreas Färber <afaerber@suse.de> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- include/qom/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.14.3