| Message ID | 20180102094443.3246258-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | db00d38e7b59ae913cfa10f1c40bf656a969fb82 |
| Headers | show |
| Series | rtc: mxc_v2: remove __exit annotation | expand |
On 02/01/2018 at 10:43:33 +0100, Arnd Bergmann wrote: > The mxc_rtc_remove is incorrectly annotated as __exit: > > `mxc_rtc_remove' referenced in section `.data' of drivers/rtc/rtc-mxc_v2.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-mxc_v2.o > > This should not be done, as devices can be dynamically bound > and unbound to a driver. > > Fixes: 54c47014b474 ("rtc: add mxc driver for i.MX53 SRTC") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/rtc/rtc-mxc_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c index b637095b0716..77a065e23a84 100644 --- a/drivers/rtc/rtc-mxc_v2.c +++ b/drivers/rtc/rtc-mxc_v2.c @@ -368,7 +368,7 @@ static int mxc_rtc_probe(struct platform_device *pdev) return 0; } -static int __exit mxc_rtc_remove(struct platform_device *pdev) +static int mxc_rtc_remove(struct platform_device *pdev) { struct mxc_rtc_data *pdata = platform_get_drvdata(pdev);
The mxc_rtc_remove is incorrectly annotated as __exit: `mxc_rtc_remove' referenced in section `.data' of drivers/rtc/rtc-mxc_v2.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-mxc_v2.o This should not be done, as devices can be dynamically bound and unbound to a driver. Fixes: 54c47014b474 ("rtc: add mxc driver for i.MX53 SRTC") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/rtc/rtc-mxc_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0