| Message ID | nycvar.YSQ.7.76.1801051636340.1528@knanqh.ubzr |
|---|---|
| State | New |
| Headers | show |
| Series | console/dummy: leave .con_font_get set to NULL | expand |
On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote: > > When this method is set, the caller expects struct console_font fields > to be properly initialized when it returns. Leave it unset otherwise > nonsensical (leaked kernel stack) values are returned to user space. > > Signed-off-by: Nicolas Pitre <nico@linaro.org> > Cc: stable@kernel.org Please check your patches with tools/checkpatch.pl script: ERROR: The 'stable' address should be 'stable@vger.kernel.org' #9: Cc: stable@kernel.org After updating this I queued the patch for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c index 9269d56852..b90ef96e43 100644 --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };
When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space. Signed-off-by: Nicolas Pitre <nico@linaro.org> Cc: stable@kernel.org -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html