diff mbox series

ARM: dts: s5pv210: add interrupt-parent for ohci

Message ID 20180110161045.4052684-1-arnd@arndb.de
State Accepted
Commit 5c1037196b9ee75897c211972de370ed1336ec8f
Headers show
Series ARM: dts: s5pv210: add interrupt-parent for ohci | expand

Commit Message

Arnd Bergmann Jan. 10, 2018, 4:10 p.m. UTC
The ohci-hcd node has an interrupt number but no interrupt-parent,
leading to a warning with current dtc versions:

arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

As seen from the related exynos dts files, the ohci and ehci controllers
always share one interrupt number, and the number is the same here as
well, so setting the same interrupt-parent is the reasonable solution
here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/boot/dts/s5pv210.dtsi | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

Comments

Arnd Bergmann Jan. 15, 2018, 1 p.m. UTC | #1
On Thu, Jan 11, 2018 at 9:09 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:

>> The ohci-hcd node has an interrupt number but no interrupt-parent,

>> leading to a warning with current dtc versions:

>>

>> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

>> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

>> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

>> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

>> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

>>

>> As seen from the related exynos dts files, the ohci and ehci controllers

>> always share one interrupt number, and the number is the same here as

>> well, so setting the same interrupt-parent is the reasonable solution

>> here.

>

> Your patch is correct. However my last pull request still waits and it

> is quite late in this release cycle so I will apply it for v4.17 after

> this merge window. On the other hand you can take it directly (in that

> case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).


Applied to next/dt, thanks!

      Arnd
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 247c0029659c..67358562a6ea 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -460,6 +460,7 @@ 
 			compatible = "samsung,exynos4210-ohci";
 			reg = <0xec300000 0x100>;
 			interrupts = <23>;
+			interrupt-parent = <&vic1>;
 			clocks = <&clocks CLK_USB_HOST>;
 			clock-names = "usbhost";
 			#address-cells = <1>;