| Message ID | 20180111103646.1462765-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | d9f523723bc794e1851024958a6add303ba67b6c |
| Headers | show |
| Series | [net-next] net: socionext: include linux/io.h to fix build | expand |
On 11 January 2018 at 10:36, Arnd Bergmann <arnd@arndb.de> wrote: > I ran into a randconfig build failure: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe': > drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] > > Including linux/io.h directly fixes this. > > Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for fixing this. This is the same issue spotted by kbuild test robot. Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > drivers/net/ethernet/socionext/netsec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c > index a8edcf387bba..af47147dd656 100644 > --- a/drivers/net/ethernet/socionext/netsec.c > +++ b/drivers/net/ethernet/socionext/netsec.c > @@ -8,6 +8,7 @@ > #include <linux/of_mdio.h> > #include <linux/etherdevice.h> > #include <linux/interrupt.h> > +#include <linux/io.h> > > #include <net/tcp.h> > #include <net/ip6_checksum.h> > -- > 2.9.0 >
From: Arnd Bergmann <arnd@arndb.de> Date: Thu, 11 Jan 2018 11:36:24 +0100 > I ran into a randconfig build failure: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe': > drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] > > Including linux/io.h directly fixes this. > > Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thank you.
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index a8edcf387bba..af47147dd656 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -8,6 +8,7 @@ #include <linux/of_mdio.h> #include <linux/etherdevice.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <net/tcp.h> #include <net/ip6_checksum.h>
I ran into a randconfig build failure: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe': drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] Including linux/io.h directly fixes this. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/socionext/netsec.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0